continuous-integration/drone/push Build is passingDetails
* 3 News items are displayed on the homepage (`MiniNewsCard` component)
* Single News item path: `/news/20xx/term/20xx-xx-xx` (`NewsCard` component)
* Purple header for the date
* News items of the same date are displayed on the same page
Co-authored-by: Miniapple8888 <miniapple8888@gmail.com>
Reviewed-on: #390
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Update:
In order to solve the issues discussed below, we decided to put the warnings in a json file, since they can be easily imported into a javascript file and webpack automatically bundles them with the client side app, so no static props is needed.
__________
To get the warning data, since it is something that needs to be on all pages, it makes sense for the component to go in the app.js file (similar to the nav bar). However, next.js has a cumbersome issue that it does not support getStaticProps in the app.ts file (and getStaticProps only works in page files), thus we have no way of requesting the warning data easily in the \<WarningHeader\> Component. (https://github.com/vercel/next.js/discussions/10949)
Here is my solution:
- Request the warning data on the client side through the use of an api.
- I made a warning api (/api/currentWarning) which sends a json of the current warning
- Advantage: warnings will always be up to date since it is recalculated on every request
- Advantage: It can potentially incorporate with other CSC services who might need to know about the warning (eg linktree?)
- Disadvantage: can get expensive if we have a lot of warnings, to fix this I can cache the current warning and only re-read the files every 24h if this is a problem, but if we don’t have that many warnings I think it should be fine
- Disadvantage: listed below:
The current problem with what I implemented is that it doesn’t build in the production environment:
- The way we build the website, when we call “next export” that disables any api endpoints.
- According to this https://github.com/vercel/vercel/discussions/6551, if we want to allow api endpoints, we have to just do “next build”. This has implications that the site won’t be completely static anymore, but the other solutions also have similar problems ( though the GitHub post says that next will still optimize for static with only next build).
Another advantage of allowing api’s is that maybe in the future we will implement other features where an api might be useful.
If you want to try it out, my branch works fine locally (when just running npm run dev or npm run build”)
Other possible solutions:
- Use getInitialProps inside _app.js, but this has the downside that it will “disable Automatic Static Optimization in pages without Static Generation.” (https://nextjs.org/docs/advanced-features/custom-app), which I believe will slow the whole site down, but, we will be able to still use the old build command I think, I am not sure of the full effect of this.
- However, implementing this would also be relatively simple.
- Add the warning request to the getStaticProps of every single page, possibly through some wrapper component around every single page, this has the disadvantage that we need to do a lot of refactoring of all the pages of the site and cant use the intended “_app.ts” wrapper.
- Add warning header only to the homepage (or maybe one or two other important pages).
Co-authored-by: shahanneda <shahan.neda@gmail.com>
Reviewed-on: #394
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Reviewed-on: #399
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
Co-authored-by: Raymond Li <raymo@csclub.uwaterloo.ca>
Co-committed-by: Raymond Li <raymo@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
If Head of Discord, Heads of Design, Head of Reps are to be included, just notify me ~ 😃
Co-authored-by: Rebecca-Chou <beihaozhou@gmail.com>
Reviewed-on: #383
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
Reviewed-by: j285he <j285he@localhost>
Reviewed-by: n3parikh <n3parikh@csclub.uwaterloo.ca>
Co-authored-by: Beihao Zhou <b72zhou@csclub.uwaterloo.ca>
Co-committed-by: Beihao Zhou <b72zhou@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Reviewed-on: #395
Reviewed-by: Amy <a258wang@csclub.uwaterloo.ca>
Co-authored-by: Raymond Li <raymo@csclub.uwaterloo.ca>
Co-committed-by: Raymond Li <raymo@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Andy (Head of Discord) asked that we change the label for the Discord team members on the Meet the Team page from "Discord Mod" to either "Codey Coder" or "Discord". I have opted to change it to simply "Discord" for clarity.
When we separate the teams on the Meet the Team page (#364), please change "Discord" to "Developer" (similar to what we have for the Web Committee).
Co-authored-by: Amy <a258wang@uwaterloo.ca>
Reviewed-on: #393
Reviewed-by: Emily Chiu <e26chiu@csclub.uwaterloo.ca>
Co-authored-by: Amy <a258wang@csclub.uwaterloo.ca>
Co-committed-by: Amy <a258wang@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
Added the upcoming Afterhours: Diversity in Tech event, as well as the Beginning of Term event that happened last week.
Co-authored-by: Amy <a258wang@uwaterloo.ca>
Reviewed-on: #389
Reviewed-by: Emily Chiu <e26chiu@csclub.uwaterloo.ca>
Co-authored-by: Amy <a258wang@csclub.uwaterloo.ca>
Co-committed-by: Amy <a258wang@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [@next/mdx](https://github.com/vercel/next.js) | dependencies | minor | [`11.0.1` -> `11.1.3`](https://renovatebot.com/diffs/npm/@next%2fmdx/11.0.1/11.1.3) |
⚠️ Release Notes retrieval for this PR were skipped because no github.com credentials were available.
If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Co-authored-by: Aditya Thakral <github@9at8.dev>
Reviewed-on: #143
Reviewed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-authored-by: Renovate Bot <no-reply@csclub.uwaterloo.ca>
Co-committed-by: Renovate Bot <no-reply@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [npm](https://docs.npmjs.com/) ([source](https://github.com/npm/cli)) | engines | major | [`^7` -> `^8.0.0`](https://renovatebot.com/diffs/npm/npm/7.24.2/8.3.1) |
⚠️ Release Notes retrieval for this PR were skipped because no github.com credentials were available.
If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Co-authored-by: Aditya Thakral <github@9at8.dev>
Reviewed-on: #340
Reviewed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-authored-by: Renovate Bot <no-reply@csclub.uwaterloo.ca>
Co-committed-by: Renovate Bot <no-reply@csclub.uwaterloo.ca>
continuous-integration/drone/push Build is passingDetails
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [postcss-preset-env](https://github.com/csstools/postcss-plugins) | devDependencies | major | [`^6.7.0` -> `^7.0.0`](https://renovatebot.com/diffs/npm/postcss-preset-env/6.7.0/7.2.3) |
⚠️ Release Notes retrieval for this PR were skipped because no github.com credentials were available.
If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/examples/self-hosting.md#githubcom-token-for-release-notes).
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Co-authored-by: Aditya Thakral <github@9at8.dev>
Reviewed-on: #360
Reviewed-by: Aditya Thakral <a3thakra@csclub.uwaterloo.ca>
Co-authored-by: Renovate Bot <no-reply@csclub.uwaterloo.ca>
Co-committed-by: Renovate Bot <no-reply@csclub.uwaterloo.ca>
Beihao Zhou
Mark Chiu
Shahan Nedadahandeh
Rebecca-Chou
Raymond Li
Amy Wang
Renovate Bot
Jared He