www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

OrganizedContent #10

New Issue
Closed
opened 2021-04-25 16:10:10 -04:00 by a3thakra · 45 comments
a3thakra commented 2021-04-25 16:10:10 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link
  • Sidebar
  • Content
  • Prev/Next button

This component should not maintain any internal state that represents the currently selected item. You should instead push this state outwards and use props.

- [x] Sidebar - [x] Content - [x] Prev/Next button This component should not maintain any internal state that represents the currently selected item. You should instead push this state outwards and use props.
a3thakra commented 2021-04-25 16:11:00 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

mentioned in issue #11

mentioned in issue #11
a3thakra commented 2021-04-25 16:13:02 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

mentioned in issue #12

mentioned in issue #12
a3thakra commented 2021-04-25 16:17:07 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

mentioned in issue #17

mentioned in issue #17
a3thakra commented 2021-04-25 17:41:11 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 design

added [1 design](/csc/website/-/issues/10/designs?version=138)
w25tran commented 2021-04-27 00:37:11 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

assigned to @w25tran

assigned to @w25tran
a3thakra commented 2021-05-09 20:00:20 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

removed 1 design

removed [1 design](/csc/website/-/issues/10/designs?version=144)
a3thakra commented 2021-05-10 05:11:08 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 design

added [1 design](/csc/website/-/issues/10/designs?version=145)
dora commented 2021-05-16 21:21:33 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 commit

  • c8f6ecff - Clean up CSS

Compare with previous version

added 1 commit <ul><li>c8f6ecff - Clean up CSS</li></ul> [Compare with previous version](/csc/website/-/merge_requests/10/diffs?diff_id=55356&start_sha=1e86ffa4f38ded53b9a2e6f6b87d2e31e52f1af7)
a3thakra commented 2021-05-16 22:05:52 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

i think a flex box with the flex-wrap: wrap might be a better idea. That would automatically make #columns = 3 on a smaller screen.

i think a flex box with the `flex-wrap: wrap` might be a better idea. That would automatically make #columns = 3 on a smaller screen.
a3thakra commented 2021-05-18 03:33:15 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

I don't think that this is the correct use of the figure tag. From MDN:

Usually a <figure> is an image, illustration, diagram, code snippet, etc., that is referenced in the main flow of a document, but that can be moved to another part of the document or to an appendix without affecting the main flow.

But we need it to be part of the main flow of the meet the team page. :)

I don't think that this is the correct use of the figure tag. From MDN: > Usually a `<figure>` is an image, illustration, diagram, code snippet, etc., that is referenced in the main flow of a document, but that can be moved to another part of the document or to an appendix without affecting the main flow. But we need it to be part of the main flow of the meet the team page. :)
a3thakra commented 2021-05-18 03:36:30 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

you should use the next image tag instead: https://nextjs.org/docs/api-reference/next/image

why? : https://nextjs.org/docs/basic-features/image-optimization

you should use the next image tag instead: https://nextjs.org/docs/api-reference/next/image why? : https://nextjs.org/docs/basic-features/image-optimization
a3thakra commented 2021-05-19 18:11:01 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed the description

changed the description
a3thakra commented 2021-05-19 18:35:50 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

scratch that, don't use the <Image /> tag

Why? #26

scratch that, don't use the `<Image />` tag Why? #26
a3thakra commented 2021-05-20 00:01:07 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

requested review from @n3parikh

requested review from @n3parikh
a3thakra commented 2021-05-20 00:01:12 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

requested review from @a3thakra and removed review request for @n3parikh

requested review from @a3thakra and removed review request for @n3parikh
a3thakra commented 2021-05-20 00:02:03 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

assigned to @n3parikh

assigned to @n3parikh
a3thakra commented 2021-05-20 00:02:10 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

assigned to @a3thakra and unassigned @n3parikh

assigned to @a3thakra and unassigned @n3parikh
a3thakra commented 2021-05-20 00:02:13 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

unassigned @a3thakra

unassigned @a3thakra
a3thakra commented 2021-05-20 00:02:33 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

sorry ignore these ^

just trying something out

sorry ignore these ^ just trying something out
dora commented 2021-05-20 03:54:06 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

gj adi! jk jk dw about it 😂

image

gj adi! jk jk dw about it :joy: ![image](/uploads/af83c0ab33c7817f57a502ffce4d4f7d/image.png)
dora commented 2021-05-20 03:55:45 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

closing this since this is more so for #9

closing this since this is more so for #9
dora commented 2021-05-20 04:12:26 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 4 commits

  • 4393037e - 1 commit from branch main
  • 2c30d8b2 - team member component + desktop styling
  • 918bf748 - Mobile styling
  • 9087df45 - Clean up CSS

Compare with previous version

added 4 commits <ul><li>4393037e - 1 commit from branch <code>main</code></li><li>2c30d8b2 - team member component + desktop styling</li><li>918bf748 - Mobile styling</li><li>9087df45 - Clean up CSS</li></ul> [Compare with previous version](/csc/website/-/merge_requests/10/diffs?diff_id=55576&start_sha=c8f6ecffe9855b1ae16d4305bf4b0c324a8b89e4)
dora commented 2021-05-20 04:15:36 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

hmm should i just use <div> then?

hmm should i just use `<div>` then?
a3thakra commented 2021-05-20 08:14:54 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

Yep

Yep
dora commented 2021-05-20 09:29:18 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/csc/website/-/merge_requests/10/diffs?diff_id=55586&start_sha=9087df45d0b407e3313b5e4ce6ec8e4477fd6e93#48e1f56bc3d9b5c6d8e46ee26606c785ec9e2977_19_18)
dora commented 2021-05-20 09:29:18 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 commit

  • b5384070 - Change figure/figcaption to div

Compare with previous version

added 1 commit <ul><li>b5384070 - Change figure/figcaption to div</li></ul> [Compare with previous version](/csc/website/-/merge_requests/10/diffs?diff_id=55586&start_sha=9087df45d0b407e3313b5e4ce6ec8e4477fd6e93)
a3thakra commented 2021-05-21 02:45:52 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link
        <div className={styles.name}>{name}</div>
        <div className={styles.role}>{role}</div>

You should use a div here instead. span apparently does not have a lot of semantic meaning 🤷 https://developer.mozilla.org/en-US/docs/Web/HTML/Element/span

Since div is a block element, it lets us avoid that <br /> tag.

```suggestion:-2+0 <div className={styles.name}>{name}</div> <div className={styles.role}>{role}</div> ``` You should use a `div` here instead. `span` apparently does not have a lot of semantic meaning :shrug: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/span Since `div` is a block element, it lets us avoid that `<br />` tag.
a3thakra commented 2021-05-21 02:50:32 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

After replacing spans with divs, you most likely wouldn't need these.

```suggestion:-0+0 ``` After replacing `span`s with `div`s, you most likely wouldn't need these.
dora commented 2021-05-21 22:07:53 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/csc/website/-/merge_requests/10/diffs?diff_id=55834&start_sha=b5384070f41e269994a4c0d2c317aadc697d823c#48e1f56bc3d9b5c6d8e46ee26606c785ec9e2977_17_15)
dora commented 2021-05-21 22:07:53 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/csc/website/-/merge_requests/10/diffs?diff_id=55834&start_sha=b5384070f41e269994a4c0d2c317aadc697d823c#0b1e33e0c4f066c2397757897573e1d2ed794829_19_15)
dora commented 2021-05-21 22:07:53 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 commit

  • 05b31f31 - Adi's fixes

Compare with previous version

added 1 commit <ul><li>05b31f31 - Adi&#39;s fixes</li></ul> [Compare with previous version](/csc/website/-/merge_requests/10/diffs?diff_id=55834&start_sha=b5384070f41e269994a4c0d2c317aadc697d823c)
a3thakra commented 2021-05-23 18:44:48 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

team-member-fluid-grid

I removed tablet styles, and made the playground grid fluid - https://css-tricks.com/snippets/css/complete-guide-grid/#fluid-columns-snippet

![team-member-fluid-grid](/uploads/00a80a994954ce34b23a8b366b799699/team-member-fluid-grid.gif) I removed tablet styles, and made the playground grid fluid - https://css-tricks.com/snippets/css/complete-guide-grid/#fluid-columns-snippet
a3thakra commented 2021-05-23 18:46:35 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/10/diffs?diff_id=56088&start_sha=05b31f31d0f0d978de3cef72da195a1c077574dc#d0aefa89ef70566d4de4f9214ef7775585e10e18_99_93)
a3thakra commented 2021-05-23 18:46:35 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 commit

  • ba7cef52 - Fluid grid + remove tablet styles

Compare with previous version

added 1 commit <ul><li>ba7cef52 - Fluid grid + remove tablet styles</li></ul> [Compare with previous version](/csc/website/-/merge_requests/10/diffs?diff_id=56088&start_sha=05b31f31d0f0d978de3cef72da195a1c077574dc)
a3thakra commented 2021-05-23 18:47:39 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

approved this merge request

approved this merge request
a3thakra commented 2021-05-23 18:48:00 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 7 commits

Compare with previous version

added 7 commits <ul><li>8a9935ba - 1 commit from branch <code>main</code></li><li>1ad6432e - team member component + desktop styling</li><li>f040b93b - Mobile styling</li><li>22c59659 - Clean up CSS</li><li>c4546617 - Change figure/figcaption to div</li><li>99c09c1d - Adi&#39;s fixes</li><li>479ccb82 - Fluid grid + remove tablet styles</li></ul> [Compare with previous version](/csc/website/-/merge_requests/10/diffs?diff_id=56090&start_sha=ba7cef526c8e16df5238e0bd88f423dc863578be)
a3thakra commented 2021-05-23 18:48:19 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

enabled an automatic merge when the pipeline for 479ccb825e succeeds

enabled an automatic merge when the pipeline for 479ccb825eb52cb7b77a7c7024aa2039b17fbf43 succeeds
a3thakra commented 2021-05-23 18:50:53 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

canceled the automatic merge

canceled the automatic merge
a3thakra commented 2021-05-23 18:53:55 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/csc/website/-/merge_requests/10/diffs?diff_id=56095&start_sha=479ccb825eb52cb7b77a7c7024aa2039b17fbf43#48e1f56bc3d9b5c6d8e46ee26606c785ec9e2977_13_14)
a3thakra commented 2021-05-23 18:53:55 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>823e0597 - Use Image instead of img</li></ul> [Compare with previous version](/csc/website/-/merge_requests/10/diffs?diff_id=56095&start_sha=479ccb825eb52cb7b77a7c7024aa2039b17fbf43)
a3thakra commented 2021-05-23 18:54:31 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

enabled an automatic merge when the pipeline for 823e059721 succeeds

enabled an automatic merge when the pipeline for 823e059721c4ccebd09452cf3427c76358aba0ad succeeds
w25tran commented 2021-05-31 02:54:17 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

marked the task Sidebar as completed

marked the task **Sidebar** as completed
w25tran commented 2021-05-31 02:54:18 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

marked the task Content as completed

marked the task **Content** as completed
w25tran commented 2021-05-31 02:54:18 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

marked the task Prev/Next button as completed

marked the task **Prev/Next button** as completed
w25tran commented 2021-05-31 02:54:59 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

mentioned in merge request !12

mentioned in merge request !12
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
internship-guide-2
nextcloud-widget
exec-blurb
renovate/typescript-5.x
renovate/next-14.x
renovate/ical-generator-7.x
renovate/date-fns-3.x
renovate/typescript-eslint-parser-7.x
renovate/typescript-eslint-eslint-plugin-7.x
renovate/next-mdx-14.x
renovate/mdx-js-react-3.x
renovate/mdx-js-loader-3.x
renovate/node-18.x
Ev-New-Event-Csc-Circles-Easter-Egg-Hunt-March-27-2024-1711581834781
Ev-New-Event-Taxes-101-March-27-2024-1711581616630
Ev-New-Event-Csc-Circles-Movie-Night-March-27-2024-1711581333300
Ev-New-Event-Csc-Codeylympics-Ii-March-27-2024-1711581176020
Ev-New-Event-Csc-Trivia-Night-March-27-2024-1711580949130
Ev-New-Event-Info-Session-For-Ura-Grad-Opportunities-March-27-2024-1711580809155
Ev-New-Event-Internship-Insights-March-27-2024-1711580694779
Ev-New-Event-Jason-Goodison-Talk-March-27-2024-1711580404155
Ev-New-Event-Test-Event-March-27-2024-1711580239047
exec-blurbs
internship-guide
Ev-New-Event-Valentines-Code-Party-February-11-2024-1707695692668
Ev-New-Event-Csc-Codeylympics-February-11-2024-1707695587472
Ev-New-Event-Fall-2023-Elections-February-11-2024-1707695274434
Ev-New-Event-Csc-End-Of-Term-February-11-2024-1707694525395
Ev-New-Event-Csc-Dodgeball-Tournament-February-11-2024-1707694725304
Ev-New-Event-November-Code-Party-February-11-2024-1707681589953
Ev-New-Event-Trivia-Night-February-08-2024-1707443541421
Ev-New-Event-Escape-Mc-Manor-February-08-2024-1707443356540
Ev-New-Event-Recruiters-Panel-February-11-2024-1707682002638
Ev-New-Event-W24-Bootcamp-February-04-2024-1707084574336
Ev-New-Event-David-Wolever-Postgresql-Talk-February-04-2024-1707084327590
Ev-New-Event-Csc-Beginning-Of-Term-February-04-2024-1707083704858
Ev-New-Event-Csc-Beginning-Of-Term-February-04-2024-1707076757770
Ev-New-Event-Escape-Mc-Manor-February-01-2024-1706839752816
Ev-New-Event-Csc-Beginning-Of-Term-February-01-2024-1706830083872
update-team-page
Ev-New-Event-Csc-Beginning-Of-Term-January-22-2024-1705976938370
n4chung/update-online-membership-note
richard/update-exec-640
Ev-New-Event-Build-Networks-In-Tech-November-15-2023-1700094289813
Ev-New-Event-Build-Networks-In-Tech-November-15-2023-1700093575650
Ev-New-Event-Acing-The-Technical-Interview-W-Icpc-Coach-Christian-Lim-November-15-2023-1700090655704
fix-adding-class-profile-to-team-page
Ev-New-Event-A-November-06-2023-1699317492840
Ev-New-Event-A-November-06-2023-1699317323665
Ev-New-Event-A-November-06-2023-1699317144162
Ev-New-Event-A-November-06-2023-1699298328549
daniel-su/add-myself-to-website
renovate/node-21.x
Ev-New-Event-A-November-06-2023-1699296715918
Ev-New-Event-A-November-06-2023-1699296856594
Ev-New-Event-A-November-06-2023-1699297090365
Ev-New-Event-Test-November-06-2023-1699295917474
Ev-New-Event-Test-November-06-2023-1699296519244
renovate/remark-html-16.x
renovate/ldapts-7.x
renovate/npm-10.x
renovate/remark-15.x
add-s23-events
renovate/eslint-config-prettier-9.x
amy-remove-caffeine
anniesun/add-office-status
renovate/eslint-plugin-prettier-5.x
renovate/typescript-eslint-parser-5.x
renovate/prettier-3.x
renovate/postcss-preset-env-9.x
Ev-New-Event-Test-Event-June-17-2023-1687022992622
Ev-New-Event-Test-June-10-2023-1686447073380
Ev-New-Event-123-June-10-2023-1686446983999
Ev-New-Event-123-June-10-2023-1686446849710
Ev-New-Event-123-June-10-2023-1686446643513
Ev-New-Event-Test-June-10-2023-1686446470699
Ev-New-Event-Test-June-10-2023-1686437048471
Ev-New-Event-Test-Event-June-10-2023-1686436739371
Ev-New-Event-Test-Event-From-Eventr-June-10-2023-1686435846281
Ev-New-Event-Test-June-10-2023-1686435577325
shahanneda/add-tropical-code-party
add-imane-photo
Ev-New-Event-123-June-07-2023-1686113292428
Ev-New-Event-123-June-07-2023-1686113019308
meet-the-team
meet-team
meet_the_team
raymo-s23-updates
change_AVP_treasurer
jan-2023-constitution-changes
renovate/node-20.x
renovate/postcss-calc-9.x
renovate/react-dom-18.x
renovate/react-18.x
renovate/fs-extra-11.x
renovate/date-fns-tz-2.x
renovate/typescript-4.x
renovate/next-11.x
renovate/squoosh-lib-0.x
renovate/next-mdx-remote-3.x
renovate/next-mdx-11.x
April-Code-Party
add-name-to-web-committe
shahanneda/alt-tab-and-cp
darren/fix-dead-link
darren/add-class-profile-news
richardshuai/karaoke
shahanneda/update-team
w23-update-team
anniesun/update-blurbs
shahanneda/add-code-party-23
annies/add-circles-event
darren/add-news
anniesun/add-myself-to-webstite
darren/add-myself-to-website
shahanneda/add-myself
shahanneda/fix-name-parts
shahanneda/add-bot
update-events
shahanneda/add-events
shahanneda/fix-build-image-script
amy-add-alt-tab-f22
shahanneda/add-alt-tab-news
amy-events-karaoke
amy-update-annie-headshot-f22
amy-update-internship-repo-f22
amy-fix-vp-f22
amy-add-librarian-f22
shahanneda/update-exec-blurbs
shahanneda/add-code-party-1
shahanneda/update-project-program
a258wang-events-2022-09-28
amy-news-2022-09-14
news-2022-09-10
j285he-add-news-09-07
news-2022-09-08
amy-events-august-2022
amy-update-community-reps
shahanneda/add-event
2022-07-08-MUA-Update
amy-image-optimization-quick-fix-experiment
b72zhou-past-exec
shahanneda/optimze-image-script
neil-members
unix101-1
warning-header
ldap-exec-test
support-multiple-news-homepage
j285he-ldap-test-example
renovate/typescript-eslint-eslint-plugin-5.x
renovate/eslint-plugin-react-7.x
renovate/eslint-plugin-prettier-4.x
renovate/eslint-8.x
shahanneda-news-11jan2022
bonnie-team-member-card
fix-oc-burger
amy-random-shapes
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#10
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?