www
/
www-new
12
2
Fork 3
Code Issues 56 Pull Requests 29 Projects Releases Wiki Activity
Labels Milestones
New Issue

Constitution page #11

Closed
opened 2 years ago by a3thakra · 24 comments
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

#10 OrganizedContent Component

#10 OrganizedContent Component
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed the description

changed the description
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed the description

changed the description
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed title from Event{-Feat-} to Event{+Card+}

changed title from **Event{-Feat-}** to **Event{+Card+}**
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 1 commit

Compare with previous version

added 1 commit <ul><li>2887568d - Change CSS file name</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=55364&start_sha=2871e7ea88b5ff61f92b69add12d98182bf57a3f)
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed the description

changed the description
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 5 commits

  • 2887568d...8a9935ba - 2 commits from branch main
  • baf13af5 - Change css and props
  • 051fa143 - Merge branch 'main' into feat/event-card
  • 1449f987 - Add image tag

Compare with previous version

added 5 commits <ul><li>2887568d...8a9935ba - 2 commits from branch <code>main</code></li><li>baf13af5 - Change css and props</li><li>051fa143 - Merge branch &#39;main&#39; into feat/event-card</li><li>1449f987 - Add image tag</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=55916&start_sha=2887568d076bebc76cf9ef7cb1a6fdd35c29cb11)
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed the description

changed the description
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

Flexbox and width wouldn't work for some reason so I took some ideas from here: https://css-tricks.com/making-width-and-flexible-items-play-nice-together/

Flexbox and width wouldn't work for some reason so I took some ideas from here: https://css-tricks.com/making-width-and-flexible-items-play-nice-together/
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 2 commits

Compare with previous version

added 2 commits <ul><li>ed9724a3 - 1 commit from branch <code>main</code></li><li>9227656d - Fix merge conflicts</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=56122&start_sha=1449f987cd32f4047d54afcead4a00d37197523b)
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 1 commit

Compare with previous version

added 1 commit <ul><li>297b310e - ESLint</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=56123&start_sha=9227656dc80c3106db53a3a9905d8b2a14eeabe9)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

This should be an article

This should be an article
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

This should be a section.

This should be a section.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

you should not prefix css classes with eventCard because we're using css modules. It automatically does that for us.
image

you should not prefix css classes with `eventCard` because we're using css modules. It automatically does that for us. ![image](/uploads/98d409a14047a8acc1c2e54d2f8af90b/image.png)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

this is actually a purple 2 on figma

this is actually a purple 2 on figma
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

You shouldn't rely on this being a button. Use a class here instead. Look at how Button is implemented in !8.

You shouldn't rely on this being a button. Use a class here instead. Look at how Button is implemented in !8.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#1a5bce3caef7b87cdf5e4c73a60b5e23b4c57cd6_29_28)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#1a5bce3caef7b87cdf5e4c73a60b5e23b4c57cd6_37_36)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#e6d872e4d909fd4c233e90c32652c4446830d686_23_23)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#e6d872e4d909fd4c233e90c32652c4446830d686_33_31)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#e6d872e4d909fd4c233e90c32652c4446830d686_19_19)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 1 commit

Compare with previous version

added 1 commit <ul><li>e2f02681 - Final fixes</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

approved this merge request

approved this merge request
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

I just pushed e2f02681 to address the comments above. (They were pretty minor comments, so I went ahead and committed them to your branch :) )

Great job on the event card btw!

I just pushed e2f02681 to address the comments above. (They were pretty minor comments, so I went ahead and committed them to your branch :) ) Great job on the event card btw!
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

enabled an automatic merge when the pipeline for e2f026811a succeeds

enabled an automatic merge when the pipeline for e2f026811aecf23c53e3d0a38edf58772e5be0e8 succeeds
a3thakra added this to the First Draft milestone 2 years ago
w25tran self-assigned this 2 years ago
w25tran added the
In Progress
 label 2 years ago
w25tran was unassigned by a3thakra 2 years ago
a3thakra self-assigned this 2 years ago
a3thakra closed this issue 2 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
2022-07-08-MUA-Update
a258wang-events-2022-09-28
add-name-to-web-committe
amy-add-alt-tab-f22
amy-add-librarian-f22
amy-events-august-2022
amy-events-karaoke
amy-fix-vp-f22
amy-image-optimization-quick-fix-experiment
amy-news-2022-09-14
amy-random-shapes
amy-update-annie-headshot-f22
amy-update-community-reps
amy-update-internship-repo-f22
annies/add-circles-event
anniesun/add-myself-to-webstite
anniesun/update-blurbs
b72zhou-past-exec
bonnie-team-member-card
darren/add-class-profile-news
darren/add-myself-to-website
darren/add-news
darren/fix-dead-link
fix-oc-burger
j285he-add-news-09-07
j285he-ldap-test-example
jan-2023-constitution-changes
ldap-exec-test
main
neil-members
news-2022-09-08
news-2022-09-10
renovate/date-fns-tz-2.x
renovate/eslint-8.x
renovate/eslint-plugin-prettier-4.x
renovate/eslint-plugin-react-7.x
renovate/fs-extra-11.x
renovate/ldapts-4.x
renovate/mdx-js-loader-2.x
renovate/mdx-js-react-2.x
renovate/next-11.x
renovate/next-13.x
renovate/next-mdx-11.x
renovate/next-mdx-13.x
renovate/next-mdx-remote-3.x
renovate/node-18.x
renovate/node-19.x
renovate/npm-9.x
renovate/postcss-preset-env-8.x
renovate/react-18.x
renovate/react-dom-18.x
renovate/remark-14.x
renovate/remark-html-15.x
renovate/squoosh-lib-0.x
renovate/typescript-4.x
renovate/typescript-5.x
renovate/typescript-eslint-eslint-plugin-5.x
renovate/typescript-eslint-parser-5.x
richardshuai/karaoke
shahanneda-news-11jan2022
shahanneda/add-alt-tab-news
shahanneda/add-bot
shahanneda/add-code-party-1
shahanneda/add-code-party-23
shahanneda/add-event
shahanneda/add-events
shahanneda/add-myself
shahanneda/alt-tab-and-cp
shahanneda/fix-build-image-script
shahanneda/fix-name-parts
shahanneda/optimze-image-script
shahanneda/update-exec-blurbs
shahanneda/update-project-program
shahanneda/update-team
support-multiple-news-homepage
unix101-1
update-events
w23-update-team
warning-header
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
First Draft
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
a3thakra
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#11
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes