Constitution page #11

Closed
opened 2 years ago by a3thakra · 24 comments
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

#10 OrganizedContent Component

#10 OrganizedContent Component
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed the description

changed the description
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed the description

changed the description
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed title from Event{-Feat-} to Event{+Card+}

changed title from **Event{-Feat-}** to **Event{+Card+}**
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 1 commit

Compare with previous version

added 1 commit <ul><li>2887568d - Change CSS file name</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=55364&start_sha=2871e7ea88b5ff61f92b69add12d98182bf57a3f)
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed the description

changed the description
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 5 commits

  • 2887568d...8a9935ba - 2 commits from branch main
  • baf13af5 - Change css and props
  • 051fa143 - Merge branch 'main' into feat/event-card
  • 1449f987 - Add image tag

Compare with previous version

added 5 commits <ul><li>2887568d...8a9935ba - 2 commits from branch <code>main</code></li><li>baf13af5 - Change css and props</li><li>051fa143 - Merge branch &#39;main&#39; into feat/event-card</li><li>1449f987 - Add image tag</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=55916&start_sha=2887568d076bebc76cf9ef7cb1a6fdd35c29cb11)
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed the description

changed the description
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

Flexbox and width wouldn't work for some reason so I took some ideas from here: https://css-tricks.com/making-width-and-flexible-items-play-nice-together/

Flexbox and width wouldn't work for some reason so I took some ideas from here: https://css-tricks.com/making-width-and-flexible-items-play-nice-together/
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 2 commits

Compare with previous version

added 2 commits <ul><li>ed9724a3 - 1 commit from branch <code>main</code></li><li>9227656d - Fix merge conflicts</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=56122&start_sha=1449f987cd32f4047d54afcead4a00d37197523b)
j285he commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 1 commit

Compare with previous version

added 1 commit <ul><li>297b310e - ESLint</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=56123&start_sha=9227656dc80c3106db53a3a9905d8b2a14eeabe9)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

This should be an article

This should be an article
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

This should be a section.

This should be a section.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

you should not prefix css classes with eventCard because we're using css modules. It automatically does that for us.
image

you should not prefix css classes with `eventCard` because we're using css modules. It automatically does that for us. ![image](/uploads/98d409a14047a8acc1c2e54d2f8af90b/image.png)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

this is actually a purple 2 on figma

this is actually a purple 2 on figma
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

You shouldn't rely on this being a button. Use a class here instead. Look at how Button is implemented in !8.

You shouldn't rely on this being a button. Use a class here instead. Look at how Button is implemented in !8.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#1a5bce3caef7b87cdf5e4c73a60b5e23b4c57cd6_29_28)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#1a5bce3caef7b87cdf5e4c73a60b5e23b4c57cd6_37_36)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#e6d872e4d909fd4c233e90c32652c4446830d686_23_23)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#e6d872e4d909fd4c233e90c32652c4446830d686_33_31)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb#e6d872e4d909fd4c233e90c32652c4446830d686_19_19)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 1 commit

Compare with previous version

added 1 commit <ul><li>e2f02681 - Final fixes</li></ul> [Compare with previous version](/csc/website/-/merge_requests/11/diffs?diff_id=56200&start_sha=297b310e33660379e04e31c2f67dab40a4585bcb)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

approved this merge request

approved this merge request
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

I just pushed e2f02681 to address the comments above. (They were pretty minor comments, so I went ahead and committed them to your branch :) )

Great job on the event card btw!

I just pushed e2f02681 to address the comments above. (They were pretty minor comments, so I went ahead and committed them to your branch :) ) Great job on the event card btw!
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

enabled an automatic merge when the pipeline for e2f026811a succeeds

enabled an automatic merge when the pipeline for e2f026811aecf23c53e3d0a38edf58772e5be0e8 succeeds
a3thakra added this to the First Draft milestone 2 years ago
w25tran self-assigned this 2 years ago
w25tran added the
In Progress
label 2 years ago
w25tran was unassigned by a3thakra 2 years ago
a3thakra self-assigned this 2 years ago
a3thakra closed this issue 2 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#11
Loading…
There is no content yet.