Our Supporters page #12
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#12
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Content in mdx
We no longer have a donate page.
But we do have an "Our Supporters" page.
changed title from {-Donate-} page to {+Our Supporters+} page
changed the description
The goal here is to make sure that the entire page does not reload if I navigate to a new link from the sidebar. Doing something like this should let us do that. This also ties in with how pages are going to get structured, so it's totally fine if we have to work on this past our May 26 milestone. Let's pair together on this sometime if you need help.
This task is also a bit more open-ended than others so it would be totally fine to merge an MR for an incomplete implementation. I'll leave that decision up to you!
read all section should be auto-generated inside the component, not the playground.
does this work?
changed this line in version 2 of the diff
changed this line in version 2 of the diff
added 22 commits
main
ffbfdac7
- Apply prettier changes1a203f4f
- Add ReadAll functionality6099a0b3
- Merge branch 'main' into feat/organized-content7f33bbda
- Add selected markerfa1ad026
- Start mobile changes0bf1033c
- Refactor429a9ae9
- Refactor ReadAll content07a2909c
- Refactor99d20e85
- Remove unneccessary lineCompare with previous version
added 2 commits
1a784a99
- 1 commit from branchmain
d7257c72
- Merge branch 'main' into feat/organized-contentCompare with previous version
Ignored for now unless it becomes an issue
resolved all threads
changed this line in version 4 of the diff
added 3 commits
c9a8cc09
- Make Nav disappear on mobile5b398f83
- Fix styling for Link8bbe4d5b
- Add .mdx functionality to OrganizedContentCompare with previous version
added 2 commits
f3ad802b
- Refactor content given to OrganizedContentbe636c50
- Fix navLink widthCompare with previous version
marked this merge request as ready
requested review from @a3thakra
assigned to @w25tran
requested review from @n3parikh and removed review request for @a3thakra
requested review from @a3thakra and removed review request for @n3parikh
changed the description
Mobile version not finished yet
resolved all threads
changed this line in version 6 of the diff
added 1 commit
669646cd
- Apply 1 suggestion(s) to 1 file(s)Compare with previous version
resolved all threads
changed this line in version 7 of the diff
added 1 commit
35b0160f
- Apply 1 suggestion(s) to 1 file(s)Compare with previous version
changed this line in version 8 of the diff
resolved all threads
added 1 commit
552330ca
- Apply 1 suggestion(s) to 1 file(s)Compare with previous version
Is there a better way to do this?
(as in concatenating two styles together where one is conditional)
added 1 commit
0762d640
- Fix lint command to prevent errorCompare with previous version
Try https://github.com/JedWatson/classnames ?
assigned to @b38peng
Use
calc(24rem / 16);
insteadRead all should not be an mdx file, we should automatically generate this section inside the OrganizedContent component.
foo.organized-content.mdx
seems very verbose. What do you think aboutfoo.section.mdx
? (Since all mdx files are sections of a page, in some sense 🤷 )Read all currently is an mdx file with just the metadata: title and URL. The content associated is auto-generated in the OrganizedContent component. I figured it would be easier for an editor to change the link URL in an mdx than in the code.
Yeah, I figured we would want a shorter name. I'll change it to
section
especially since it will make more sense to other people who aren't familiar with the organized-content name.IMO title and URL can be auto-generated along with the content. The URL for read all can just be 'readall'
This should be replaced with
sections
, and same for the interface.changed this line in version 10 of the diff
changed this line in version 10 of the diff
changed this line in version 10 of the diff
added 1 commit
99acb0f4
- Autogenerate read all sectionCompare with previous version
added 1 commit
a25926b4
- Move organized content to the top of the playground to reduce weird scrolling effectCompare with previous version
added 1 commit
80d3d57c
- Fix some styling for the nav and footerCompare with previous version
added 1 commit
f94c61b7
- Content should have 100% widthCompare with previous version
changed this line in version 14 of the diff
added 1 commit
3bba1927
- Convert rems to calc(rem / 16)Compare with previous version
added 1 commit
f51ac015
- Cleanup some unneeded stylesCompare with previous version
changed this line in version 16 of the diff
added 1 commit
02184d2a
- *.organized-content.mdx -> *.section.mdxCompare with previous version
added 9 commits
main
d0437106
- Merge remote-tracking branch 'origin/main' into feat/organized-contentCompare with previous version
approved this merge request
enabled an automatic merge when the pipeline for
d0437106b8
succeedscanceled the automatic merge
enabled an automatic merge when the pipeline for
d0437106b8
succeedsmentioned in merge request !25