Our Supporters page #12

Closed
opened 2021-04-25 16:13:02 -04:00 by a3thakra · 65 comments
a3thakra commented 2021-04-25 16:13:02 -04:00 (Migrated from git.uwaterloo.ca)

Content in mdx

Content in mdx
a3thakra commented 2021-05-10 17:30:47 -04:00 (Migrated from git.uwaterloo.ca)

We no longer have a donate page.

We no longer have a donate page.
a3thakra commented 2021-05-10 17:32:14 -04:00 (Migrated from git.uwaterloo.ca)

But we do have an "Our Supporters" page.

But we do have an "Our Supporters" page.
a3thakra commented 2021-05-10 17:32:31 -04:00 (Migrated from git.uwaterloo.ca)

changed title from {-Donate-} page to {+Our Supporters+} page

changed title from **{-Donate-} page** to **{+Our Supporters+} page**
a3thakra commented 2021-05-10 17:32:31 -04:00 (Migrated from git.uwaterloo.ca)

changed the description

changed the description
a3thakra commented 2021-05-19 18:29:38 -04:00 (Migrated from git.uwaterloo.ca)

The goal here is to make sure that the entire page does not reload if I navigate to a new link from the sidebar. Doing something like this should let us do that. This also ties in with how pages are going to get structured, so it's totally fine if we have to work on this past our May 26 milestone. Let's pair together on this sometime if you need help.

This task is also a bit more open-ended than others so it would be totally fine to merge an MR for an incomplete implementation. I'll leave that decision up to you!

The goal here is to make sure that the entire page does not reload if I navigate to a new link from the sidebar. Doing something like [this](https://www.youtube.com/watch?v=69-mnojSa0M) should let us do that. This also ties in with how pages are going to get structured, so it's totally fine if we have to work on this past our May 26 milestone. Let's pair together on this sometime if you need help. This task is also a bit more open-ended than others so it would be totally fine to merge an MR for an incomplete implementation. I'll leave that decision up to you!
a3thakra commented 2021-05-19 18:30:54 -04:00 (Migrated from git.uwaterloo.ca)

read all section should be auto-generated inside the component, not the playground.

read all section should be auto-generated inside the component, not the playground.
a3thakra commented 2021-05-19 18:32:42 -04:00 (Migrated from git.uwaterloo.ca)
  children: ReactNode

does this work?

```suggestion:-0+0 children: ReactNode ``` does this work?
w25tran commented 2021-05-30 17:22:34 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=57444&start_sha=49b2fd6b2f1ba4df1e2e0477e7c48a9394d7f334#fdad91ab1fd02ff3277a1adf09ac35d8cbb07ef1_24_1)
w25tran commented 2021-05-30 17:22:35 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=57444&start_sha=49b2fd6b2f1ba4df1e2e0477e7c48a9394d7f334#fdad91ab1fd02ff3277a1adf09ac35d8cbb07ef1_5_1)
w25tran commented 2021-05-30 17:22:35 -04:00 (Migrated from git.uwaterloo.ca)

added 22 commits

Compare with previous version

added 22 commits <ul><li>49b2fd6b...4f5496ba - 13 commits from branch <code>main</code></li><li>ffbfdac7 - Apply prettier changes</li><li>1a203f4f - Add ReadAll functionality</li><li>6099a0b3 - Merge branch &#39;main&#39; into feat/organized-content</li><li>7f33bbda - Add selected marker</li><li>fa1ad026 - Start mobile changes</li><li>0bf1033c - Refactor</li><li>429a9ae9 - Refactor ReadAll content</li><li>07a2909c - Refactor</li><li>99d20e85 - Remove unneccessary line</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=57444&start_sha=49b2fd6b2f1ba4df1e2e0477e7c48a9394d7f334)
w25tran commented 2021-05-30 17:23:07 -04:00 (Migrated from git.uwaterloo.ca)

added 2 commits

  • 1a784a99 - 1 commit from branch main
  • d7257c72 - Merge branch 'main' into feat/organized-content

Compare with previous version

added 2 commits <ul><li>1a784a99 - 1 commit from branch <code>main</code></li><li>d7257c72 - Merge branch &#39;main&#39; into feat/organized-content</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=57445&start_sha=99d20e85ef932de322e9309067db8060ceff4730)
w25tran commented 2021-05-30 17:31:02 -04:00 (Migrated from git.uwaterloo.ca)

Ignored for now unless it becomes an issue

Ignored for now unless it becomes an issue
w25tran commented 2021-05-30 17:31:16 -04:00 (Migrated from git.uwaterloo.ca)

resolved all threads

resolved all threads
w25tran commented 2021-05-31 02:26:51 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=57480&start_sha=d7257c722314ebdd61fb1230e0b81442ae585db6#52702b5631fd7b0022e0a2179e9b14b1fa4dd61b_199_166)
w25tran commented 2021-05-31 02:26:51 -04:00 (Migrated from git.uwaterloo.ca)

added 3 commits

  • c9a8cc09 - Make Nav disappear on mobile
  • 5b398f83 - Fix styling for Link
  • 8bbe4d5b - Add .mdx functionality to OrganizedContent

Compare with previous version

added 3 commits <ul><li>c9a8cc09 - Make Nav disappear on mobile</li><li>5b398f83 - Fix styling for Link</li><li>8bbe4d5b - Add .mdx functionality to OrganizedContent</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=57480&start_sha=d7257c722314ebdd61fb1230e0b81442ae585db6)
w25tran commented 2021-05-31 02:45:47 -04:00 (Migrated from git.uwaterloo.ca)

added 2 commits

  • f3ad802b - Refactor content given to OrganizedContent
  • be636c50 - Fix navLink width

Compare with previous version

added 2 commits <ul><li>f3ad802b - Refactor content given to OrganizedContent</li><li>be636c50 - Fix navLink width</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=57482&start_sha=8bbe4d5bec8c5a34091856df7ee15c01ca36a287)
w25tran commented 2021-05-31 02:46:37 -04:00 (Migrated from git.uwaterloo.ca)

marked this merge request as ready

marked this merge request as **ready**
w25tran commented 2021-05-31 02:48:50 -04:00 (Migrated from git.uwaterloo.ca)

requested review from @a3thakra

requested review from @a3thakra
w25tran commented 2021-05-31 02:49:14 -04:00 (Migrated from git.uwaterloo.ca)

assigned to @w25tran

assigned to @w25tran
w25tran commented 2021-05-31 02:52:28 -04:00 (Migrated from git.uwaterloo.ca)

requested review from @n3parikh and removed review request for @a3thakra

requested review from @n3parikh and removed review request for @a3thakra
w25tran commented 2021-05-31 02:52:36 -04:00 (Migrated from git.uwaterloo.ca)

requested review from @a3thakra and removed review request for @n3parikh

requested review from @a3thakra and removed review request for @n3parikh
w25tran commented 2021-05-31 02:54:59 -04:00 (Migrated from git.uwaterloo.ca)

changed the description

changed the description
w25tran commented 2021-05-31 02:56:08 -04:00 (Migrated from git.uwaterloo.ca)

Mobile version not finished yet

Mobile version not finished yet
w25tran commented 2021-05-31 02:59:31 -04:00 (Migrated from git.uwaterloo.ca)
  --blue-1-05: #5caff90d;
```suggestion:-0+0 --blue-1-05: #5caff90d; ```
w25tran commented 2021-05-31 02:59:38 -04:00 (Migrated from git.uwaterloo.ca)

resolved all threads

resolved all threads
w25tran commented 2021-05-31 02:59:39 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=57485&start_sha=be636c508506808ca9ae68781a28b0940c3a4b0d#b3b7e663d0ebdc4a99fe28cb4c3051eb195ddcab_12_12)
w25tran commented 2021-05-31 02:59:39 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • 669646cd - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>669646cd - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=57485&start_sha=be636c508506808ca9ae68781a28b0940c3a4b0d)
w25tran commented 2021-05-31 02:59:59 -04:00 (Migrated from git.uwaterloo.ca)
  --blue-1-05: #5caff90d;
```suggestion:-0+0 --blue-1-05: #5caff90d; ```
w25tran commented 2021-05-31 03:00:03 -04:00 (Migrated from git.uwaterloo.ca)

resolved all threads

resolved all threads
w25tran commented 2021-05-31 03:00:04 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=57486&start_sha=669646cdba2a57f8487ddd695a412e695eea37e4#b3b7e663d0ebdc4a99fe28cb4c3051eb195ddcab_31_31)
w25tran commented 2021-05-31 03:00:04 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • 35b0160f - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>35b0160f - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=57486&start_sha=669646cdba2a57f8487ddd695a412e695eea37e4)
w25tran commented 2021-05-31 03:02:47 -04:00 (Migrated from git.uwaterloo.ca)
  width: 100%,
```suggestion:-0+0 width: 100%, ```
w25tran commented 2021-05-31 03:02:54 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=57488&start_sha=35b0160f6295bd922d8a72e726ac8e41d010059d#da68dbaa53c381abf1020f2300783bd7729547e0_40_1)
w25tran commented 2021-05-31 03:02:54 -04:00 (Migrated from git.uwaterloo.ca)

resolved all threads

resolved all threads
w25tran commented 2021-05-31 03:02:55 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • 552330ca - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>552330ca - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=57488&start_sha=35b0160f6295bd922d8a72e726ac8e41d010059d)
w25tran commented 2021-05-31 03:05:20 -04:00 (Migrated from git.uwaterloo.ca)

Is there a better way to do this?

Is there a better way to do this?
w25tran commented 2021-05-31 03:07:00 -04:00 (Migrated from git.uwaterloo.ca)

(as in concatenating two styles together where one is conditional)

(as in concatenating two styles together where one is conditional)
w25tran commented 2021-05-31 21:15:47 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • 0762d640 - Fix lint command to prevent error

Compare with previous version

added 1 commit <ul><li>0762d640 - Fix lint command to prevent error</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=57598&start_sha=552330ca9b0d1faae0876fe2a52d04c6e2e30d16)
n3parikh commented 2021-05-31 21:20:21 -04:00 (Migrated from git.uwaterloo.ca)
Try https://github.com/JedWatson/classnames ?
b38peng commented 2021-06-02 22:21:08 -04:00 (Migrated from git.uwaterloo.ca)

assigned to @b38peng

assigned to @b38peng
a3thakra commented 2021-06-06 19:39:57 -04:00 (Migrated from git.uwaterloo.ca)

Use calc(24rem / 16); instead

Use `calc(24rem / 16);` instead
a3thakra commented 2021-06-06 19:44:45 -04:00 (Migrated from git.uwaterloo.ca)

Read all should not be an mdx file, we should automatically generate this section inside the OrganizedContent component.

Read all should not be an mdx file, we should automatically generate this section inside the OrganizedContent component.
a3thakra commented 2021-06-06 19:48:33 -04:00 (Migrated from git.uwaterloo.ca)

foo.organized-content.mdx seems very verbose. What do you think about foo.section.mdx? (Since all mdx files are sections of a page, in some sense 🤷 )

`foo.organized-content.mdx` seems very verbose. What do you think about `foo.section.mdx`? (Since all mdx files are sections of a page, in some sense :shrug: )
w25tran commented 2021-06-06 20:05:09 -04:00 (Migrated from git.uwaterloo.ca)

Read all currently is an mdx file with just the metadata: title and URL. The content associated is auto-generated in the OrganizedContent component. I figured it would be easier for an editor to change the link URL in an mdx than in the code.

Read all currently is an mdx file with just the metadata: title and URL. The content associated is auto-generated in the OrganizedContent component. I figured it would be easier for an editor to change the link URL in an mdx than in the code.
w25tran commented 2021-06-06 20:13:49 -04:00 (Migrated from git.uwaterloo.ca)

Yeah, I figured we would want a shorter name. I'll change it to section especially since it will make more sense to other people who aren't familiar with the organized-content name.

Yeah, I figured we would want a shorter name. I'll change it to `section` especially since it will make more sense to other people who aren't familiar with the organized-content name.
a3thakra commented 2021-06-07 16:54:55 -04:00 (Migrated from git.uwaterloo.ca)

IMO title and URL can be auto-generated along with the content. The URL for read all can just be 'readall'

IMO title and URL can be auto-generated along with the content. The URL for read all can just be 'readall'
a3thakra commented 2021-06-07 17:33:03 -04:00 (Migrated from git.uwaterloo.ca)

This should be replaced with sections, and same for the interface.

This should be replaced with `sections`, and same for the interface.
a3thakra commented 2021-06-09 04:47:18 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=58873&start_sha=0762d640c373326ca715666ade9830bc427a83ea#fdad91ab1fd02ff3277a1adf09ac35d8cbb07ef1_84_78)
a3thakra commented 2021-06-09 04:47:18 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=58873&start_sha=0762d640c373326ca715666ade9830bc427a83ea#52702b5631fd7b0022e0a2179e9b14b1fa4dd61b_16_14)
a3thakra commented 2021-06-09 04:47:19 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=58873&start_sha=0762d640c373326ca715666ade9830bc427a83ea#fdad91ab1fd02ff3277a1adf09ac35d8cbb07ef1_32_31)
a3thakra commented 2021-06-09 04:47:19 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • 99acb0f4 - Autogenerate read all section

Compare with previous version

added 1 commit <ul><li>99acb0f4 - Autogenerate read all section</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=58873&start_sha=0762d640c373326ca715666ade9830bc427a83ea)
a3thakra commented 2021-06-09 04:49:08 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • a25926b4 - Move organized content to the top of the playground to reduce weird scrolling effect

Compare with previous version

added 1 commit <ul><li>a25926b4 - Move organized content to the top of the playground to reduce weird scrolling effect</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=58874&start_sha=99acb0f4702b36817b5960a712cb046990d78e15)
a3thakra commented 2021-06-09 06:28:42 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • 80d3d57c - Fix some styling for the nav and footer

Compare with previous version

added 1 commit <ul><li>80d3d57c - Fix some styling for the nav and footer</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=58875&start_sha=a25926b4f6d247887d0f5a07677d6a167924c843)
a3thakra commented 2021-06-09 06:30:50 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • f94c61b7 - Content should have 100% width

Compare with previous version

added 1 commit <ul><li>f94c61b7 - Content should have 100% width</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=58876&start_sha=80d3d57c76c4f1b597bd863672b27a0189478fc1)
a3thakra commented 2021-06-09 20:50:41 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=59000&start_sha=f94c61b7fb9cbcac596db224a20b706427507e2b#da68dbaa53c381abf1020f2300783bd7729547e0_7_7)
a3thakra commented 2021-06-09 20:50:41 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • 3bba1927 - Convert rems to calc(rem / 16)

Compare with previous version

added 1 commit <ul><li>3bba1927 - Convert rems to calc(rem / 16)</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=59000&start_sha=f94c61b7fb9cbcac596db224a20b706427507e2b)
a3thakra commented 2021-06-09 20:59:09 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

Compare with previous version

added 1 commit <ul><li>f51ac015 - Cleanup some unneeded styles</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=59002&start_sha=3bba19271f1c6e75fc6843262265902644b8b596)
a3thakra commented 2021-06-09 21:05:56 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/csc/website/-/merge_requests/12/diffs?diff_id=59004&start_sha=f51ac015501c624a789b26bcb8fcb8bbe1a36660#7948598afd6f2aa542f1b55d7b6f077a70937e77_52_52)
a3thakra commented 2021-06-09 21:05:57 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

  • 02184d2a - *.organized-content.mdx -> *.section.mdx

Compare with previous version

added 1 commit <ul><li>02184d2a - *.organized-content.mdx -&gt; *.section.mdx</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=59004&start_sha=f51ac015501c624a789b26bcb8fcb8bbe1a36660)
a3thakra commented 2021-06-09 21:08:54 -04:00 (Migrated from git.uwaterloo.ca)

added 9 commits

  • 02184d2a...2594a72f - 8 commits from branch main
  • d0437106 - Merge remote-tracking branch 'origin/main' into feat/organized-content

Compare with previous version

added 9 commits <ul><li>02184d2a...2594a72f - 8 commits from branch <code>main</code></li><li>d0437106 - Merge remote-tracking branch &#39;origin/main&#39; into feat/organized-content</li></ul> [Compare with previous version](/csc/website/-/merge_requests/12/diffs?diff_id=59005&start_sha=02184d2a3be8db84c687b2696b28ff7dbda19a4c)
a3thakra commented 2021-06-09 21:09:49 -04:00 (Migrated from git.uwaterloo.ca)

approved this merge request

approved this merge request
a3thakra commented 2021-06-09 21:09:51 -04:00 (Migrated from git.uwaterloo.ca)

enabled an automatic merge when the pipeline for d0437106b8 succeeds

enabled an automatic merge when the pipeline for d0437106b81a631cb39f954b64a1ca1154b67466 succeeds
a3thakra commented 2021-06-09 21:09:54 -04:00 (Migrated from git.uwaterloo.ca)

canceled the automatic merge

canceled the automatic merge
a3thakra commented 2021-06-09 21:09:56 -04:00 (Migrated from git.uwaterloo.ca)

enabled an automatic merge when the pipeline for d0437106b8 succeeds

enabled an automatic merge when the pipeline for d0437106b81a631cb39f954b64a1ca1154b67466 succeeds
b38peng commented 2021-06-13 17:33:47 -04:00 (Migrated from git.uwaterloo.ca)

mentioned in merge request !25

mentioned in merge request !25
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#12
No description provided.