Get involved page #13
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
Dependencies
No dependencies set.
Reference: www/www-new#13
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Use the links component from the footer #3
added 4 commits
8a9935ba
- 1 commit from branchmain
88b0522e
- Add TeamMemberCard basic layout and stylinge13738d5
- Add responsive stylinga2eff431
- Merge branch 'feat/team-member-card' of https://git.uwaterloo.ca/csc/website...Compare with previous version
what are these numbers?
ah these are calculating the height of each row! i don't think we need these, since line-height / font-size are set by the name and role elements.
Images from next/image are not compatible with
next export
which we'll be using. #26 Let's use theImage
component till then.Let's comment these out and fix them in another MR when mobile styles are finalized.
This is much more concise :)
we can put this content in
codey.team-member.mdx
, just like events and news.If the outer div is an
article
, then we can use h1 and h2 over here, otherwise, we should stick to divs.We should not wrap children with a
p
tag.changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
added 8 commits
main
22547eac
- Merge remote-tracking branch 'origin/main' into feat/team-member-card4c20de40
- Address commentsCompare with previous version
Great work @a258wang! I'm really impressed by how you're structuring your CSS! ❤️ And I love the way you leveraged grid layout here. You should talk about it during the sitdown.
I added some comments and addressed them too haha (just want to merge this in) None of the comments are big changes, so lmk if any of the changes I made / comments I added are unclear.
approved this merge request
assigned to @dora
mentioned in merge request !33