www
/
www-new
12
2
Fork 3
Code Issues 56 Pull Requests 29 Projects Releases Wiki Activity
Labels Milestones
New Issue

Get involved page #13

Closed
opened 2 years ago by a3thakra · 18 comments
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

Use the links component from the footer #3

Use the links component from the footer #3
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 4 commits

Compare with previous version

added 4 commits <ul><li>8a9935ba - 1 commit from branch <code>main</code></li><li>88b0522e - Add TeamMemberCard basic layout and styling</li><li>e13738d5 - Add responsive styling</li><li>a2eff431 - Merge branch &#39;feat/team-member-card&#39; of https://git.uwaterloo.ca/csc/website...</li></ul> [Compare with previous version](/csc/website/-/merge_requests/13/diffs?diff_id=55781&start_sha=21787af95b6695f2a904734ea3b376859dd834a3)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

what are these numbers?

what are these numbers?
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

ah these are calculating the height of each row! i don't think we need these, since line-height / font-size are set by the name and role elements.

ah these are calculating the height of each row! i don't think we need these, since line-height / font-size are set by the name and role elements.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

Images from next/image are not compatible with next export which we'll be using. #26 Let's use the Image component till then.

Images from next/image are not compatible with `next export` which we'll be using. #26 Let's use the `Image` component till then.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

Let's comment these out and fix them in another MR when mobile styles are finalized.

Let's comment these out and fix them in another MR when mobile styles are finalized.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator 
          src={props.image ?? "/images/team-member-placeholder.svg"}

This is much more concise :)

```suggestion:-4+0 src={props.image ?? "/images/team-member-placeholder.svg"} ``` This is much more concise :)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

we can put this content in codey.team-member.mdx, just like events and news.

we can put this content in `codey.team-member.mdx`, just like events and news.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

If the outer div is an article, then we can use h1 and h2 over here, otherwise, we should stick to divs.

If the outer div is an `article`, then we can use h1 and h2 over here, otherwise, we should stick to divs.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

We should not wrap children with a p tag.

image

We should not wrap children with a `p` tag. ![image](/uploads/15b878f14295dd1215d6459d916036c6/image.png)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707#52e82fdddbffb958a479a91e0cd5075e494aedff_4_4)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707#55331788b49301a67c9dc31fe7ee607650007917_21_17)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707#95888c41a4565e17cc446aebdb2c6bdc52c67ba7_46_63)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707#55331788b49301a67c9dc31fe7ee607650007917_30_24)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 8 commits

  • a2eff431...7f88950f - 6 commits from branch main
  • 22547eac - Merge remote-tracking branch 'origin/main' into feat/team-member-card
  • 4c20de40 - Address comments

Compare with previous version

added 8 commits <ul><li>a2eff431...7f88950f - 6 commits from branch <code>main</code></li><li>22547eac - Merge remote-tracking branch &#39;origin/main&#39; into feat/team-member-card</li><li>4c20de40 - Address comments</li></ul> [Compare with previous version](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

Great work @a258wang! I'm really impressed by how you're structuring your CSS! ❤️ And I love the way you leveraged grid layout here. You should talk about it during the sitdown.

I added some comments and addressed them too haha (just want to merge this in) None of the comments are big changes, so lmk if any of the changes I made / comments I added are unclear.

Great work @a258wang! I'm really impressed by how you're structuring your CSS! :heart: And I love the way you leveraged grid layout here. You should talk about it during the sitdown. I added some comments and addressed them too haha (just want to merge this in) None of the comments are big changes, so lmk if any of the [changes](4c20de40) I made / comments I added are unclear.
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

approved this merge request

approved this merge request
dora commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

assigned to @dora

assigned to @dora
dora commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

mentioned in merge request !33

mentioned in merge request !33
d43su self-assigned this 2 years ago
d43su added the due date 2021-07-04 2 years ago
a3thakra added this to the First Draft milestone 2 years ago
a3thakra closed this issue 2 years ago
a3thakra referenced this issue from a commit 2 years ago
Get Involved Page! (#76)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
2022-07-08-MUA-Update
April-Code-Party
a258wang-events-2022-09-28
add-name-to-web-committe
amy-add-alt-tab-f22
amy-add-librarian-f22
amy-events-august-2022
amy-events-karaoke
amy-fix-vp-f22
amy-image-optimization-quick-fix-experiment
amy-news-2022-09-14
amy-random-shapes
amy-update-annie-headshot-f22
amy-update-community-reps
amy-update-internship-repo-f22
annies/add-circles-event
anniesun/add-myself-to-webstite
anniesun/update-blurbs
b72zhou-past-exec
bonnie-team-member-card
darren/add-class-profile-news
darren/add-myself-to-website
darren/add-news
darren/fix-dead-link
fix-oc-burger
j285he-add-news-09-07
j285he-ldap-test-example
jan-2023-constitution-changes
ldap-exec-test
main
neil-members
news-2022-09-08
news-2022-09-10
renovate/date-fns-tz-2.x
renovate/eslint-8.x
renovate/eslint-plugin-prettier-4.x
renovate/eslint-plugin-react-7.x
renovate/fs-extra-11.x
renovate/ldapts-4.x
renovate/mdx-js-loader-2.x
renovate/mdx-js-react-2.x
renovate/next-11.x
renovate/next-13.x
renovate/next-mdx-11.x
renovate/next-mdx-13.x
renovate/next-mdx-remote-3.x
renovate/node-18.x
renovate/node-19.x
renovate/npm-9.x
renovate/postcss-preset-env-8.x
renovate/react-18.x
renovate/react-dom-18.x
renovate/remark-14.x
renovate/remark-html-15.x
renovate/squoosh-lib-0.x
renovate/typescript-4.x
renovate/typescript-5.x
renovate/typescript-eslint-eslint-plugin-5.x
renovate/typescript-eslint-parser-5.x
richardshuai/karaoke
shahanneda-news-11jan2022
shahanneda/add-alt-tab-news
shahanneda/add-bot
shahanneda/add-code-party-1
shahanneda/add-code-party-23
shahanneda/add-event
shahanneda/add-events
shahanneda/add-myself
shahanneda/alt-tab-and-cp
shahanneda/fix-build-image-script
shahanneda/fix-name-parts
shahanneda/optimze-image-script
shahanneda/update-exec-blurbs
shahanneda/update-project-program
shahanneda/update-team
support-multiple-news-homepage
unix101-1
update-events
w23-update-team
warning-header
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
First Draft
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
d43su
1 Participants
Notifications
Due Date

2021-07-04

Dependencies

No dependencies set.

Reference: www/www-new#13
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes