Get involved page #13

New Issue

d43su · 2021-04-25T16:13:54-04:00

a3thakra commented

2021-04-25 16:13:54 -04:00

(Migrated from git.uwaterloo.ca)

Use the links component from the footer #3

a258wang commented

2021-05-21 14:01:18 -04:00

(Migrated from git.uwaterloo.ca)

added 4 commits

8a9935ba - 1 commit from branch main
88b0522e - Add TeamMemberCard basic layout and styling
e13738d5 - Add responsive styling
a2eff431 - Merge branch 'feat/team-member-card' of https://git.uwaterloo.ca/csc/website...

Compare with previous version

added 4 commits <ul><li>8a9935ba - 1 commit from branch <code>main</code></li><li>88b0522e - Add TeamMemberCard basic layout and styling</li><li>e13738d5 - Add responsive styling</li><li>a2eff431 - Merge branch 'feat/team-member-card' of https://git.uwaterloo.ca/csc/website...</li></ul> [Compare with previous version](/csc/website/-/merge_requests/13/diffs?diff_id=55781&start_sha=21787af95b6695f2a904734ea3b376859dd834a3)

a3thakra commented

2021-05-24 04:09:40 -04:00

(Migrated from git.uwaterloo.ca)

what are these numbers?

a3thakra commented

2021-05-24 04:30:30 -04:00

(Migrated from git.uwaterloo.ca)

ah these are calculating the height of each row! i don't think we need these, since line-height / font-size are set by the name and role elements.

a3thakra commented

2021-05-24 04:36:47 -04:00

(Migrated from git.uwaterloo.ca)

Images from next/image are not compatible with next export which we'll be using. #26 Let's use the Image component till then.

Images from next/image are not compatible with `next export` which we'll be using. #26 Let's use the `Image` component till then.

a3thakra commented

2021-05-24 04:42:23 -04:00

(Migrated from git.uwaterloo.ca)

Let's comment these out and fix them in another MR when mobile styles are finalized.

a3thakra commented

2021-05-24 04:46:45 -04:00

(Migrated from git.uwaterloo.ca)

          src={props.image ?? "/images/team-member-placeholder.svg"}

This is much more concise :)

```suggestion:-4+0 src={props.image ?? "/images/team-member-placeholder.svg"} ``` This is much more concise :)

a3thakra commented

2021-05-24 04:51:31 -04:00

(Migrated from git.uwaterloo.ca)

we can put this content in codey.team-member.mdx, just like events and news.

we can put this content in `codey.team-member.mdx`, just like events and news.

a3thakra commented

2021-05-24 05:05:01 -04:00

(Migrated from git.uwaterloo.ca)

If the outer div is an article, then we can use h1 and h2 over here, otherwise, we should stick to divs.

If the outer div is an `article`, then we can use h1 and h2 over here, otherwise, we should stick to divs.

a3thakra commented

2021-05-24 05:10:10 -04:00

(Migrated from git.uwaterloo.ca)

We should not wrap children with a p tag.

We should not wrap children with a `p` tag. ![image](/uploads/15b878f14295dd1215d6459d916036c6/image.png)

a3thakra commented

2021-05-24 05:16:17 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707#52e82fdddbffb958a479a91e0cd5075e494aedff_4_4)

a3thakra commented

2021-05-24 05:16:17 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707#55331788b49301a67c9dc31fe7ee607650007917_21_17)

a3thakra commented

2021-05-24 05:16:17 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707#95888c41a4565e17cc446aebdb2c6bdc52c67ba7_46_63)

a3thakra commented

2021-05-24 05:16:17 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707#55331788b49301a67c9dc31fe7ee607650007917_30_24)

a3thakra commented

2021-05-24 05:16:17 -04:00

(Migrated from git.uwaterloo.ca)

added 8 commits

a2eff431...7f88950f - 6 commits from branch main
22547eac - Merge remote-tracking branch 'origin/main' into feat/team-member-card
4c20de40 - Address comments

Compare with previous version

added 8 commits <ul><li>a2eff431...7f88950f - 6 commits from branch <code>main</code></li><li>22547eac - Merge remote-tracking branch 'origin/main' into feat/team-member-card</li><li>4c20de40 - Address comments</li></ul> [Compare with previous version](/csc/website/-/merge_requests/13/diffs?diff_id=56207&start_sha=a2eff431d5d88fb90f15f7fd5fbb880d70031707)

a3thakra commented

2021-05-24 05:21:01 -04:00

(Migrated from git.uwaterloo.ca)

Great work @a258wang! I'm really impressed by how you're structuring your CSS! ❤️ And I love the way you leveraged grid layout here. You should talk about it during the sitdown.

I added some comments and addressed them too haha (just want to merge this in) None of the comments are big changes, so lmk if any of the changes I made / comments I added are unclear.

Great work @a258wang! I'm really impressed by how you're structuring your CSS! :heart: And I love the way you leveraged grid layout here. You should talk about it during the sitdown. I added some comments and addressed them too haha (just want to merge this in) None of the comments are big changes, so lmk if any of the [changes](4c20de40) I made / comments I added are unclear.

a3thakra commented

2021-05-24 05:21:23 -04:00

(Migrated from git.uwaterloo.ca)

approved this merge request

dora commented

2021-06-14 20:15:25 -04:00

(Migrated from git.uwaterloo.ca)

assigned to @dora

dora commented

2021-06-27 05:25:51 -04:00

(Migrated from git.uwaterloo.ca)

mentioned in merge request !33