Resources page #17

New Issue

d43su · 2021-04-25T16:17:07-04:00

a3thakra commented

2021-04-25 16:17:07 -04:00

(Migrated from git.uwaterloo.ca)

#10 OrganizedContent component

dora commented

2021-05-24 20:27:41 -04:00

(Migrated from git.uwaterloo.ca)

unassigned @dora

dora commented

2021-05-24 20:28:42 -04:00

(Migrated from git.uwaterloo.ca)

changed the description

a3thakra commented

2021-05-24 21:23:44 -04:00

(Migrated from git.uwaterloo.ca)

changed the description

a3thakra commented

2021-05-24 21:24:50 -04:00

(Migrated from git.uwaterloo.ca)

changed the description

a3thakra commented

2021-05-24 21:35:54 -04:00

(Migrated from git.uwaterloo.ca)

    props.route.includes("http://") || props.route.includes("https://");

```suggestion:-0+0 props.route.includes("http://") || props.route.includes("https://"); ```

a258wang commented

2021-05-24 23:23:53 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/17/diffs?diff_id=56405&start_sha=dd2a2814e49c60b64fc28093a83d18f8a9442134#a578c7e8c33c7f24400807e00a74617aec18284b_74_74)

a258wang commented

2021-05-24 23:23:53 -04:00

(Migrated from git.uwaterloo.ca)

resolved all threads

a258wang commented

2021-05-24 23:23:54 -04:00

(Migrated from git.uwaterloo.ca)

added 1 commit

1e1ddd19 - Fix https vs. http typo

Compare with previous version

added 1 commit <ul><li>1e1ddd19 - Fix https vs. http typo</li></ul> [Compare with previous version](/csc/website/-/merge_requests/17/diffs?diff_id=56405&start_sha=dd2a2814e49c60b64fc28093a83d18f8a9442134)

a258wang commented

2021-05-24 23:30:17 -04:00

(Migrated from git.uwaterloo.ca)

added 12 commits

1e1ddd19...4f5496ba - 8 commits from branch main
37657ae6 - Add submenu for resources
6f3b5f2c - mdx files for services/techtalks
be4ff8af - fix blur thing for external link
e007dc1d - Fix https vs. http typo

Compare with previous version

added 12 commits <ul><li>1e1ddd19...4f5496ba - 8 commits from branch <code>main</code></li><li>37657ae6 - Add submenu for resources</li><li>6f3b5f2c - mdx files for services/techtalks</li><li>be4ff8af - fix blur thing for external link</li><li>e007dc1d - Fix https vs. http typo</li></ul> [Compare with previous version](/csc/website/-/merge_requests/17/diffs?diff_id=56408&start_sha=1e1ddd1935d9d42e38b6cfaa9198e5beb59dbc79)

a258wang commented

2021-05-24 23:37:25 -04:00

(Migrated from git.uwaterloo.ca)

Everything looks good! Just one question: do we still need a standalone /resources route, with its own page (currently resources.mdx in the pages directory)? There isn't a design in Figma for such a page... Should we change it so that clicking on the word "Resources" in the navbar simply goes the route /resources/services?

Everything looks good! Just one question: do we still need a standalone `/resources` route, with its own page (currently `resources.mdx` in the pages directory)? There isn't a design in Figma for such a page... Should we change it so that clicking on the word "Resources" in the navbar simply goes the route `/resources/services`?

dora commented

2021-05-25 03:59:17 -04:00

(Migrated from git.uwaterloo.ca)

assigned to @dora

dora commented

2021-05-25 04:00:05 -04:00

(Migrated from git.uwaterloo.ca)

Good point! I think it'd be fine to lead them to the services page. Gonna fix that rn :)

dora commented

2021-05-25 04:05:58 -04:00

(Migrated from git.uwaterloo.ca)

added 4 commits

0843f4a3 - Add submenu for resources
98bfbe37 - mdx files for services/techtalks
dd2a2814 - fix blur thing for external link
3a1ca51d - merge conflict????? im so confused

Compare with previous version

added 4 commits <ul><li>0843f4a3 - Add submenu for resources</li><li>98bfbe37 - mdx files for services/techtalks</li><li>dd2a2814 - fix blur thing for external link</li><li>3a1ca51d - merge conflict????? im so confused</li></ul> [Compare with previous version](/csc/website/-/merge_requests/17/diffs?diff_id=56424&start_sha=e007dc1d247e6631a37e1ec13edf62dc64ce490b)

dora commented

2021-05-25 04:07:22 -04:00

(Migrated from git.uwaterloo.ca)

added 1 commit

7b9742f1 - Remove resources page

Compare with previous version

added 1 commit <ul><li>7b9742f1 - Remove resources page</li></ul> [Compare with previous version](/csc/website/-/merge_requests/17/diffs?diff_id=56425&start_sha=3a1ca51d0bc9eb0fac37af259940211201bcb684)

a258wang commented

2021-05-25 12:03:52 -04:00

(Migrated from git.uwaterloo.ca)

approved this merge request

a258wang commented

2021-05-25 12:04:31 -04:00

(Migrated from git.uwaterloo.ca)

resolved all threads

dora commented

2021-05-26 04:17:03 -04:00

(Migrated from git.uwaterloo.ca)

approved this merge request