Button #18

Closed
opened 2021-04-25 16:17:21 -04:00 by a3thakra · 16 comments
a3thakra commented 2021-04-25 16:17:21 -04:00 (Migrated from git.uwaterloo.ca)
No description provided.
a3thakra commented 2021-04-25 17:45:46 -04:00 (Migrated from git.uwaterloo.ca)

added 1 design

added [1 design](/csc/website/-/issues/18/designs?version=141)
b38peng commented 2021-05-10 21:57:00 -04:00 (Migrated from git.uwaterloo.ca)

assigned to @b38peng

assigned to @b38peng
b38peng commented 2021-05-28 23:46:12 -04:00 (Migrated from git.uwaterloo.ca)

mentioned in merge request !18

mentioned in merge request !18
b38peng commented 2021-05-28 23:46:12 -04:00 (Migrated from git.uwaterloo.ca)

changed the description

changed the description
a3thakra commented 2021-05-29 19:58:49 -04:00 (Migrated from git.uwaterloo.ca)

this should be in button.module.css

this should be in button.module.css
b38peng commented 2021-05-29 20:17:44 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/18/diffs?diff_id=57376&start_sha=d80ef92cc7143e7a1306a4b8ca82dc005ca0f1d8#b3b7e663d0ebdc4a99fe28cb4c3051eb195ddcab_2_1)
b38peng commented 2021-05-29 20:17:45 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

Compare with previous version

added 1 commit <ul><li>1dacf937 - button font fix</li></ul> [Compare with previous version](/csc/website/-/merge_requests/18/diffs?diff_id=57376&start_sha=d80ef92cc7143e7a1306a4b8ca82dc005ca0f1d8)
b38peng commented 2021-05-29 20:18:16 -04:00 (Migrated from git.uwaterloo.ca)

resolved all threads

resolved all threads
a3thakra commented 2021-05-29 20:24:58 -04:00 (Migrated from git.uwaterloo.ca)

why do you need a transition-duration?

why do you need a transition-duration?
a3thakra commented 2021-05-29 20:32:07 -04:00 (Migrated from git.uwaterloo.ca)

You shouldn't spread props directly image

You shouldn't spread props directly ![image](/uploads/01097af8f1595e9625c5e60efc1f1d18/image.png)
b38peng commented 2021-05-29 20:35:32 -04:00 (Migrated from git.uwaterloo.ca)

changed the description

changed the description
b38peng commented 2021-05-30 13:19:17 -04:00 (Migrated from git.uwaterloo.ca)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/18/diffs?diff_id=57409&start_sha=1dacf937952b87ae86044ee6667a2502ec8c6ae0#967fc9ef7730390fdef26e25dd6e72c3d5b28065_24_15)
b38peng commented 2021-05-30 13:19:17 -04:00 (Migrated from git.uwaterloo.ca)

added 1 commit

Compare with previous version

added 1 commit <ul><li>6cbf46a6 - fixed prop warnings</li></ul> [Compare with previous version](/csc/website/-/merge_requests/18/diffs?diff_id=57409&start_sha=1dacf937952b87ae86044ee6667a2502ec8c6ae0)
b38peng commented 2021-05-30 13:19:32 -04:00 (Migrated from git.uwaterloo.ca)

resolved all threads

resolved all threads
a3thakra commented 2021-06-01 00:44:45 -04:00 (Migrated from git.uwaterloo.ca)
  const btnSize = props.size ?? "normal";
```suggestion:-0+0 const btnSize = props.size ?? "normal"; ```
a3thakra commented 2021-06-01 00:45:53 -04:00 (Migrated from git.uwaterloo.ca)

approved this merge request

approved this merge request
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#18
No description provided.