Navbar highlighting does not work with Organized Content sections #181

New Issue

a258wang · 2021-08-25T19:36:59-04:00

a258wang commented

2021-08-25 19:36:59 -04:00

The navbar entries for pages that use the Organized Content are not blue when viewing only a section of the content. (The highlighting works fine when viewing "Read All.")

The navbar entries for pages that use the Organized Content are not blue when viewing only a section of the content. (The highlighting works fine when viewing "Read All.") ![image](/attachments/b61f9d66-7a6c-43bd-95b8-c2446d617f57)

image.png

193 KiB

image.png

170 KiB

a258wang added this to the Pre launch milestone 2021-08-25 19:37:11 -04:00

n3parikh commented

2021-08-26 00:07:24 -04:00

I think this is happening because of this code:

  const isCurrentPage =
    router.pathname === props.route ||
    (props.submenu != null &&
      router.pathname.startsWith(getMainRoute(props.route)));

In the organized content component, when you navigate to a section, we add the section slug to the route, so the router.pathname === props.route check will return false.

I think this is happening because of this code: ``` const isCurrentPage = router.pathname === props.route || (props.submenu != null && router.pathname.startsWith(getMainRoute(props.route))); ``` In the organized content component, when you navigate to a section, we add the section slug to the route, so the `router.pathname === props.route` check will return false.

a258wang referenced a pull request that will close this issue

2021-08-26 16:26:20 -04:00

Fix navbar highlight for Organized Content sections #182

a258wang was assigned by a3thakra

2021-08-26 22:38:16 -04:00

a3thakra added the

In Progress

label 2021-08-26 22:38:25 -04:00

a3thakra added the

Bug

label 2021-08-30 00:27:21 -04:00

a258wang closed this issue