Navbar #2
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#2
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Create a Navbar and add it to _app.tsx to apply it to all pages.
Implement the dropdown for the Navbar as well.
It might be a good idea to use CSS position sticky for the Navbar
changed the description
Whoever is implementing this should build out both:
Desktop view:
Mobile view:
assigned to @a258wang
changed the description
Let's not change this yet.
requested review from @a3thakra
This should be in _app.css, and should be applied to all elements.
🤔 hmm....
The
styleelement must be in the<head>tag. @a258wang is working on using fonts correctly for everyone #23We should use the
<article>tag over here, instead of a<div>because it's semantically better.This is a heading, and we should be using semantic html tags. This looks like an
h3(Page heading (h1) -> News (h2) -> Date (h3)Wrap this with a time tag: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time
Use the
<address>tag to wrap author: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/addressUse named exports instead.
Benefits:
import NewsCrad from 'components/NewsCard', but notice that we accidentally misspelledNewsCard)How to use named exports?
export const NewsCard ....on line 12. (preferred)export {NewsCard}The mobile version does not have a white background. Let's only change the background color in a media query.
Resources:
Use
rem(and notpx) for font size and spacing.16px = 1rem.This might work when
props.childrenis astring, but let's not do this ifprops.childrenis aReactElement.#23 @a258wang is doing this.
Most of the comments are for using semantic html over generic elements. Good job overall!
added 5 commits
abf75af4- 1 commit from branchmainCompare with previous version
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
changed this line in version 3 of the diff
added 7 commits
main941e9103- Created NewsCard component w/ font/colour styling36ccadcf- Style NewsCard + index.mdx18a4034b- Change component to use props.children22b2a245- Resolve Adi's commentsCompare with previous version
added 1 commit
aee54dc2- Add news demoCompare with previous version
added 1 commit
6da88cf7- Fix module declarationsCompare with previous version
The
addresstag automatically changes thefont-styletoitalic. We should change this back to normal to match design.font-style: normal;delete this entire file, it's not needed right now :)
LOL 😂
We're getting very close! I think we can merge it tomorrow/soon. 🎉
1 more thing: Make sure that the basename for the files ending with
.module.cssand.tsxis the exactly the same. It's more or a convention, than an error. (So you would name the filesNewsCard.module.cssandNewsCard.tsx- they are case sensitive)git checkout main -- package.json package-lock.jsonto restore these two files.changed this line in version 6 of the diff
changed this line in version 6 of the diff
changed this line in version 6 of the diff
added 1 commit
4b8de4e3- Fix date error + clean codeCompare with previous version
added 1 commit
174a2802- Apply 1 suggestion(s) to 1 file(s)Compare with previous version
changed this line in version 8 of the diff
added 1 commit
20c23b95- Apply 1 suggestion(s) to 1 file(s)Compare with previous version
added 1 commit
121defb3- Delete index.module.css + follow naming conventionCompare with previous version
changed this line in version 10 of the diff
added 1 commit
54026a4a- Rename newscard.module.cssCompare with previous version
From the usage notes:
changed this line in version 11 of the diff
added 1 commit
66c87fea- Apply 1 suggestion(s) to 1 file(s)Compare with previous version
approved this merge request
added 1 commit
618e0239- Fix attribute name on <time>Compare with previous version
enabled an automatic merge when the pipeline for
618e02392bsucceedsmarked this issue as related to #30
mentioned in merge request !32