Fix mobile header #231

j285he · 2021-08-30T19:17:04-04:00

j285he commented

2021-08-30 19:17:04 -04:00

Closes #210

j285he added 1 commit 2021-08-30 19:17:05 -04:00

continuous-integration/drone/push Build is passing Details

6946a32f45 Fix mobile header

j285he commented

2021-08-30 19:18:42 -04:00

Some problems:

I did not use our standard 768px mobile breakpoint because this implementation didn't look very good in tablet.

Everything still looks super left-aligned on Mobile L view, so maybe we want a different design here.

Also for some reason the max-width: 425px media query doesn't apply styles when the width is 425px??

Some problems: I did not use our standard 768px mobile breakpoint because this implementation didn't look very good in tablet. Everything still looks super left-aligned on Mobile L view, so maybe we want a different design here. Also for some reason the `max-width: 425px` media query doesn't apply styles when the width is 425px??

a3thakra closed this pull request

2021-08-30 19:21:46 -04:00

a3thakra commented

2021-08-30 19:22:08 -04:00

oh, i didn't mean to do that, my bad 🙈

a3thakra referenced this pull request

2021-08-30 19:24:22 -04:00

Fix mobile header #232

a3thakra commented

2021-08-30 19:25:16 -04:00

Sorry for closing this Jared, I just created a new PR #232 :)

a3thakra commented

2021-08-30 19:25:58 -04:00

wait I can reopen PRs, I'll close #232 🤦 🤦 IM SO SORRY LOL

a3thakra reopened this pull request

2021-08-30 19:26:22 -04:00

j285he requested review from a3thakra 2021-08-30 19:33:39 -04:00

a3thakra commented

2021-08-30 19:55:41 -04:00

I think it's much better if we make the following changes instead of the ones in this PR:

.header {
	display: flex;
    flex-wrap: wrap;
}

.header a {
	margin-right: 1rem;
}

With this we dont need special mobile styles, and it doesn't break the terms apart.

I think it's much better if we make the following changes instead of the ones in this PR: ```css .header { display: flex; flex-wrap: wrap; } .header a { margin-right: 1rem; } ``` With this we dont need special mobile styles, and it doesn't break the terms apart.

j285he added 1 commit 2021-08-30 20:11:20 -04:00

continuous-integration/drone/push Build is passing Details

4b5f111a1e Change styles

j285he added 1 commit 2021-08-30 20:12:00 -04:00

continuous-integration/drone/push Build is passing Details

c5bb9aa93e Remove comment

a3thakra approved these changes 2021-08-30 20:27:30 -04:00

j285he merged commit c0c2420ee6 into main

2021-08-30 20:37:56 -04:00

j285he referenced this issue from a commit

2021-08-30 20:37:57 -04:00

Fix mobile header (#231)