www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Fix past events rendered twice #245

Merged
j285he merged 6 commits from jared-fix-term-238 into main 2021-08-31 23:19:34 -04:00
Conversation 5 Commits 6 Files Changed 1 +11 -20
j285he commented 2021-08-31 23:02:33 -04:00
Member
Copy Link

Closes #238

Closes #238
j285he added 4 commits 2021-08-31 23:02:35 -04:00
continuous-integration/drone/push Build is failing Details
ad38eca98b Negate the flags
continuous-integration/drone/push Build is passing Details
6256fe0dcd Fix logic, add section
continuous-integration/drone/push Build is failing Details
b6b83e3fb2 Revert workaround for testing
continuous-integration/drone/push Build is failing Details
5e868803bf for real this time
j285he requested review from a3thakra 2021-08-31 23:07:26 -04:00
a3thakra approved these changes 2021-08-31 23:07:32 -04:00
a3thakra left a comment
Owner
Copy Link

Logic LGTM. Haven't tried it.

Logic LGTM. Haven't tried it.
j285he commented 2021-08-31 23:08:27 -04:00
Author
Member
Copy Link

Wait I can simplify this one sec

Wait I can simplify this one sec
a3thakra commented 2021-08-31 23:09:27 -04:00
Owner
Copy Link

No this is actually good, it's slightly repetitive, but that's fine. It looks very clear.

No this is actually good, it's slightly repetitive, but that's fine. It looks very clear.
j285he added 2 commits 2021-08-31 23:13:15 -04:00
continuous-integration/drone/push Build is passing Details
dbf978dec7 Simplify
j285he commented 2021-08-31 23:13:47 -04:00
Author
Member
Copy Link

Ah ok sorry didn't see that. If this doesn't work I can change it back

I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem?

Ah ok sorry didn't see that. If this doesn't work I can change it back I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem?
a3thakra commented 2021-08-31 23:16:35 -04:00
Owner
Copy Link

fwiw, code looked cleaner earlier 🤷

fwiw, code looked cleaner earlier :shrug:
a3thakra commented 2021-08-31 23:17:17 -04:00
Owner
Copy Link

I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem?

Not a problem

> I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem? Not a problem
👍 1
j285he merged commit 966129adf8 into main 2021-08-31 23:19:34 -04:00
j285he deleted branch jared-fix-term-238 2021-08-31 23:19:40 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
a3thakra
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#245
No description provided.
Delete Branch "jared-fix-term-238"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?