Website is broken on firefox #39

New Issue

a3thakra · 2021-06-13T20:39:02-04:00

a3thakra commented

2021-06-13 20:39:02 -04:00

(Migrated from git.uwaterloo.ca)

Firefox has a different date parser. This breaks the entire website.

Firefox has a different date parser. This breaks the entire website. ![image](/uploads/a2678d403268a2e002348f212bccefcf/image.png)

n3parikh commented

2021-06-13 21:49:20 -04:00

(Migrated from git.uwaterloo.ca)

I fixed the specific case in a commit.

As a more general thing, we should come up with a way for this to not happen again.

Maybe we create a function that takes in the year, month, day etc, and then constructs the date in a format we know will work on all browsers?

I fixed the specific case in a commit. As a more general thing, we should come up with a way for this to not happen again. Maybe we create a function that takes in the year, month, day etc, and then constructs the date in a format we know will work on all browsers?

a3thakra commented

2021-06-14 04:36:11 -04:00

(Migrated from git.uwaterloo.ca)

I fixed the specific case in a commit.

23558a2b for reference

As a more general thing, we should come up with a way for this to not happen again.
Maybe we create a function that takes in the year, month, day etc, and then constructs the date in a format we know will work on all browsers?

Yeah, I think that might be a good idea!

> I fixed the specific case in a commit. 23558a2b for reference > As a more general thing, we should come up with a way for this to not happen again. Maybe we create a function that takes in the year, month, day etc, and then constructs the date in a format we know will work on all browsers? Yeah, I think that might be a good idea!

a3thakra commented

2021-06-14 04:39:04 -04:00

(Migrated from git.uwaterloo.ca)

We could possibly also use a library. Although we shouldn't use moment.js. Why

We could possibly also use a library. Although we shouldn't use moment.js. [Why](https://momentjs.com/docs/#/-project-status/)

a3thakra closed this issue

2021-09-27 17:15:39 -04:00

Sign in to join this conversation.