About Us page #7

New Issue

a3thakra · 2021-04-25T16:03:06-04:00

a3thakra commented

2021-04-25 16:03:06 -04:00

(Migrated from git.uwaterloo.ca)

Content on the about Us page can be built using mdx

a3thakra commented

2021-04-25 16:12:17 -04:00

(Migrated from git.uwaterloo.ca)

changed title from About Us to About Us{+ page+}

changed title from **About Us** to **About Us{+ page+}**

l42luo commented

2021-05-11 23:04:37 -04:00

(Migrated from git.uwaterloo.ca)

added 1 commit

553bf7eb - removed extra comments

Compare with previous version

added 1 commit <ul><li>553bf7eb - removed extra comments</li></ul> [Compare with previous version](/csc/website/-/merge_requests/7/diffs?diff_id=55040&start_sha=1799bfbcc782fe8d12346fc249d2cfaba567c75f)

a3thakra commented

2021-05-11 23:13:47 -04:00

(Migrated from git.uwaterloo.ca)

interface Props {
  name: string;
  shortDescription: string;
  description: ReactNode;
  location: string;
  date: string;
  time: string;
}

```suggestion:-7+0 interface Props { name: string; shortDescription: string; description: ReactNode; location: string; date: string; time: string; } ```

a3thakra commented

2021-05-11 23:16:52 -04:00

(Migrated from git.uwaterloo.ca)

We don't need to create a component for this. After that you can use it inline like this: <div>More info or something {dropDownIcon}</div>

const dropDownIcon = (
  <svg
    xmlns="http://www.w3.org/2000/svg"
    width="14"
    height="9"
    viewBox="0 0 14 9"
    fill="none"
    className={styles.dropDownIcon}
  >
    <path
      d="M6.24407 8.12713C6.64284 8.58759 7.35716 8.58759 7.75593 8.12713L13.3613 1.65465C13.9221 1.00701 13.4621 0 12.6053 0H1.39467C0.537918 0 0.0778675 1.00701 0.638743 1.65465L6.24407 8.12713Z"
      fill="#1482E3"
    />
  </svg>
);

We don't need to create a component for this. After that you can use it inline like this: `<div>More info or something {dropDownIcon}</div>` ```suggestion:-16+0 const dropDownIcon = ( <svg xmlns="http://www.w3.org/2000/svg" width="14" height="9" viewBox="0 0 14 9" fill="none" className={styles.dropDownIcon} > <path d="M6.24407 8.12713C6.64284 8.58759 7.35716 8.58759 7.75593 8.12713L13.3613 1.65465C13.9221 1.00701 13.4621 0 12.6053 0H1.39467C0.537918 0 0.0778675 1.00701 0.638743 1.65465L6.24407 8.12713Z" fill="#1482E3" /> </svg> ); ```

a3thakra commented

2021-05-11 23:20:14 -04:00

(Migrated from git.uwaterloo.ca)

div might be better here, because the desc may be longer than 1 paragraph.

      <div className={styles.longDescription}>{descriptionLong}</div>

`div` might be better here, because the desc may be longer than 1 paragraph. ```suggestion:-0+0 <div className={styles.longDescription}>{descriptionLong}</div> ```

l42luo commented

2021-05-11 23:25:09 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/csc/website/-/merge_requests/7/diffs?diff_id=55041&start_sha=553bf7ebe5f2348eba6073d1694f72e5642cd3c2#ac20141f4667edd5aefd7cdc0ffd8c5a618dca1a_29_13)

l42luo commented

2021-05-11 23:25:09 -04:00

(Migrated from git.uwaterloo.ca)

added 1 commit

1d7a6a7b - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>1d7a6a7b - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/csc/website/-/merge_requests/7/diffs?diff_id=55041&start_sha=553bf7ebe5f2348eba6073d1694f72e5642cd3c2)

l42luo commented

2021-05-11 23:38:30 -04:00

(Migrated from git.uwaterloo.ca)

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/csc/website/-/merge_requests/7/diffs?diff_id=55042&start_sha=1d7a6a7bea652035c37f59e63b7ae8e076ef209f#ac20141f4667edd5aefd7cdc0ffd8c5a618dca1a_53_51)

l42luo commented

2021-05-11 23:38:30 -04:00

(Migrated from git.uwaterloo.ca)

added 2 commits

df2da81d - addresed MR comments
010b6e12 - updating branch

Compare with previous version

added 2 commits <ul><li>df2da81d - addresed MR comments</li><li>010b6e12 - updating branch</li></ul> [Compare with previous version](/csc/website/-/merge_requests/7/diffs?diff_id=55042&start_sha=1d7a6a7bea652035c37f59e63b7ae8e076ef209f)

a3thakra commented

2021-05-12 00:29:51 -04:00

(Migrated from git.uwaterloo.ca)

added 1 commit

dee23913 - Polish up css + render in playground

Compare with previous version

added 1 commit <ul><li>dee23913 - Polish up css + render in playground</li></ul> [Compare with previous version](/csc/website/-/merge_requests/7/diffs?diff_id=55043&start_sha=010b6e120a7cfeaff2d868550aaff8ee0d928deb)

a3thakra commented

2021-05-12 00:32:08 -04:00

(Migrated from git.uwaterloo.ca)

approved this merge request

a3thakra commented

2021-05-13 03:44:30 -04:00

(Migrated from git.uwaterloo.ca)

mentioned in issue #15