www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Meet the team page #9

New Issue
Closed
opened 2021-04-25 16:05:14 -04:00 by a3thakra · 23 comments
a3thakra commented 2021-04-25 16:05:14 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link
  • #8 TeamMemberCard
  • #22 TeamMember
- #8 TeamMemberCard - #22 TeamMember
a3thakra commented 2021-04-25 16:11:52 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed title from Meet the team to Meet the team{+ page+}

changed title from **Meet the team** to **Meet the team{+ page+}**
a3thakra commented 2021-04-25 17:38:15 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 design

added [1 design](/csc/website/-/issues/9/designs?version=136)
a3thakra commented 2021-04-25 17:38:31 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

removed 1 design

removed [1 design](/csc/website/-/issues/9/designs?version=137)
a3thakra commented 2021-04-25 17:38:48 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed the description

changed the description
a258wang commented 2021-05-15 23:45:33 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed title from {-feat/n-}avbar to {+N+}avbar

changed title from **{-feat/n-}avbar** to **{+N+}avbar**
a3thakra commented 2021-05-16 01:38:26 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

all exports in components should be named exports

all exports in components should be named exports ```suggestion:-0+0 ```
a3thakra commented 2021-05-16 01:39:40 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

Put these in CSS as well?

Put these in CSS as well?
a3thakra commented 2021-05-16 01:44:09 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link
.dropdown > li:first-child > a {
```suggestion:-0+0 .dropdown > li:first-child > a { ```
a3thakra commented 2021-05-16 01:44:24 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link
.dropdown > li:last-child > a {
```suggestion:-0+0 .dropdown > li:last-child > a { ```
a3thakra commented 2021-05-16 02:03:57 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

https://stackoverflow.com/questions/556153/inline-elements-shifting-when-made-bold-on-hover

(i zoomed in so it's easier to show the shift)

recording

https://stackoverflow.com/questions/556153/inline-elements-shifting-when-made-bold-on-hover (i zoomed in so it's easier to show the shift) ![recording](/uploads/64f3a4236c0c3f2444190666434b7fd4/recording.gif)
a3thakra commented 2021-05-16 02:08:05 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

this image is not in the center

image

image

this image is not in the center ![image](/uploads/991ba7eab006e0ba11359dd562a22376/image.png) ![image](/uploads/66018fa164f8bca5390ef2ad3f157d82/image.png)
a3thakra commented 2021-05-16 02:11:03 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link
  • package-lock.json shouldn't change. make sure you have npm 7

Just a couple of comments, but overall very clean and well done. Great job! 🎉

- `package-lock.json` shouldn't change. make sure you have npm 7 Just a couple of comments, but overall very clean and well done. Great job! :tada:
a258wang commented 2021-05-16 11:46:08 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

width and height are required props for Next.js' Image component, unless we pass the optional prop layout="fill" (in which case we would probably need a wrapper around the Image with the appropriate width/height, if I'm understanding things correctly). Do we want to make this change?

Next.js Image documentation: https://nextjs.org/docs/api-reference/next/image

`width` and `height` are required props for Next.js' Image component, unless we pass the optional prop `layout="fill"` (in which case we would probably need a wrapper around the Image with the appropriate width/height, if I'm understanding things correctly). Do we want to make this change? Next.js Image documentation: https://nextjs.org/docs/api-reference/next/image
a258wang commented 2021-05-16 17:59:30 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/9/diffs?diff_id=55347&start_sha=9bb73f1d9622c9b9090824336ce647da5e4220b6#a578c7e8c33c7f24400807e00a74617aec18284b_127_126)
a258wang commented 2021-05-16 17:59:30 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/9/diffs?diff_id=55347&start_sha=9bb73f1d9622c9b9090824336ce647da5e4220b6#a228e1ce69ade6868a9b8c2a5e63ae458e89379a_110_121)
a258wang commented 2021-05-16 17:59:30 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/9/diffs?diff_id=55347&start_sha=9bb73f1d9622c9b9090824336ce647da5e4220b6#a228e1ce69ade6868a9b8c2a5e63ae458e89379a_115_126)
a258wang commented 2021-05-16 17:59:30 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 3 commits

  • b4d4a152 - 1 commit from branch main
  • befbb19e - Fix small details based on Adi's feedback
  • 43fe7eaf - Merge branch 'main' into feat/navbar

Compare with previous version

added 3 commits <ul><li>b4d4a152 - 1 commit from branch <code>main</code></li><li>befbb19e - Fix small details based on Adi&#39;s feedback</li><li>43fe7eaf - Merge branch &#39;main&#39; into feat/navbar</li></ul> [Compare with previous version](/csc/website/-/merge_requests/9/diffs?diff_id=55347&start_sha=9bb73f1d9622c9b9090824336ce647da5e4220b6)
a3thakra commented 2021-05-16 19:10:20 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

It's alright then! 👍

It's alright then! 👍
a3thakra commented 2021-05-16 19:10:20 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

resolved all threads

resolved all threads
a258wang commented 2021-05-17 16:21:14 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c5591d30 - Fix package-lock.json</li></ul> [Compare with previous version](/csc/website/-/merge_requests/9/diffs?diff_id=55408&start_sha=43fe7eafceaee4ed84b9fef90abff74258c28ca4)
a3thakra commented 2021-05-18 03:16:28 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

approved this merge request

approved this merge request
dora commented 2021-05-20 03:55:46 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

mentioned in merge request !10

mentioned in merge request !10
b38peng commented 2021-06-22 20:58:34 -04:00 (Migrated from git.uwaterloo.ca)
Copy Link

assigned to @b38peng

assigned to @b38peng
a3thakra added this to the First Draft milestone 2021-07-11 16:29:59 -04:00
b38peng was assigned by a3thakra 2021-07-11 16:30:21 -04:00
b38peng referenced this issue from a commit 2021-08-23 11:11:48 -04:00
Meet the Team page (#94)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
internship-guide-2
nextcloud-widget
exec-blurb
renovate/typescript-5.x
renovate/next-14.x
renovate/ical-generator-7.x
renovate/date-fns-3.x
renovate/typescript-eslint-parser-7.x
renovate/typescript-eslint-eslint-plugin-7.x
renovate/next-mdx-14.x
renovate/mdx-js-react-3.x
renovate/mdx-js-loader-3.x
renovate/node-18.x
Ev-New-Event-Csc-Circles-Easter-Egg-Hunt-March-27-2024-1711581834781
Ev-New-Event-Taxes-101-March-27-2024-1711581616630
Ev-New-Event-Csc-Circles-Movie-Night-March-27-2024-1711581333300
Ev-New-Event-Csc-Codeylympics-Ii-March-27-2024-1711581176020
Ev-New-Event-Csc-Trivia-Night-March-27-2024-1711580949130
Ev-New-Event-Info-Session-For-Ura-Grad-Opportunities-March-27-2024-1711580809155
Ev-New-Event-Internship-Insights-March-27-2024-1711580694779
Ev-New-Event-Jason-Goodison-Talk-March-27-2024-1711580404155
Ev-New-Event-Test-Event-March-27-2024-1711580239047
exec-blurbs
internship-guide
Ev-New-Event-Valentines-Code-Party-February-11-2024-1707695692668
Ev-New-Event-Csc-Codeylympics-February-11-2024-1707695587472
Ev-New-Event-Fall-2023-Elections-February-11-2024-1707695274434
Ev-New-Event-Csc-End-Of-Term-February-11-2024-1707694525395
Ev-New-Event-Csc-Dodgeball-Tournament-February-11-2024-1707694725304
Ev-New-Event-November-Code-Party-February-11-2024-1707681589953
Ev-New-Event-Trivia-Night-February-08-2024-1707443541421
Ev-New-Event-Escape-Mc-Manor-February-08-2024-1707443356540
Ev-New-Event-Recruiters-Panel-February-11-2024-1707682002638
Ev-New-Event-W24-Bootcamp-February-04-2024-1707084574336
Ev-New-Event-David-Wolever-Postgresql-Talk-February-04-2024-1707084327590
Ev-New-Event-Csc-Beginning-Of-Term-February-04-2024-1707083704858
Ev-New-Event-Csc-Beginning-Of-Term-February-04-2024-1707076757770
Ev-New-Event-Escape-Mc-Manor-February-01-2024-1706839752816
Ev-New-Event-Csc-Beginning-Of-Term-February-01-2024-1706830083872
update-team-page
Ev-New-Event-Csc-Beginning-Of-Term-January-22-2024-1705976938370
n4chung/update-online-membership-note
richard/update-exec-640
Ev-New-Event-Build-Networks-In-Tech-November-15-2023-1700094289813
Ev-New-Event-Build-Networks-In-Tech-November-15-2023-1700093575650
Ev-New-Event-Acing-The-Technical-Interview-W-Icpc-Coach-Christian-Lim-November-15-2023-1700090655704
fix-adding-class-profile-to-team-page
Ev-New-Event-A-November-06-2023-1699317492840
Ev-New-Event-A-November-06-2023-1699317323665
Ev-New-Event-A-November-06-2023-1699317144162
Ev-New-Event-A-November-06-2023-1699298328549
daniel-su/add-myself-to-website
renovate/node-21.x
Ev-New-Event-A-November-06-2023-1699296715918
Ev-New-Event-A-November-06-2023-1699296856594
Ev-New-Event-A-November-06-2023-1699297090365
Ev-New-Event-Test-November-06-2023-1699295917474
Ev-New-Event-Test-November-06-2023-1699296519244
renovate/remark-html-16.x
renovate/ldapts-7.x
renovate/npm-10.x
renovate/remark-15.x
add-s23-events
renovate/eslint-config-prettier-9.x
amy-remove-caffeine
anniesun/add-office-status
renovate/eslint-plugin-prettier-5.x
renovate/typescript-eslint-parser-5.x
renovate/prettier-3.x
renovate/postcss-preset-env-9.x
Ev-New-Event-Test-Event-June-17-2023-1687022992622
Ev-New-Event-Test-June-10-2023-1686447073380
Ev-New-Event-123-June-10-2023-1686446983999
Ev-New-Event-123-June-10-2023-1686446849710
Ev-New-Event-123-June-10-2023-1686446643513
Ev-New-Event-Test-June-10-2023-1686446470699
Ev-New-Event-Test-June-10-2023-1686437048471
Ev-New-Event-Test-Event-June-10-2023-1686436739371
Ev-New-Event-Test-Event-From-Eventr-June-10-2023-1686435846281
Ev-New-Event-Test-June-10-2023-1686435577325
shahanneda/add-tropical-code-party
add-imane-photo
Ev-New-Event-123-June-07-2023-1686113292428
Ev-New-Event-123-June-07-2023-1686113019308
meet-the-team
meet-team
meet_the_team
raymo-s23-updates
change_AVP_treasurer
jan-2023-constitution-changes
renovate/node-20.x
renovate/postcss-calc-9.x
renovate/react-dom-18.x
renovate/react-18.x
renovate/fs-extra-11.x
renovate/date-fns-tz-2.x
renovate/typescript-4.x
renovate/next-11.x
renovate/squoosh-lib-0.x
renovate/next-mdx-remote-3.x
renovate/next-mdx-11.x
April-Code-Party
add-name-to-web-committe
shahanneda/alt-tab-and-cp
darren/fix-dead-link
darren/add-class-profile-news
richardshuai/karaoke
shahanneda/update-team
w23-update-team
anniesun/update-blurbs
shahanneda/add-code-party-23
annies/add-circles-event
darren/add-news
anniesun/add-myself-to-webstite
darren/add-myself-to-website
shahanneda/add-myself
shahanneda/fix-name-parts
shahanneda/add-bot
update-events
shahanneda/add-events
shahanneda/fix-build-image-script
amy-add-alt-tab-f22
shahanneda/add-alt-tab-news
amy-events-karaoke
amy-update-annie-headshot-f22
amy-update-internship-repo-f22
amy-fix-vp-f22
amy-add-librarian-f22
shahanneda/update-exec-blurbs
shahanneda/add-code-party-1
shahanneda/update-project-program
a258wang-events-2022-09-28
amy-news-2022-09-14
news-2022-09-10
j285he-add-news-09-07
news-2022-09-08
amy-events-august-2022
amy-update-community-reps
shahanneda/add-event
2022-07-08-MUA-Update
amy-image-optimization-quick-fix-experiment
b72zhou-past-exec
shahanneda/optimze-image-script
neil-members
unix101-1
warning-header
ldap-exec-test
support-multiple-news-homepage
j285he-ldap-test-example
renovate/typescript-eslint-eslint-plugin-5.x
renovate/eslint-plugin-react-7.x
renovate/eslint-plugin-prettier-4.x
renovate/eslint-8.x
shahanneda-news-11jan2022
bonnie-team-member-card
fix-oc-burger
amy-random-shapes
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
First Draft
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
b38peng
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#9
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?