Meet the team page #9

Closed
opened 2 years ago by a3thakra · 23 comments
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator
  • #8 TeamMemberCard
  • #22 TeamMember
- #8 TeamMemberCard - #22 TeamMember
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed title from Meet the team to Meet the team{+ page+}

changed title from **Meet the team** to **Meet the team{+ page+}**
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 1 design

added [1 design](/csc/website/-/issues/9/designs?version=136)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

removed 1 design

removed [1 design](/csc/website/-/issues/9/designs?version=137)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed the description

changed the description
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed title from {-feat/n-}avbar to {+N+}avbar

changed title from **{-feat/n-}avbar** to **{+N+}avbar**
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

all exports in components should be named exports

all exports in components should be named exports ```suggestion:-0+0 ```
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

Put these in CSS as well?

Put these in CSS as well?
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator
.dropdown > li:first-child > a {
```suggestion:-0+0 .dropdown > li:first-child > a { ```
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator
.dropdown > li:last-child > a {
```suggestion:-0+0 .dropdown > li:last-child > a { ```
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator
https://stackoverflow.com/questions/556153/inline-elements-shifting-when-made-bold-on-hover (i zoomed in so it's easier to show the shift) ![recording](/uploads/64f3a4236c0c3f2444190666434b7fd4/recording.gif)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

this image is not in the center

image

image

this image is not in the center ![image](/uploads/991ba7eab006e0ba11359dd562a22376/image.png) ![image](/uploads/66018fa164f8bca5390ef2ad3f157d82/image.png)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator
  • package-lock.json shouldn't change. make sure you have npm 7

Just a couple of comments, but overall very clean and well done. Great job! 🎉

- `package-lock.json` shouldn't change. make sure you have npm 7 Just a couple of comments, but overall very clean and well done. Great job! :tada:
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

width and height are required props for Next.js' Image component, unless we pass the optional prop layout="fill" (in which case we would probably need a wrapper around the Image with the appropriate width/height, if I'm understanding things correctly). Do we want to make this change?

Next.js Image documentation: https://nextjs.org/docs/api-reference/next/image

`width` and `height` are required props for Next.js' Image component, unless we pass the optional prop `layout="fill"` (in which case we would probably need a wrapper around the Image with the appropriate width/height, if I'm understanding things correctly). Do we want to make this change? Next.js Image documentation: https://nextjs.org/docs/api-reference/next/image
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/9/diffs?diff_id=55347&start_sha=9bb73f1d9622c9b9090824336ce647da5e4220b6#a578c7e8c33c7f24400807e00a74617aec18284b_127_126)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/9/diffs?diff_id=55347&start_sha=9bb73f1d9622c9b9090824336ce647da5e4220b6#a228e1ce69ade6868a9b8c2a5e63ae458e89379a_110_121)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/csc/website/-/merge_requests/9/diffs?diff_id=55347&start_sha=9bb73f1d9622c9b9090824336ce647da5e4220b6#a228e1ce69ade6868a9b8c2a5e63ae458e89379a_115_126)
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 3 commits

  • b4d4a152 - 1 commit from branch main
  • befbb19e - Fix small details based on Adi's feedback
  • 43fe7eaf - Merge branch 'main' into feat/navbar

Compare with previous version

added 3 commits <ul><li>b4d4a152 - 1 commit from branch <code>main</code></li><li>befbb19e - Fix small details based on Adi&#39;s feedback</li><li>43fe7eaf - Merge branch &#39;main&#39; into feat/navbar</li></ul> [Compare with previous version](/csc/website/-/merge_requests/9/diffs?diff_id=55347&start_sha=9bb73f1d9622c9b9090824336ce647da5e4220b6)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

It's alright then! 👍

It's alright then! 👍
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

resolved all threads

resolved all threads
a258wang commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

added 1 commit

Compare with previous version

added 1 commit <ul><li>c5591d30 - Fix package-lock.json</li></ul> [Compare with previous version](/csc/website/-/merge_requests/9/diffs?diff_id=55408&start_sha=43fe7eafceaee4ed84b9fef90abff74258c28ca4)
a3thakra commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

approved this merge request

approved this merge request
dora commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

mentioned in merge request !10

mentioned in merge request !10
b38peng commented 2 years ago (Migrated from git.uwaterloo.ca)
Collaborator

assigned to @b38peng

assigned to @b38peng
a3thakra added this to the First Draft milestone 2 years ago
b38peng was assigned by a3thakra 2 years ago
b38peng closed this issue 2 years ago
b38peng referenced this issue from a commit 2 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#9
Loading…
There is no content yet.