Meet the team page #9
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#9
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
changed title from Meet the team to Meet the team{+ page+}
added 1 design
removed 1 design
changed the description
changed title from {-feat/n-}avbar to {+N+}avbar
all exports in components should be named exports
Put these in CSS as well?
https://stackoverflow.com/questions/556153/inline-elements-shifting-when-made-bold-on-hover
(i zoomed in so it's easier to show the shift)
this image is not in the center
package-lock.json
shouldn't change. make sure you have npm 7Just a couple of comments, but overall very clean and well done. Great job! 🎉
width
andheight
are required props for Next.js' Image component, unless we pass the optional proplayout="fill"
(in which case we would probably need a wrapper around the Image with the appropriate width/height, if I'm understanding things correctly). Do we want to make this change?Next.js Image documentation: https://nextjs.org/docs/api-reference/next/image
changed this line in version 2 of the diff
changed this line in version 2 of the diff
changed this line in version 2 of the diff
added 3 commits
b4d4a152
- 1 commit from branchmain
befbb19e
- Fix small details based on Adi's feedback43fe7eaf
- Merge branch 'main' into feat/navbarCompare with previous version
It's alright then! 👍
resolved all threads
added 1 commit
c5591d30
- Fix package-lock.jsonCompare with previous version
approved this merge request
mentioned in merge request !10
assigned to @b38peng