www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Add /news/archive and /news/[year]/[term] pages #146

Merged
a3thakra merged 4 commits from adi-news-archive into adi-news-content 2021-08-17 15:09:20 -04:00
Conversation 2 Commits 4 Files Changed 9 +170 -8
a3thakra commented 2021-08-13 04:45:35 -04:00
Owner
Copy Link

Closes #89

Closes #89
a3thakra added 4 commits 2021-08-13 04:45:36 -04:00
continuous-integration/drone/push Build is failing Details
60ec87ac7f Add /news/[year]/[term] page
continuous-integration/drone/push Build is passing Details
4d9b4276f7 Remove <br> tags
a3thakra requested review from b38peng 2021-08-13 04:45:58 -04:00
a3thakra requested review from d43su 2021-08-13 04:45:58 -04:00
b38peng commented 2021-08-16 20:50:48 -04:00
Member
Copy Link

kinda random but this is happening for winter 2014? It's probably just that post. Everything else looks good tho! image

kinda random but this is happening for winter 2014? It's probably just that post. Everything else looks good tho! ![image](/attachments/3e1254b8-e9f6-475b-a4aa-046608cbcc0f)
image.png
92 KiB
b38peng approved these changes 2021-08-16 20:51:06 -04:00
a3thakra commented 2021-08-16 22:20:03 -04:00
Author
Owner
Copy Link

@b38peng yeah 😅 that's caused by the tt tags in the xml

tt tags are deprecated in HTML5, so the fix would be to replace all the tt tags with code tags. (showdown doesn't convert the tt tags to markdown correctly - More info here: https://git.uwaterloo.ca/csc/old-website/-/merge_requests/1)

I'll regenerate the news after replacing it in the xml file. Good job of catching this!

@b38peng yeah 😅 that's caused by the `tt` tags in the [xml](https://git.uwaterloo.ca/csc/old-website/-/blob/master/news.xml#L811) `tt` tags are deprecated in HTML5, so the fix would be to replace all the `tt` tags with `code` tags. (showdown doesn't convert the `tt` tags to markdown correctly - More info here: https://git.uwaterloo.ca/csc/old-website/-/merge_requests/1) I'll regenerate the news after replacing it in the xml file. Good job of catching this!
a3thakra merged commit 07cae3e262 into adi-news-content 2021-08-17 15:09:20 -04:00
a3thakra deleted branch adi-news-archive 2021-08-17 15:09:28 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
d43su
b38peng
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#146
No description provided.
Delete Branch "adi-news-archive"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?