www
/
www-new
12
2
Fork 3
Code Issues 56 Pull Requests 29 Projects Releases Wiki Activity
Labels Milestones

Add /news/archive and /news/[year]/[term] pages #146

Merged
a3thakra merged 4 commits from adi-news-archive into adi-news-content 2 years ago
Conversation 2 Commits 4 Files Changed 9
a3thakra commented 2 years ago
Collaborator

Closes #89

Closes #89
a3thakra added 4 commits 2 years ago
continuous-integration/drone/push Build is failing
Details
60ec87ac7f Add /news/[year]/[term] page
continuous-integration/drone/push Build is passing
Details
4d9b4276f7 Remove <br> tags
a3thakra requested review from b38peng 2 years ago
a3thakra requested review from d43su 2 years ago
b38peng commented 2 years ago
Collaborator

kinda random but this is happening for winter 2014? It's probably just that post. Everything else looks good tho! image

kinda random but this is happening for winter 2014? It's probably just that post. Everything else looks good tho! ![image](/attachments/3e1254b8-e9f6-475b-a4aa-046608cbcc0f)
image.png
92 KiB
b38peng approved these changes 2 years ago
a3thakra commented 2 years ago
Poster
Collaborator

@b38peng yeah 😅 that's caused by the tt tags in the xml

tt tags are deprecated in HTML5, so the fix would be to replace all the tt tags with code tags. (showdown doesn't convert the tt tags to markdown correctly - More info here: https://git.uwaterloo.ca/csc/old-website/-/merge_requests/1)

I'll regenerate the news after replacing it in the xml file. Good job of catching this!

@b38peng yeah 😅 that's caused by the `tt` tags in the [xml](https://git.uwaterloo.ca/csc/old-website/-/blob/master/news.xml#L811) `tt` tags are deprecated in HTML5, so the fix would be to replace all the `tt` tags with `code` tags. (showdown doesn't convert the `tt` tags to markdown correctly - More info here: https://git.uwaterloo.ca/csc/old-website/-/merge_requests/1) I'll regenerate the news after replacing it in the xml file. Good job of catching this!
a3thakra merged commit 07cae3e262 into adi-news-content 2 years ago
a3thakra deleted branch adi-news-archive 2 years ago

Reviewers

d43su was requested for review 2 years ago
b38peng approved these changes 2 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 07cae3e262.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
d43su
b38peng
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#146
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'adi-news-archive'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes