www
/
www-new
12
2
Fork 3
Code Issues 58 Pull Requests 31 Projects Releases Wiki Activity
Labels Milestones

Add /events/[year] page #151

Merged
j285he merged 33 commits from feat/events-year into main 2 years ago
Conversation 5 Commits 33 Files Changed 2
j285he commented 2 years ago
Collaborator

Closes #112

Closes #112
j285he added 20 commits 2 years ago
continuous-integration/drone/push Build is passing
Details
b733acd156 Add lib file
continuous-integration/drone/push Build is passing
Details
bfcbf5c687 Fix type error
continuous-integration/drone/push Build is passing
Details
9f7d40b426 Merge branch 'main' into feat/events-lib
continuous-integration/drone/push Build is passing
Details
c39b0036ad Correct Dirents
continuous-integration/drone/push Build is failing
Details
590b2554c0 Fixes for dirents
continuous-integration/drone/push Build is passing
Details
d237621d14 ESLint fixes
continuous-integration/drone/push Build is passing
Details
3a697c09c0 Add sorting
continuous-integration/drone/push Build is passing
Details
b32fd53d95 Remove unneeded dirent conversion
continuous-integration/drone/push Build is failing
Details
40d37c4aea Fix lint problems
continuous-integration/drone/push Build is passing
Details
fecd3bf3e0 Rename functions
continuous-integration/drone/push Build is failing
Details
2798efc221 Function renaming
j285he added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
5dd258ec86 Merge branch 'main' into feat/events-year
j285he added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
408275e8cf Remove temp page
j285he changed title from WIP: Add /events/[year] page to Add /events/[year] page 2 years ago
j285he requested review from a3thakra 2 years ago
a3thakra commented 2 years ago
Collaborator

Can you add all the events in a separate PR? I can't see the actual changes right now.

Can you add all the events in a separate PR? I can't see the actual changes right now.
j285he added 1 commit 2 years ago
continuous-integration/drone/push Build is failing
Details
10449e921e Remove events
j285he added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
29f2c3208c Fix build error
j285he commented 2 years ago
Poster
Collaborator

Can you add all the events in a separate PR? I can't see the actual changes right now.

OK, see !157. I've added the content/events folder so that I could pass build, and also added content/events/2021 for testing and demonstration purposes.

> Can you add all the events in a separate PR? I can't see the actual changes right now. OK, see !157. I've added the `content/events` folder so that I could pass build, and also added `content/events/2021` for testing and demonstration purposes.
j285he added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
50c2f08769 Simplify types
a3thakra commented 2 years ago
Collaborator

Most comments on #158 apply here too.

Most comments on #158 apply here too.
j285he added 2 commits 2 years ago
continuous-integration/drone/push Build is passing
Details
733af0a28a Make consistent with other pages
a3thakra reviewed 2 years ago
pages/events/[year]/year.module.css Outdated
margin: auto;
margin-top: calc(112rem / 16);
margin-bottom: calc(224rem / 16);
width: calc(800rem / 16);
a3thakra commented 2 years ago
Collaborator

no need, DefaultLayout already handles this.

no need, DefaultLayout already handles this.
j285he marked this conversation as resolved
a3thakra reviewed 2 years ago
pages/events/[year]/year.module.css Outdated
.main {
margin: auto;
a3thakra commented 2 years ago
Collaborator

no need, just set top and bottom

no need, just set top and bottom
j285he marked this conversation as resolved
a3thakra reviewed 2 years ago
pages/events/[year]/year.module.css Outdated
.main {
margin: auto;
margin-top: calc(112rem / 16);
a3thakra commented 2 years ago
Collaborator

reduce this for mobile styles

reduce this for mobile styles
j285he commented 2 years ago
Poster
Collaborator

I eyeballed with 112rem/48px for desktop/mobile's margin-top. I measured in Figma and I believe it says 157px/70px, however trying those values the spacing seemed off. Let me know if you want that changed.

(oops, also if you get like 12 notifications for this, sorry. I may have spammed the reply button after my wifi flipped out 😣)

I eyeballed with 112rem/48px for desktop/mobile's `margin-top`. I measured in Figma and I believe it says 157px/70px, however trying those values the spacing seemed off. Let me know if you want that changed. (oops, also if you get like 12 notifications for this, sorry. I may have spammed the reply button after my wifi flipped out 😣)
a3thakra commented 2 years ago
Collaborator

Just 60px for both mobile and desktop should be good

Just 60px for both mobile and desktop should be good
j285he marked this conversation as resolved
a3thakra reviewed 2 years ago
pages/events/[year]/year.module.css Outdated
.main {
margin: auto;
margin-top: calc(112rem / 16);
margin-bottom: calc(224rem / 16);
a3thakra commented 2 years ago
Collaborator

no need.

no need.
j285he marked this conversation as resolved
a3thakra reviewed 2 years ago
pages/events/[year]/year.module.css Outdated
width: calc(800rem / 16);
}
.heading2 {
a3thakra commented 2 years ago
Collaborator

no need.

no need.
j285he marked this conversation as resolved
a3thakra reviewed 2 years ago
pages/events/[year]/year.module.css Outdated
color: var(--primary-accent)
}
.links {
a3thakra commented 2 years ago
Collaborator

Please look at how this is done in news archive and copy from there

Please look at how this is done in news archive and copy from there
j285he marked this conversation as resolved
j285he added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
ff8f52e44d Address CSS issues
j285he added 2 commits 2 years ago
continuous-integration/drone/push Build is passing
Details
92e7965d84 60px margins
j285he added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
4a2e8d522b Remove hr, rename css file
j285he added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
a13f48edfe Merge branch 'main' into feat/events-year
a3thakra commented 2 years ago
Collaborator

Can you delete the .gitkeep files?

Can you delete the .gitkeep files?
a3thakra reviewed 2 years ago
pages/events/[year]/index.module.css Outdated
@media only screen and (max-width: calc(768rem / 16)) {
.main {
margin-top: calc(60rem / 16);
a3thakra commented 2 years ago
Collaborator

no need

no need
j285he marked this conversation as resolved
a3thakra reviewed 2 years ago
pages/events/[year]/index.module.css
.main > h2 {
padding-bottom: 1rem;
border-bottom: 1px solid var(--primary-heading);
a3thakra commented 2 years ago
Collaborator

calc(1rem / 16)

calc(1rem / 16)
j285he marked this conversation as resolved
a3thakra commented 2 years ago
Collaborator

LGTM after the 3 comments above!

LGTM after the 3 comments above!
j285he added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
59b63a3d2f PR fixes
a3thakra approved these changes 2 years ago
j285he merged commit 656524eee7 into main 2 years ago
j285he referenced this issue from a commit 2 years ago
Add /events/[year] page (#151)
j285he deleted branch feat/events-year 2 years ago

Reviewers

a3thakra approved these changes 2 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 656524eee7.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
a3thakra
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#151
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/events-year'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes