Add /events/[year] page #151

Merged
j285he merged 33 commits from feat/events-year into main 1 year ago
j285he commented 1 year ago
Collaborator

Closes #112

Closes #112
j285he added 20 commits 1 year ago
b733acd156 Add lib file
bfcbf5c687 Fix type error
9f7d40b426 Merge branch 'main' into feat/events-lib
c39b0036ad Correct Dirents
590b2554c0 Fixes for dirents
d237621d14 ESLint fixes
3a697c09c0 Add sorting
b32fd53d95 Remove unneeded dirent conversion
40d37c4aea Fix lint problems
fecd3bf3e0 Rename functions
2798efc221 Function renaming
j285he added 1 commit 1 year ago
5dd258ec86 Merge branch 'main' into feat/events-year
j285he added 1 commit 1 year ago
408275e8cf Remove temp page
j285he changed title from WIP: Add /events/[year] page to Add /events/[year] page 1 year ago
j285he requested review from a3thakra 1 year ago
Collaborator

Can you add all the events in a separate PR? I can't see the actual changes right now.

Can you add all the events in a separate PR? I can't see the actual changes right now.
j285he added 1 commit 1 year ago
10449e921e Remove events
j285he added 1 commit 1 year ago
29f2c3208c Fix build error
Poster
Collaborator

Can you add all the events in a separate PR? I can't see the actual changes right now.

OK, see !157. I've added the content/events folder so that I could pass build, and also added content/events/2021 for testing and demonstration purposes.

> Can you add all the events in a separate PR? I can't see the actual changes right now. OK, see !157. I've added the `content/events` folder so that I could pass build, and also added `content/events/2021` for testing and demonstration purposes.
j285he added 1 commit 1 year ago
50c2f08769 Simplify types
Collaborator

Most comments on #158 apply here too.

Most comments on #158 apply here too.
j285he added 2 commits 1 year ago
a3thakra reviewed 1 year ago
margin: auto;
margin-top: calc(112rem / 16);
margin-bottom: calc(224rem / 16);
width: calc(800rem / 16);
Collaborator

no need, DefaultLayout already handles this.

no need, DefaultLayout already handles this.
j285he marked this conversation as resolved
a3thakra reviewed 1 year ago
.main {
margin: auto;
Collaborator

no need, just set top and bottom

no need, just set top and bottom
j285he marked this conversation as resolved
a3thakra reviewed 1 year ago
.main {
margin: auto;
margin-top: calc(112rem / 16);
Collaborator

reduce this for mobile styles

reduce this for mobile styles
Poster
Collaborator

I eyeballed with 112rem/48px for desktop/mobile's margin-top. I measured in Figma and I believe it says 157px/70px, however trying those values the spacing seemed off. Let me know if you want that changed.

(oops, also if you get like 12 notifications for this, sorry. I may have spammed the reply button after my wifi flipped out 😣)

I eyeballed with 112rem/48px for desktop/mobile's `margin-top`. I measured in Figma and I believe it says 157px/70px, however trying those values the spacing seemed off. Let me know if you want that changed. (oops, also if you get like 12 notifications for this, sorry. I may have spammed the reply button after my wifi flipped out 😣)
Collaborator

Just 60px for both mobile and desktop should be good

Just 60px for both mobile and desktop should be good
j285he marked this conversation as resolved
a3thakra reviewed 1 year ago
.main {
margin: auto;
margin-top: calc(112rem / 16);
margin-bottom: calc(224rem / 16);
Collaborator

no need.

no need.
j285he marked this conversation as resolved
a3thakra reviewed 1 year ago
width: calc(800rem / 16);
}
.heading2 {
Collaborator

no need.

no need.
j285he marked this conversation as resolved
a3thakra reviewed 1 year ago
color: var(--primary-accent)
}
.links {
Collaborator

Please look at how this is done in news archive and copy from there

Please look at how this is done in news archive and copy from there
j285he marked this conversation as resolved
j285he added 1 commit 1 year ago
ff8f52e44d Address CSS issues
j285he added 2 commits 1 year ago
j285he added 1 commit 1 year ago
4a2e8d522b Remove hr, rename css file
j285he added 1 commit 1 year ago
a13f48edfe Merge branch 'main' into feat/events-year
Collaborator

Can you delete the .gitkeep files?

Can you delete the .gitkeep files?
a3thakra reviewed 1 year ago
@media only screen and (max-width: calc(768rem / 16)) {
.main {
margin-top: calc(60rem / 16);
Collaborator

no need

no need
j285he marked this conversation as resolved
a3thakra reviewed 1 year ago
.main > h2 {
padding-bottom: 1rem;
border-bottom: 1px solid var(--primary-heading);
Collaborator

calc(1rem / 16)

calc(1rem / 16)
j285he marked this conversation as resolved
Collaborator

LGTM after the 3 comments above!

LGTM after the 3 comments above!
j285he added 1 commit 1 year ago
59b63a3d2f PR fixes
a3thakra approved these changes 1 year ago
j285he merged commit 656524eee7 into main 1 year ago
j285he referenced this issue from a commit 1 year ago
j285he deleted branch feat/events-year 1 year ago

Reviewers

a3thakra approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 656524eee7.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#151
Loading…
There is no content yet.