www
/
www-new
16
3
Fork 8
Code Issues 58 Pull Requests 47 Projects Releases Wiki Activity

Add /events/[year] page #151

Merged
j285he merged 33 commits from feat/events-year into main 2021-08-27 21:49:26 -04:00
Conversation 5 Commits 33 Files Changed 2 +82
j285he commented 2021-08-17 17:25:40 -04:00
Member
Copy Link

Closes #112

Closes #112
j285he added 20 commits 2021-08-17 17:25:42 -04:00
continuous-integration/drone/push Build is passing Details
b733acd156 Add lib file
continuous-integration/drone/push Build is passing Details
bfcbf5c687 Fix type error
continuous-integration/drone/push Build is passing Details
9f7d40b426 Merge branch 'main' into feat/events-lib
continuous-integration/drone/push Build is passing Details
c39b0036ad Correct Dirents
continuous-integration/drone/push Build is failing Details
590b2554c0 Fixes for dirents
continuous-integration/drone/push Build is passing Details
d237621d14 ESLint fixes
continuous-integration/drone/push Build is passing Details
3a697c09c0 Add sorting
continuous-integration/drone/push Build is passing Details
b32fd53d95 Remove unneeded dirent conversion
continuous-integration/drone/push Build is failing Details
40d37c4aea Fix lint problems
continuous-integration/drone/push Build is passing Details
fecd3bf3e0 Rename functions
continuous-integration/drone/push Build is failing Details
2798efc221 Function renaming
j285he added 1 commit 2021-08-17 17:27:17 -04:00
continuous-integration/drone/push Build is passing Details
5dd258ec86 Merge branch 'main' into feat/events-year
j285he added 1 commit 2021-08-17 17:33:13 -04:00
continuous-integration/drone/push Build is passing Details
408275e8cf Remove temp page
j285he changed title from WIP: Add /events/[year] page to Add /events/[year] page 2021-08-17 17:36:46 -04:00
j285he requested review from a3thakra 2021-08-17 17:36:51 -04:00
a3thakra commented 2021-08-17 21:27:25 -04:00
Owner
Copy Link

Can you add all the events in a separate PR? I can't see the actual changes right now.

Can you add all the events in a separate PR? I can't see the actual changes right now.
j285he added 1 commit 2021-08-18 10:54:19 -04:00
continuous-integration/drone/push Build is failing Details
10449e921e Remove events
j285he added 1 commit 2021-08-18 11:07:17 -04:00
continuous-integration/drone/push Build is passing Details
29f2c3208c Fix build error
j285he commented 2021-08-18 11:12:25 -04:00
Author
Member
Copy Link

Can you add all the events in a separate PR? I can't see the actual changes right now.

OK, see !157. I've added the content/events folder so that I could pass build, and also added content/events/2021 for testing and demonstration purposes.

> Can you add all the events in a separate PR? I can't see the actual changes right now. OK, see !157. I've added the `content/events` folder so that I could pass build, and also added `content/events/2021` for testing and demonstration purposes.
j285he added 1 commit 2021-08-18 11:42:16 -04:00
continuous-integration/drone/push Build is passing Details
50c2f08769 Simplify types
a3thakra commented 2021-08-18 18:53:07 -04:00
Owner
Copy Link

Most comments on #158 apply here too.

Most comments on #158 apply here too.
j285he added 2 commits 2021-08-19 11:22:32 -04:00
continuous-integration/drone/push Build is passing Details
733af0a28a Make consistent with other pages
a3thakra reviewed 2021-08-22 05:26:37 -04:00
pages/events/[year]/year.module.css Outdated
@ -0,0 +2,4 @@
margin: auto;
margin-top: calc(112rem / 16);
margin-bottom: calc(224rem / 16);
width: calc(800rem / 16);
a3thakra commented 2021-08-22 05:26:37 -04:00
Owner
Copy Link

no need, DefaultLayout already handles this.

no need, DefaultLayout already handles this.
j285he marked this conversation as resolved
a3thakra reviewed 2021-08-22 05:27:14 -04:00
pages/events/[year]/year.module.css Outdated
@ -0,0 +1,26 @@
.main {
margin: auto;
a3thakra commented 2021-08-22 05:27:14 -04:00
Owner
Copy Link

no need, just set top and bottom

no need, just set top and bottom
j285he marked this conversation as resolved
a3thakra reviewed 2021-08-22 05:34:41 -04:00
pages/events/[year]/year.module.css Outdated
@ -0,0 +1,26 @@
.main {
margin: auto;
margin-top: calc(112rem / 16);
a3thakra commented 2021-08-22 05:34:41 -04:00
Owner
Copy Link

reduce this for mobile styles

reduce this for mobile styles
j285he commented 2021-08-22 14:48:32 -04:00
Author
Member
Copy Link

I eyeballed with 112rem/48px for desktop/mobile's margin-top. I measured in Figma and I believe it says 157px/70px, however trying those values the spacing seemed off. Let me know if you want that changed.

(oops, also if you get like 12 notifications for this, sorry. I may have spammed the reply button after my wifi flipped out 😣)

I eyeballed with 112rem/48px for desktop/mobile's `margin-top`. I measured in Figma and I believe it says 157px/70px, however trying those values the spacing seemed off. Let me know if you want that changed. (oops, also if you get like 12 notifications for this, sorry. I may have spammed the reply button after my wifi flipped out 😣)
a3thakra commented 2021-08-22 20:50:28 -04:00
Owner
Copy Link

Just 60px for both mobile and desktop should be good

Just 60px for both mobile and desktop should be good
j285he marked this conversation as resolved
a3thakra reviewed 2021-08-22 05:34:48 -04:00
pages/events/[year]/year.module.css Outdated
@ -0,0 +1,26 @@
.main {
margin: auto;
margin-top: calc(112rem / 16);
margin-bottom: calc(224rem / 16);
a3thakra commented 2021-08-22 05:34:48 -04:00
Owner
Copy Link

no need.

no need.
j285he marked this conversation as resolved
a3thakra reviewed 2021-08-22 05:35:44 -04:00
pages/events/[year]/year.module.css Outdated
@ -0,0 +5,4 @@
width: calc(800rem / 16);
}
.heading2 {
a3thakra commented 2021-08-22 05:35:44 -04:00
Owner
Copy Link

no need.

no need.
j285he marked this conversation as resolved
a3thakra reviewed 2021-08-22 05:36:48 -04:00
pages/events/[year]/year.module.css Outdated
@ -0,0 +14,4 @@
color: var(--primary-accent)
}
.links {
a3thakra commented 2021-08-22 05:36:48 -04:00
Owner
Copy Link

Please look at how this is done in news archive and copy from there

Please look at how this is done in news archive and copy from there
j285he marked this conversation as resolved
j285he added 1 commit 2021-08-22 14:46:30 -04:00
continuous-integration/drone/push Build is passing Details
ff8f52e44d Address CSS issues
j285he added 2 commits 2021-08-23 20:13:26 -04:00
continuous-integration/drone/push Build is passing Details
92e7965d84 60px margins
j285he added 1 commit 2021-08-23 22:29:51 -04:00
continuous-integration/drone/push Build is passing Details
4a2e8d522b Remove hr, rename css file
j285he added 1 commit 2021-08-27 18:41:22 -04:00
continuous-integration/drone/push Build is passing Details
a13f48edfe Merge branch 'main' into feat/events-year
a3thakra commented 2021-08-27 19:37:10 -04:00
Owner
Copy Link

Can you delete the .gitkeep files?

Can you delete the .gitkeep files?
a3thakra reviewed 2021-08-27 19:37:43 -04:00
pages/events/[year]/index.module.css Outdated
@ -0,0 +9,4 @@
@media only screen and (max-width: calc(768rem / 16)) {
.main {
margin-top: calc(60rem / 16);
a3thakra commented 2021-08-27 19:37:43 -04:00
Owner
Copy Link

no need

no need
j285he marked this conversation as resolved
a3thakra reviewed 2021-08-27 19:37:59 -04:00
pages/events/[year]/index.module.css
@ -0,0 +4,4 @@
.main > h2 {
padding-bottom: 1rem;
border-bottom: 1px solid var(--primary-heading);
a3thakra commented 2021-08-27 19:37:59 -04:00
Owner
Copy Link

calc(1rem / 16)

calc(1rem / 16)
j285he marked this conversation as resolved
a3thakra commented 2021-08-27 19:42:52 -04:00
Owner
Copy Link

LGTM after the 3 comments above!

LGTM after the 3 comments above!
j285he added 1 commit 2021-08-27 21:43:03 -04:00
continuous-integration/drone/push Build is passing Details
59b63a3d2f PR fixes
a3thakra approved these changes 2021-08-27 21:44:10 -04:00
j285he merged commit 656524eee7 into main 2021-08-27 21:49:26 -04:00
j285he deleted branch feat/events-year 2021-08-27 21:49:35 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
a3thakra
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#151
No description provided.
Delete Branch "feat/events-year"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?