Add decoration to the bubble component #152

Merged
a3thakra merged 4 commits from adi-bubble into main 1 year ago
Collaborator

Closes #87

Closes #87
a3thakra added 1 commit 1 year ago
ba274c262e Add decoration to the bubble component
a3thakra requested review from l42luo 1 year ago
a3thakra reviewed 1 year ago
}
.bubble {
--border-radius: calc(5000rem / 16);
Poster
Collaborator

A massive border radius ensures the circularness of the border for all elements up to 10000px in height, that's more than enough.

A massive border radius ensures the circularness of the border for all elements up to 10000px in height, that's more than enough.
a3thakra reviewed 1 year ago
<div className={styles.bubble}>
<DefaultLayout>{props.children}</DefaultLayout>
<div className={styles.container}>
<div className={styles.bubble} aria-hidden>
Poster
Collaborator

Since this is purely visual, we hide it from screen readers.

Since this is purely visual, we hide it from screen readers.
a3thakra reviewed 1 year ago
background-color: var(--primary-accent-light);
}
@media only screen and (min-width: calc(1350rem / 16)) {
Poster
Collaborator

Using min-width instead of max-width here so I don't have to unset a lot of properties.

Using min-width instead of max-width here so I don't have to `unset` a lot of properties.
l42luo added 1 commit 1 year ago
ea936c4b5b Merge branch 'main' into adi-bubble
a3thakra force-pushed adi-bubble from ea936c4b5b to ba274c262e 1 year ago
l42luo added 2 commits 1 year ago
ea936c4b5b Merge branch 'main' into adi-bubble
792476421e added padding to bottom of page
l42luo added 1 commit 1 year ago
4c2c6f3da7 increased bottom margin value of page
l42luo approved these changes 1 year ago
l42luo left a comment
Collaborator

Looks good!

Looks good!
a3thakra merged commit 41fdadb229 into main 1 year ago
a3thakra deleted branch adi-bubble 1 year ago

Reviewers

l42luo approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 41fdadb229.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#152
Loading…
There is no content yet.