Add decoration to the bubble component

Conversation 0 Commits 4 Files Changed 4

a3thakra commented 2 years ago

Collaborator

Closes #87

a3thakra added 1 commit 2 years ago

ba274c262e Add decoration to the bubble component

a3thakra requested review from l42luo 2 years ago

a3thakra reviewed 2 years ago

components/Bubble.module.css

													
					}
				
					.bubble {
				
					  --border-radius: calc(5000rem / 16);

a3thakra commented 2 years ago

Poster

Collaborator

A massive border radius ensures the circularness of the border for all elements up to 10000px in height, that's more than enough.

a3thakra reviewed 2 years ago

components/Bubble.tsx

													
					    <div className={styles.bubble}>
				
					      <DefaultLayout>{props.children}</DefaultLayout>
				
					    <div className={styles.container}>
				
					      <div className={styles.bubble} aria-hidden>

a3thakra commented 2 years ago

Poster

Collaborator

Since this is purely visual, we hide it from screen readers.

a3thakra reviewed 2 years ago

components/Bubble.module.css

													
					  background-color: var(--primary-accent-light);
				
					}
				
					@media only screen and (min-width: calc(1350rem / 16)) {

a3thakra commented 2 years ago

Poster

Collaborator

Using min-width instead of max-width here so I don't have to unset a lot of properties.

l42luo added 1 commit 2 years ago

ea936c4b5b Merge branch 'main' into adi-bubble

a3thakra force-pushed adi-bubble from ea936c4b5b to ba274c262e 2 years ago

l42luo added 2 commits 2 years ago

ea936c4b5b Merge branch 'main' into adi-bubble

792476421e added padding to bottom of page

l42luo added 1 commit 2 years ago

4c2c6f3da7 increased bottom margin value of page

l42luo approved these changes 2 years ago

l42luo left a comment

Collaborator

Looks good!

a3thakra merged commit 41fdadb229 into main 2 years ago

a3thakra referenced this issue from a commit 2 years ago

Add decoration to the bubble component (#152)

a3thakra deleted branch adi-bubble 2 years ago

Reviewers

l42luo approved these changes 2 years ago

continuous-integration/drone/push Build is passing

Details

The pull request has been merged as 41fdadb229.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#152

Add decoration to the bubble component #152

Reviewers