Add decoration to the bubble component #152

Merged
a3thakra merged 4 commits from adi-bubble into main 2021-08-22 22:40:56 -04:00
Owner

Closes #87

Closes #87
a3thakra added 1 commit 2021-08-17 21:28:44 -04:00
continuous-integration/drone/push Build is passing Details
ba274c262e
Add decoration to the bubble component
a3thakra requested review from l42luo 2021-08-17 21:28:52 -04:00
a3thakra reviewed 2021-08-18 19:27:09 -04:00
@ -3,0 +5,4 @@
}
.bubble {
--border-radius: calc(5000rem / 16);
Author
Owner

A massive border radius ensures the circularness of the border for all elements up to 10000px in height, that's more than enough.

A massive border radius ensures the circularness of the border for all elements up to 10000px in height, that's more than enough.
a3thakra reviewed 2021-08-18 19:27:40 -04:00
@ -9,2 +11,2 @@
<div className={styles.bubble}>
<DefaultLayout>{props.children}</DefaultLayout>
<div className={styles.container}>
<div className={styles.bubble} aria-hidden>
Author
Owner

Since this is purely visual, we hide it from screen readers.

Since this is purely visual, we hide it from screen readers.
a3thakra reviewed 2021-08-18 19:28:27 -04:00
@ -6,2 +40,4 @@
background-color: var(--primary-accent-light);
}
@media only screen and (min-width: calc(1350rem / 16)) {
Author
Owner

Using min-width instead of max-width here so I don't have to unset a lot of properties.

Using min-width instead of max-width here so I don't have to `unset` a lot of properties.
l42luo added 1 commit 2021-08-22 21:41:50 -04:00
continuous-integration/drone/push Build is passing Details
ea936c4b5b
Merge branch 'main' into adi-bubble
a3thakra force-pushed adi-bubble from ea936c4b5b to ba274c262e 2021-08-22 21:49:00 -04:00 Compare
l42luo added 2 commits 2021-08-22 22:27:04 -04:00
continuous-integration/drone/push Build is passing Details
ea936c4b5b
Merge branch 'main' into adi-bubble
continuous-integration/drone/push Build is passing Details
792476421e
added padding to bottom of page
l42luo added 1 commit 2021-08-22 22:36:30 -04:00
continuous-integration/drone/push Build is passing Details
4c2c6f3da7
increased bottom margin value of page
l42luo approved these changes 2021-08-22 22:40:13 -04:00
l42luo left a comment
Member

Looks good!

Looks good!
a3thakra merged commit 41fdadb229 into main 2021-08-22 22:40:56 -04:00
a3thakra deleted branch adi-bubble 2021-08-22 22:41:04 -04:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#152
No description provided.