www/www-new
16
3
Fork 11
Code Issues 60 Pull Requests 48 Projects Releases Wiki Activity

Add /events page #159

Merged
j285he merged 45 commits from feat/events-page into main 2021-08-27 18:37:44 -04:00
Conversation 4 Commits 45 Files Changed 3 +29 -6
j285he commented 2021-08-18 18:00:21 -04:00
Member
Copy Link

Closes #111

Blocked by !158

Closes #111 Blocked by !158
j285he added 38 commits 2021-08-18 18:00:22 -04:00
Add lib file
All checks were successful
continuous-integration/drone/push Build is passing
Details
b733acd156
Fix type error
All checks were successful
continuous-integration/drone/push Build is passing
Details
bfcbf5c687
Merge branch 'main' into feat/events-lib
All checks were successful
continuous-integration/drone/push Build is passing
Details
9f7d40b426
Correct Dirents
All checks were successful
continuous-integration/drone/push Build is passing
Details
c39b0036ad
Fixes for dirents
Some checks failed
continuous-integration/drone/push Build is failing
Details
590b2554c0
ESLint fixes
All checks were successful
continuous-integration/drone/push Build is passing
Details
d237621d14
Add sorting
All checks were successful
continuous-integration/drone/push Build is passing
Details
3a697c09c0
Merge branch 'feat/events-lib' of https://git.csclub.uwaterloo.ca/www/www-new into feat/events-lib
All checks were successful
continuous-integration/drone/push Build is passing
Details
057c2c2a03
Remove unneeded dirent conversion
All checks were successful
continuous-integration/drone/push Build is passing
Details
b32fd53d95
Fix lint problems
Some checks failed
continuous-integration/drone/push Build is failing
Details
40d37c4aea
Rename functions
All checks were successful
continuous-integration/drone/push Build is passing
Details
fecd3bf3e0
Function renaming
Some checks failed
continuous-integration/drone/push Build is failing
Details
2798efc221
Merge branch 'main' into feat/events-year
All checks were successful
continuous-integration/drone/push Build is passing
Details
5dd258ec86
Remove temp page
All checks were successful
continuous-integration/drone/push Build is passing
Details
408275e8cf
Remove events
Some checks failed
continuous-integration/drone/push Build is failing
Details
10449e921e
Add events
All checks were successful
continuous-integration/drone/push Build is passing
Details
6f429d20bf
Fix build error
All checks were successful
continuous-integration/drone/push Build is passing
Details
29f2c3208c
Simplify types
All checks were successful
continuous-integration/drone/push Build is passing
Details
50c2f08769
Fix for Fall 2018
All checks were successful
continuous-integration/drone/push Build is passing
Details
a23a10d8e4
Add futureEvents pastEvents EventCard logic
Some checks failed
continuous-integration/drone/push Build is failing
Details
416e027ebb
Create events/index.tsx
Some checks failed
continuous-integration/drone/push Build is failing
Details
e971c85afc
Add time detection for current time
All checks were successful
continuous-integration/drone/push Build is passing
Details
5631217681
Remove events
All checks were successful
continuous-integration/drone/push Build is passing
Details
3e61407643
Add index.tsx
Some checks failed
continuous-integration/drone/push Build is failing
Details
03197ee048
Remove events
Some checks failed
continuous-integration/drone/push Build is failing
Details
2b88ea2f25
j285he added the
Blocked
 label 2021-08-18 18:00:29 -04:00
j285he requested review from a3thakra 2021-08-18 18:00:55 -04:00
j285he added 2 commits 2021-08-19 11:14:13 -04:00
Add types
Some checks failed
continuous-integration/drone/push Build is failing
Details
9a24bf3076
j285he reviewed 2021-08-23 23:33:01 -04:00
pages/events/index.tsx Outdated
@ -0,0 +1,38 @@
import { GetStaticProps } from "next";
import Term, {
getStaticProps as termGetStaticProps,
j285he commented 2021-08-23 23:32:23 -04:00
Author
Member
Copy Link

import getCurrentTerm, getProps

import getCurrentTerm, getProps
j285he marked this conversation as resolved
a3thakra removed the
Blocked
 label 2021-08-27 17:52:47 -04:00
a3thakra added 1 commit 2021-08-27 17:54:09 -04:00
Merge remote-tracking branch 'origin/main' into feat/events-page
All checks were successful
continuous-integration/drone/push Build is passing
Details
f3d9a08a73
j285he added 3 commits 2021-08-27 17:57:45 -04:00
j285he commented 2021-08-27 18:00:39 -04:00
Author
Member
Copy Link

Small issue -- when on /events, clicking the current term (e.g. Spring 2021) directs you to /events/2021/spring and so the shapes in the background change.

It's not a big deal but it's a little strange. Should this be an issue?

Small issue -- when on `/events`, clicking the current term (e.g. Spring 2021) directs you to `/events/2021/spring` and so the shapes in the background change. It's not a big deal but it's a little strange. Should this be an issue?
a3thakra added 1 commit 2021-08-27 18:13:57 -04:00
PR feedback
All checks were successful
continuous-integration/drone/push Build is passing
Details
7ceffc3ba0
a3thakra commented 2021-08-27 18:15:44 -04:00
Owner
Copy Link

It's not a big deal but it's a little strange. Should this be an issue?

It's fine!

> It's not a big deal but it's a little strange. Should this be an issue? It's fine!
👍 1
a3thakra approved these changes 2021-08-27 18:15:56 -04:00
j285he merged commit 5933dd03b8 into main 2021-08-27 18:37:44 -04:00
j285he referenced this issue from a commit 2021-08-27 18:37:44 -04:00
Add /events page (#159)
j285he deleted branch feat/events-page 2021-08-27 18:39:16 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
a3thakra
Labels
Clear labels
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: www/www-new#159
No description provided.
Delete Branch "feat/events-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?