www
/
www-new
12
2
Fork 3
Code Issues 58 Pull Requests 31 Projects Releases Wiki Activity
Labels Milestones

Advice + Internships Page #161

Merged
l42luo merged 9 commits from feat/advice-page into main 2 years ago
Conversation 2 Commits 9 Files Changed 13
l42luo commented 2 years ago
Collaborator

Closes #140
Closes #141

Closes #140 Closes #141
l42luo added 2 commits 2 years ago
continuous-integration/drone/push Build is failing
Details
b352aa64ce initial commit for advice page
l42luo added 1 commit 2 years ago
l42luo changed title from WIP: Advice Page to WIP: Advice + Internships Page 2 years ago
l42luo added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
c66fe32e9c simplified colouring current advice subheading
l42luo changed title from WIP: Advice + Internships Page to Advice + Internships Page 2 years ago
l42luo added 1 commit 2 years ago
a3thakra reviewed 2 years ago
pages/resources/advice/academic.tsx Outdated
import { Advice } from "./coop";
export default function CoopAdvice() {
a3thakra commented 2 years ago
Collaborator

AcademicAdvice

AcademicAdvice
l42luo marked this conversation as resolved
a3thakra reviewed 2 years ago
pages/resources/advice/misc.tsx Outdated
import { Advice } from "./coop";
export default function CoopAdvice() {
a3thakra commented 2 years ago
Collaborator

MiscAdvice

MiscAdvice
l42luo marked this conversation as resolved
a3thakra commented 2 years ago
Collaborator
  • Mobile view is a bit weird.
  • The <hr />s look a bit weird, can you make a custom <hr /> component under components with better styles, and then use that in _app.tsx so that it's changed to our custom component wherever we're using an hr?
- Mobile view is a bit weird. - The `<hr />`s look a bit weird, can you make a custom `<hr />` component under components with better styles, and then use that in `_app.tsx` so that it's changed to our custom component wherever we're using an hr?
2.png
63 KiB
1.png
112 KiB
l42luo added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
c72bc42053 added mobile styling
l42luo added 2 commits 2 years ago
continuous-integration/drone/push Build is passing
Details
e8c1dcdf2a added custom hr component
l42luo added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
6ac008a3b7 Merge branch 'main' into feat/advice-page
a3thakra commented 2 years ago
Collaborator

LGTM, ship it.

LGTM, ship it.
a3thakra approved these changes 2 years ago
l42luo merged commit 09c704c94c into main 2 years ago
l42luo referenced this issue from a commit 2 years ago
Advice + Internships Page (#161)
l42luo deleted branch feat/advice-page 2 years ago

Reviewers

a3thakra approved these changes 2 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 09c704c94c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
a3thakra
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#161
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'feat/advice-page'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes