Add events archive #187

Merged
a3thakra merged 2 commits from adi-events-archive into main 1 year ago
Collaborator

Closes #117

Closes #117
a3thakra requested review from j285he 1 year ago
j285he approved these changes 1 year ago
j285he left a comment
Collaborator

Looks great!

Looks great!
import React from "react";
Collaborator

After the title, there's a missing border-bottom as per Figma

After the title, there's a missing border-bottom as per Figma
Collaborator

Also inspect element says the title is h1, should be h2

Also inspect element says the title is h1, should be h2
Poster
Collaborator

It should be h1 because it's the only heading of the page, so semantically it makes sense for it to be h1

It should be h1 because it's the only heading of the page, so semantically it makes sense for it to be h1
a3thakra marked this conversation as resolved
import React from "react";
Collaborator

We have been using 60px for margin-bottom in [term], but I see 40px for this component. Maybe we change one or the other for consistency?

We have been using 60px for margin-bottom in [term], but I see 40px for this component. Maybe we change one or the other for consistency?
Poster
Collaborator

The line height is a lot more (3 instead of 1.5ish) than other sections, so imo 40px actually looks a lot like 60px. I tried to make it 60px and that was a lot.

The line height is a lot more (3 instead of 1.5ish) than other sections, so imo 40px actually looks a lot like 60px. I tried to make it 60px and that was a lot.
a3thakra marked this conversation as resolved
: defaultGetShapesConfig(width, height);
}) as GetShapesConfig;
function capitalize(str: string) {
Collaborator

We're using this function a lot. Maybe it's worth putting it into lib?

We're using this function a lot. Maybe it's worth putting it into lib?
a3thakra marked this conversation as resolved
a3thakra force-pushed adi-events-archive from 94c44b112d to 98717fafbc 1 year ago
a3thakra merged commit c31571f745 into main 1 year ago
a3thakra referenced this issue from a commit 1 year ago
a3thakra deleted branch adi-events-archive 1 year ago

Reviewers

j285he approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as c31571f745.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#187
Loading…
There is no content yet.