Add events archive #187
No reviewers
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#187
Loading…
Reference in New Issue
No description provided.
Delete Branch "adi-events-archive"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #117
Looks great!
@ -0,0 +1,47 @@
import React from "react";
After the title, there's a missing border-bottom as per Figma
Also inspect element says the title is h1, should be h2
It should be h1 because it's the only heading of the page, so semantically it makes sense for it to be h1
@ -0,0 +1,47 @@
import React from "react";
We have been using 60px for margin-bottom in [term], but I see 40px for this component. Maybe we change one or the other for consistency?
The line height is a lot more (3 instead of 1.5ish) than other sections, so imo 40px actually looks a lot like 60px. I tried to make it 60px and that was a lot.
@ -0,0 +42,4 @@
: defaultGetShapesConfig(width, height);
}) as GetShapesConfig;
function capitalize(str: string) {
We're using this function a lot. Maybe it's worth putting it into lib?
94c44b112d
to98717fafbc