Add mobile styles to the event card #190
No reviewers
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#190
Loading…
Reference in New Issue
No description provided.
Delete Branch "adi-mobile-events-card"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
closes #160
closes #154
https://csclub.uwaterloo.ca/~a3thakra/csc/adi-mobile-events-card/
@ -35,0 +54,4 @@
className={[
styles.content,
showDescription ? styles.mobileShowDescriptionContent : "",
].join(" ")}
Would something like this work? (I don't know if it's any cleaner/better than what we already have though...)
it kinda results in a lot of nested ${} which i kinda dont like lol
the only clean way would be to use the classnames library 🤷♂️
@ -3,1 +5,4 @@
export function Image(props: ImgHTMLAttributes<HTMLImageElement>) {
const classes = props.className
? [props.className, styles.image]
: [styles.image];
Similar to line 57 of
components/EventCard.tsx
, not sure if the suggestion there would be helpful here or not.same as above
The mobile EventCard looks a little funny on iPad...