Add mobile styles to the event card #190

Merged
a3thakra merged 3 commits from adi-mobile-events-card into main 1 year ago
Collaborator
closes #160 closes #154 https://csclub.uwaterloo.ca/~a3thakra/csc/adi-mobile-events-card/
a3thakra added 2 commits 1 year ago
0008d9e914 Misc css fixes
8ed72bf61b Mobile event card
a258wang reviewed 1 year ago
className={[
styles.content,
showDescription ? styles.mobileShowDescriptionContent : "",
].join(" ")}
Owner

Would something like this work? (I don't know if it's any cleaner/better than what we already have though...)

className=`${styles.content} ${showDescription ? styles.mobileShowDescriptionContent : ""}`
Would something like this work? (I don't know if it's any cleaner/better than what we already have though...) ``` className=`${styles.content} ${showDescription ? styles.mobileShowDescriptionContent : ""}` ```
Poster
Collaborator

it kinda results in a lot of nested ${} which i kinda dont like lol

it kinda results in a lot of nested ${} which i kinda dont like lol
Poster
Collaborator

the only clean way would be to use the classnames library 🤷‍♂️

the only clean way would be to use the classnames library 🤷‍♂️
a3thakra marked this conversation as resolved
a258wang reviewed 1 year ago
export function Image(props: ImgHTMLAttributes<HTMLImageElement>) {
const classes = props.className
? [props.className, styles.image]
: [styles.image];
Owner

Similar to line 57 of components/EventCard.tsx, not sure if the suggestion there would be helpful here or not.

Similar to line 57 of `components/EventCard.tsx`, not sure if the suggestion there would be helpful here or not.
Poster
Collaborator

same as above

same as above
a3thakra marked this conversation as resolved
Owner

The mobile EventCard looks a little funny on iPad...

The mobile EventCard looks a little funny on iPad...
a3thakra added 1 commit 1 year ago
c6df3604e4 Restrict poster width to 300px on mobile screens
a3thakra merged commit 6b88cf308b into main 1 year ago
a3thakra deleted branch adi-mobile-events-card 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 6b88cf308b.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#190
Loading…
There is no content yet.