Add title to all pages #222

Merged
a3thakra merged 10 commits from adi-page-titles into main 1 year ago
Collaborator

Closes #221

Go to https://csclub.uwaterloo.ca/~a3thakra/csc/adi-page-titles and make sure that all pages have a title (you can hover over the tab)

Closes #221 Go to https://csclub.uwaterloo.ca/~a3thakra/csc/adi-page-titles and make sure that all pages have a title (you can hover over the tab)
a3thakra added 1 commit 1 year ago
f7ea4d9184 Add title to all pages
a3thakra requested review from j285he 1 year ago
a3thakra requested review from l42luo 1 year ago
a3thakra added 1 commit 1 year ago
ac8a14cd14 Fix import path
a3thakra added 1 commit 1 year ago
76d0c30a3e fixup! Fix import path
Owner

It looks like all the pages have titles! Here are some suggestions, based entirely on my personal opinion (so feel free to disagree):

  1. I'm personally not a huge fan of the way the string UWaterloo looks. According to our Constitution (and also the old website), we are the Computer Science Club of the University of Waterloo - is there any reason why we don't want to use this in the title? (I recognize that it is pretty long.)
  2. For the sections of the Constitution, have we considered hiding the section numbers in the title? eg. Purpose - Constitution - ... instead of 2. Purpose - Constitution - ... (If this would take too much effort to implement, then feel free to disregard it.)
  3. For the "Additional Advice" Advice page, the title says Misc Advice, which feels a bit incongruous.
  4. For the events/[year]/[term]/[event] pages (which I think are mostly unused at this point), have we considered including the term and year in the title as well? eg. Speed-Friending - Spring 2021 - ... instead of just Speed-Friending - ... (This could be helpful since there are occasionally events that have the same name, but considering that these pages are basically unused, it might not be worth the effort to implement this.)

TL;DR, all the page have descriptive titles, Amy just has a bunch of nitpicks

It looks like all the pages have titles! Here are some suggestions, based entirely on my personal opinion (so feel free to disagree): 1. I'm personally not a huge fan of the way the string `UWaterloo` looks. According to our Constitution (and also the old website), we are the `Computer Science Club of the University of Waterloo` - is there any reason why we don't want to use this in the title? (I recognize that it is pretty long.) 2. For the sections of the Constitution, have we considered hiding the section numbers in the title? eg. `Purpose - Constitution - ...` instead of `2. Purpose - Constitution - ...` (If this would take too much effort to implement, then feel free to disregard it.) 3. For the "Additional Advice" Advice page, the title says `Misc Advice`, which feels a bit incongruous. 4. For the events/\[year]/\[term]/\[event] pages (which I think are mostly unused at this point), have we considered including the term and year in the title as well? eg. `Speed-Friending - Spring 2021 - ...` instead of just `Speed-Friending - ...` (This could be helpful since there are occasionally events that have the same name, but considering that these pages are basically unused, it might not be worth the effort to implement this.) - eg. [Speed-Friending - Spring 2021](https://csclub.uwaterloo.ca/~a3thakra/csc/adi-page-titles/events/2021/spring/Speed-Friending/) vs. [Speed-Friending - Winter 2021](https://csclub.uwaterloo.ca/~a3thakra/csc/adi-page-titles/events/2021/winter/Speed-Friending/) TL;DR, all the page have descriptive titles, Amy just has a bunch of nitpicks
a3thakra added 5 commits 1 year ago
Poster
Collaborator

I'm personally not a huge fan of the way the string UWaterloo looks. According to our Constitution (and also the old website), we are the Computer Science Club of the University of Waterloo - is there any reason why we don't want to use this in the title? (I recognize that it is pretty long.)

Yeah, it's really long, that's the only reason. The old website might not be a good example as it's very inconsistent. (checkout other pages: events, services, etc) I am open to other ideas tho - How about "CSC - University of Waterloo" or "Computer Science Club - UofW" or something like that. Note that this is also an opinion, so if most people think that something else is better, or that we should go with "Computer Science Club of the University of Waterloo" anyway, I would be fine with that.

For the sections of the Constitution, have we considered hiding the section numbers in the title? eg. Purpose - Constitution - ... instead of 2. Purpose - Constitution - ... (If this would take too much effort to implement, then feel free to disregard it.)

Implemented

For the "Additional Advice" Advice page, the title says Misc Advice, which feels a bit incongruous.

Fixed

For the events/[year]/[term]/[event] pages (which I think are mostly unused at this point), have we considered including the term and year in the title as well? eg. Speed-Friending - Spring 2021 - ... instead of just Speed-Friending - ... (This could be helpful since there are occasionally events that have the same name, but considering that these pages are basically unused, it might not be worth the effort to implement this.)

Done

> I'm personally not a huge fan of the way the string UWaterloo looks. According to our Constitution (and also the old website), we are the Computer Science Club of the University of Waterloo - is there any reason why we don't want to use this in the title? (I recognize that it is pretty long.) Yeah, it's really long, that's the only reason. The old website might not be a good example as it's very inconsistent. (checkout other pages: events, services, etc) I am open to other ideas tho - How about "CSC - University of Waterloo" or "Computer Science Club - UofW" or something like that. Note that this is also an opinion, so if most people think that something else is better, or that we should go with "Computer Science Club of the University of Waterloo" anyway, I would be fine with that. > For the sections of the Constitution, have we considered hiding the section numbers in the title? eg. Purpose - Constitution - ... instead of 2. Purpose - Constitution - ... (If this would take too much effort to implement, then feel free to disregard it.) Implemented > For the "Additional Advice" Advice page, the title says Misc Advice, which feels a bit incongruous. Fixed > For the events/[year]/[term]/[event] pages (which I think are mostly unused at this point), have we considered including the term and year in the title as well? eg. Speed-Friending - Spring 2021 - ... instead of just Speed-Friending - ... (This could be helpful since there are occasionally events that have the same name, but considering that these pages are basically unused, it might not be worth the effort to implement this.) Done
a3thakra added 1 commit 1 year ago
a33a45688e Fix build
j285he approved these changes 1 year ago
j285he left a comment
Collaborator

Looks great! I am a fan of "CSC - University of Waterloo", but maybe design also has ideas?

Looks great! I am a fan of "CSC - University of Waterloo", but maybe design also has ideas?
a3thakra added 1 commit 1 year ago
0c0be1e9f1 Change base to 'CSC - University of Waterloo'
a3thakra merged commit 30102822da into main 1 year ago
a3thakra referenced this issue from a commit 1 year ago
a3thakra deleted branch adi-page-titles 1 year ago

Reviewers

l42luo was requested for review 1 year ago
j285he approved these changes 1 year ago
continuous-integration/drone/push Build was killed
The pull request has been merged as 30102822da.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#222
Loading…
There is no content yet.