Fix title inconsistencies #229
No reviewers
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#229
Loading…
Reference in New Issue
No description provided.
Delete Branch "jared-fix-headers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #212.
Fix header inconsistenciesto Fix title inconsistencies@ -4,1 +4,4 @@
.page > h1 {
padding-bottom: calc(16rem / 16);
border-bottom: 1px solid var(--primary-heading);
calc(1rem / 16) solid ...
just 1 nit, lgtm otherwise
@ -67,3 +67,3 @@
{hasFutureEvents && (
<>
<h2>Upcoming Events</h2>
<h1>Upcoming Events</h1>
actually can you put this in a section tag? technically, there are two h1's on the page. But a page cannot have 2 h1s. If we look closely, we have two sections on this page, each with it's own h1. I think that would make this nicer. (in terms of semantics)
I currently have Past Events as an h2. Should I make it an h1?
Yes, semantically speaking, each page should have exactly one h1, and then 0 or more h2's
when i say h1, i mean the h1 tag. you can style it as you wish.
Ah okay. Also for the original comment, I don't see two h1's on the same page. It's just either
Upcoming Events
orEvents Archive:
. Am I going crazy?"Upcoming events" and "Past events" should both be
h1
s enclosed within asection
. So the final markup would look something like this:Ahhhhhh sorry I see what you mean, thanks!
Although what are your thoughts on the styling? I think having h2 on Past Events makes the user more drawn towards current upcoming events, instead of having two blocky h1's competing for attention, but idk
As I said earlier, they should be h1 tags, you can style them like h2s to match figma 😉
OK, thank you! Since Figma's title sizes differ a bit from ours, let me know if I should change the size of Past Events or not
create two sections on the events/term/index page.
LGTM