Fix title inconsistencies #229

Merged
j285he merged 5 commits from jared-fix-headers into main 1 year ago
j285he commented 1 year ago
Collaborator

Closes #212.

Closes #212.
j285he added 1 commit 1 year ago
b9f0d81c48 Fix inconsistencies
j285he added 1 commit 1 year ago
aba9a1bb4c Separate the issues
j285he changed title from Fix header inconsistencies to Fix title inconsistencies 1 year ago
a3thakra reviewed 1 year ago
.page > h1 {
padding-bottom: calc(16rem / 16);
border-bottom: 1px solid var(--primary-heading);
Collaborator

calc(1rem / 16) solid ...

calc(1rem / 16) solid ...
j285he marked this conversation as resolved
a3thakra approved these changes 1 year ago
Dismissed
a3thakra left a comment
Collaborator

just 1 nit, lgtm otherwise

just 1 nit, lgtm otherwise
j285he added 1 commit 1 year ago
e491a4076d Pesky pixels
a3thakra reviewed 1 year ago
{hasFutureEvents && (
<>
<h2>Upcoming Events</h2>
<h1>Upcoming Events</h1>
Collaborator

actually can you put this in a section tag? technically, there are two h1's on the page. But a page cannot have 2 h1s. If we look closely, we have two sections on this page, each with it's own h1. I think that would make this nicer. (in terms of semantics)

actually can you put this in a section tag? technically, there are two h1's on the page. But a page cannot have 2 h1s. If we look closely, we have two sections on this page, each with it's own h1. I think that would make this nicer. (in terms of semantics)
Poster
Collaborator

I currently have Past Events as an h2. Should I make it an h1?

I currently have Past Events as an h2. Should I make it an h1?
Collaborator

Yes, semantically speaking, each page should have exactly one h1, and then 0 or more h2's

Yes, semantically speaking, each page should have exactly one h1, and then 0 or more h2's
Collaborator

when i say h1, i mean the h1 tag. you can style it as you wish.

when i say h1, i mean the h1 tag. you can style it as you wish.
Poster
Collaborator

Ah okay. Also for the original comment, I don't see two h1's on the same page. It's just either Upcoming Events or Events Archive:. Am I going crazy?

Ah okay. Also for the original comment, I don't see two h1's on the same page. It's just either `Upcoming Events` or `Events Archive:`. Am I going crazy?
Collaborator

"Upcoming events" and "Past events" should both be h1s enclosed within a section. So the final markup would look something like this:

<section>
    <h1>Upcoming events</h1>
    {events.map(...)}
</section>
<section>
    <h1>Past events</h1>
    {events.map(...)}
</section>
"Upcoming events" and "Past events" should both be `h1`s enclosed within a `section`. So the final markup would look something like this: ```html <section> <h1>Upcoming events</h1> {events.map(...)} </section> <section> <h1>Past events</h1> {events.map(...)} </section> ```
Poster
Collaborator

Ahhhhhh sorry I see what you mean, thanks!

Although what are your thoughts on the styling? I think having h2 on Past Events makes the user more drawn towards current upcoming events, instead of having two blocky h1's competing for attention, but idk

Ahhhhhh sorry I see what you mean, thanks! Although what are your thoughts on the styling? I think having h2 on Past Events makes the user more drawn towards current upcoming events, instead of having two blocky h1's competing for attention, but idk
Collaborator

As I said earlier, they should be h1 tags, you can style them like h2s to match figma 😉

As I said earlier, they should be h1 tags, you can style them like h2s to match figma 😉
Poster
Collaborator

OK, thank you! Since Figma's title sizes differ a bit from ours, let me know if I should change the size of Past Events or not

OK, thank you! Since Figma's title sizes differ a bit from ours, let me know if I should change the size of Past Events or not
a3thakra dismissed a3thakra’s review 1 year ago
Reason:

create two sections on the events/term/index page.

j285he added 1 commit 1 year ago
87b5390a50 Add sections
a3thakra approved these changes 1 year ago
a3thakra left a comment
Collaborator

LGTM

LGTM
j285he added 1 commit 1 year ago
30a0423adc Merge main
j285he merged commit 485230c95a into main 1 year ago
j285he referenced this issue from a commit 1 year ago
j285he deleted branch jared-fix-headers 1 year ago

Reviewers

a3thakra approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 485230c95a.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#229
Loading…
There is no content yet.