Fix mobile header #231
No reviewers
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#231
Loading…
Reference in New Issue
No description provided.
Delete Branch "jared-fix-mobile-header"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #210
Some problems:
I did not use our standard 768px mobile breakpoint because this implementation didn't look very good in tablet.
Everything still looks super left-aligned on Mobile L view, so maybe we want a different design here.
Also for some reason the
max-width: 425px
media query doesn't apply styles when the width is 425px??oh, i didn't mean to do that, my bad 🙈
Sorry for closing this Jared, I just created a new PR #232 :)
wait I can reopen PRs, I'll close #232 🤦 🤦 IM SO SORRY LOL
I think it's much better if we make the following changes instead of the ones in this PR:
With this we dont need special mobile styles, and it doesn't break the terms apart.