Fix mobile header #231

Merged
j285he merged 3 commits from jared-fix-mobile-header into main 1 year ago
j285he commented 1 year ago
Collaborator

Closes #210

Closes #210
j285he added 1 commit 1 year ago
6946a32f45 Fix mobile header
Poster
Collaborator

Some problems:

I did not use our standard 768px mobile breakpoint because this implementation didn't look very good in tablet.

Everything still looks super left-aligned on Mobile L view, so maybe we want a different design here.

Also for some reason the max-width: 425px media query doesn't apply styles when the width is 425px??

Some problems: I did not use our standard 768px mobile breakpoint because this implementation didn't look very good in tablet. Everything still looks super left-aligned on Mobile L view, so maybe we want a different design here. Also for some reason the `max-width: 425px` media query doesn't apply styles when the width is 425px??
a3thakra closed this pull request 1 year ago
Collaborator

oh, i didn't mean to do that, my bad 🙈

oh, i didn't mean to do that, my bad 🙈
Collaborator

Sorry for closing this Jared, I just created a new PR #232 :)

Sorry for closing this Jared, I just created a new PR #232 :)
Collaborator

wait I can reopen PRs, I'll close #232 🤦 🤦 IM SO SORRY LOL

wait I can reopen PRs, I'll close #232 🤦 🤦 IM SO SORRY LOL
a3thakra reopened this pull request 1 year ago
j285he requested review from a3thakra 1 year ago
Collaborator

I think it's much better if we make the following changes instead of the ones in this PR:

.header {
	display: flex;
    flex-wrap: wrap;
}

.header a {
	margin-right: 1rem;
}

With this we dont need special mobile styles, and it doesn't break the terms apart.

I think it's much better if we make the following changes instead of the ones in this PR: ```css .header { display: flex; flex-wrap: wrap; } .header a { margin-right: 1rem; } ``` With this we dont need special mobile styles, and it doesn't break the terms apart.
j285he added 1 commit 1 year ago
4b5f111a1e Change styles
j285he added 1 commit 1 year ago
c5bb9aa93e Remove comment
a3thakra approved these changes 1 year ago
j285he merged commit c0c2420ee6 into main 1 year ago
j285he referenced this issue from a commit 1 year ago
j285he deleted branch jared-fix-mobile-header 1 year ago

Reviewers

a3thakra approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as c0c2420ee6.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#231
Loading…
There is no content yet.