Meet the Team: fix Team Member Card bug #241

Closed
b38peng wants to merge 35 commits from feat/meet-the-team-page into main
b38peng commented 1 year ago
Collaborator

Closes #213
Closes #214

  • fixed close button not showing
  • added height and scrolling to team member card

To do:

  • fix extra spacing at bottom of popup #242
    • this is due to height being specified in order to use overflow: scroll on desktop

image

Closes #213 Closes #214 - fixed close button not showing - added height and scrolling to team member card To do: - fix extra spacing at bottom of popup #242 - this is due to height being specified in order to use `overflow: scroll` on desktop ![image](/attachments/71f1e1da-4f1a-4c77-86f3-c019a7c2c1dd)
b38peng added 32 commits 1 year ago
e2053e62b1 mobile exec popup
d296fe2d7b mobile team member card
f9345330c1 minor cleanup
422da398f8 added codey
935c591a38 reset settings
9964e54d69 our supporters margin fix
da4742ba81 pr comment fixes
80cb6e3897 generate img path
972b7f4200 dynamic image urls + animation
aa47644d41 pr fixes yay
29477ccb4b lint fix
1b0655c0c4 fix
8bdbc0f026 bug fix
36ea7e0eeb comments
b38peng added 1 commit 1 year ago
b38peng added 1 commit 1 year ago
177744db9c remove border box
Collaborator

In the future, make sure you don't reuse branches :)

In the future, make sure you don't reuse branches :)
b38peng added 1 commit 1 year ago
017812443b Merge branch 'main' into feat/meet-the-team-page
b38peng requested review from a3thakra 1 year ago
a258wang reviewed 1 year ago
z-index: 12;
flex-direction: column;
max-width: calc(768rem / 16);
height: 75vh;
Owner

Have we tried max-height: 75vh? It might fix #242.

Have we tried `max-height: 75vh`? It might fix #242.
Collaborator

Amy might be onto something 👀

Amy might be onto something 👀
Owner

Also found another small bug with the mobile TeamMemberCard: #286.

Also found another small bug with the mobile TeamMemberCard: #286.
n3parikh closed this pull request 11 months ago

Reviewers

a3thakra was requested for review 1 year ago
All checks were successful
continuous-integration/drone/push Build is passing
Required
Details
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#241
Loading…
There is no content yet.