www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Meet the Team: fix Team Member Card bug #241

Closed
b38peng wants to merge 35 commits from feat/meet-the-team-page into main
pull from: feat/meet-the-team-page
merge into: www:main
Conversation 2 Commits 35 Files Changed 2 +10 -2
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
components/TeamMemberCard.module.css
View File

@ -88,9 +88,11 @@
display: flex;
z-index: 12;
flex-direction: column;
max-width: calc(768rem / 16);
height: 75vh;
a258wang commented 2021-09-01 22:27:14 -04:00
Review
Copy Link

Have we tried max-height: 75vh? It might fix #242.

Have we tried `max-height: 75vh`? It might fix #242.
👍 1
a3thakra commented 2021-09-02 12:52:40 -04:00
Review
Copy Link

Amy might be onto something 👀

Amy might be onto something 👀
overflow: auto;
background-color: var(--secondary-background);
padding: calc(20rem / 16) calc(40rem / 16);
left: 0;
top: 50%;
animation: popup 0.7s forwards;
}
@ -98,7 +100,6 @@
.closeBtn {
align-self: flex-end;
/* reset default button styling */
width: min-content;
background: transparent;
border: 0px solid transparent;
padding: 0;
@ -158,4 +159,8 @@
.description {
display: none;
}
.popupContainer {
left: 0;
}
}

3
components/TeamMemberCard.tsx
View File

@ -79,6 +79,9 @@ interface Propup extends TeamMemberCardProps {
handleClick: () => void;
}
// TODO: fix extra space at bottom of popup
// - this is due to height being specified in order to have scrolling
function ExecPopup({ name, role, image, children, handleClick }: Propup) {
return (
<>