Add paypal link #243

Merged
w25tran merged 6 commits from get-involved-payments into main 1 year ago
w25tran commented 1 year ago

Closes #207

Closes #207
w25tran added 1 commit 1 year ago
5032061e7c Add paypal link
w25tran requested review from n3parikh 1 year ago
Collaborator

#244 will fix the pipeline

#244 will fix the pipeline
a3thakra reviewed 1 year ago
<form action="https://www.paypal.com/cgi-bin/webscr" method="post">
<input type="hidden" name="cmd" value="_s-xclick"/>
<input type="hidden" name="hosted_button_id" value="9065852"/>
<input type="image" src="/images/get-involved/renew-paypal.gif" border="0" name="submit" alt="PayPal - The safer, easier way to pay online!"/>
Collaborator

uh pls no 🙈

use the <button> tag. Any attributes you use here will map to the Button component.

uh pls no 🙈 use the `<button>` tag. Any attributes you use here will map to the Button component.
Poster

Should I just remove the image entirely (its kinda ugly) and just have a button that says "Renew by Paypal"

Should I just remove the image entirely (its kinda ugly) and just have a button that says "Renew by Paypal"
Collaborator

YES! ❤️

YES! :heart:
w25tran marked this conversation as resolved
w25tran added 1 commit 1 year ago
8dda93d2b0 Merge branch 'main' into get-involved-payments
w25tran added 2 commits 1 year ago
Poster

#244 will fix the pipeline

I merged with main and now the build hasn't finished in 20+ mins

> #244 will fix the pipeline I merged with main and now the build hasn't finished in 20+ mins
Collaborator

I merged with main and now the build hasn't finished in 20+ mins

Probably just a 1 off

> I merged with main and now the build hasn't finished in 20+ mins Probably just a 1 off
a3thakra reviewed 1 year ago
Collaborator

?

?
w25tran marked this conversation as resolved
a3thakra reviewed 1 year ago
<form action="https://www.paypal.com/cgi-bin/webscr" method="post">
<input type="hidden" name="cmd" value="_s-xclick"/>
<input type="hidden" name="hosted_button_id" value="9065852"/>
<button name="submit" alt="PayPal - The safer, easier way to pay online!">Renew by PayPal</button>
Collaborator

size="small" and remove alt="..."

`size="small"` and remove `alt="..."`
w25tran marked this conversation as resolved
a3thakra approved these changes 1 year ago
a3thakra left a comment
Collaborator

Good to go after comments ☝️

Good to go after comments :point_up:
w25tran added 1 commit 1 year ago
598bdfb06f Change button size
w25tran added 1 commit 1 year ago
19e993917a Merge branch 'main' into get-involved-payments
Collaborator

You don't need to merge main before merging for small changes like these :)

You don't need to merge main before merging for small changes like these :)
w25tran merged commit 9cb30100df into main 1 year ago
w25tran referenced this issue from a commit 1 year ago
a3thakra deleted branch get-involved-payments 1 year ago

Reviewers

n3parikh was requested for review 1 year ago
a3thakra approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 9cb30100df.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#243
Loading…
There is no content yet.