Fix past events rendered twice #245

Merged
j285he merged 6 commits from jared-fix-term-238 into main 2 years ago
j285he commented 2 years ago
Collaborator

Closes #238

Closes #238
j285he added 4 commits 2 years ago
ad38eca98b Negate the flags
6256fe0dcd Fix logic, add section
b6b83e3fb2 Revert workaround for testing
5e868803bf for real this time
j285he requested review from a3thakra 2 years ago
a3thakra approved these changes 2 years ago
a3thakra left a comment
Collaborator

Logic LGTM. Haven't tried it.

Logic LGTM. Haven't tried it.
Poster
Collaborator

Wait I can simplify this one sec

Wait I can simplify this one sec
Collaborator

No this is actually good, it's slightly repetitive, but that's fine. It looks very clear.

No this is actually good, it's slightly repetitive, but that's fine. It looks very clear.
j285he added 2 commits 2 years ago
Poster
Collaborator

Ah ok sorry didn't see that. If this doesn't work I can change it back

I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem?

Ah ok sorry didn't see that. If this doesn't work I can change it back I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem?
Collaborator

fwiw, code looked cleaner earlier 🤷

fwiw, code looked cleaner earlier :shrug:
Collaborator

I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem?

Not a problem

> I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem? Not a problem
j285he merged commit 966129adf8 into main 2 years ago
j285he deleted branch jared-fix-term-238 2 years ago

Reviewers

a3thakra approved these changes 2 years ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 966129adf8.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#245
Loading…
There is no content yet.