www
/
www-new
12
2
Fork 3
Code Issues 57 Pull Requests 31 Projects Releases Wiki Activity
Labels Milestones

Fix past events rendered twice #245

Merged
j285he merged 6 commits from jared-fix-term-238 into main 1 year ago
Conversation 5 Commits 6 Files Changed 1
j285he commented 1 year ago
Collaborator

Closes #238

Closes #238
j285he added 4 commits 1 year ago
continuous-integration/drone/push Build is failing
Details
ad38eca98b Negate the flags
continuous-integration/drone/push Build is passing
Details
6256fe0dcd Fix logic, add section
continuous-integration/drone/push Build is failing
Details
b6b83e3fb2 Revert workaround for testing
continuous-integration/drone/push Build is failing
Details
5e868803bf for real this time
j285he requested review from a3thakra 1 year ago
a3thakra approved these changes 1 year ago
a3thakra left a comment
Collaborator

Logic LGTM. Haven't tried it.

Logic LGTM. Haven't tried it.
j285he commented 1 year ago
Poster
Collaborator

Wait I can simplify this one sec

Wait I can simplify this one sec
a3thakra commented 1 year ago
Collaborator

No this is actually good, it's slightly repetitive, but that's fine. It looks very clear.

No this is actually good, it's slightly repetitive, but that's fine. It looks very clear.
j285he added 2 commits 1 year ago
continuous-integration/drone/push Build is passing
Details
dbf978dec7 Simplify
j285he commented 1 year ago
Poster
Collaborator

Ah ok sorry didn't see that. If this doesn't work I can change it back

I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem?

Ah ok sorry didn't see that. If this doesn't work I can change it back I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem?
a3thakra commented 1 year ago
Collaborator

fwiw, code looked cleaner earlier 🤷

fwiw, code looked cleaner earlier :shrug:
a3thakra commented 1 year ago
Collaborator

I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem?

Not a problem

> I guess a nitpick here is that when hasPastEvents is true but hasFutureEvents and isCurrentTerm are not, the Event Archives is in a section even though there is one h1. Is that a problem? Not a problem
👍 1
j285he merged commit 966129adf8 into main 1 year ago
j285he deleted branch jared-fix-term-238 1 year ago

Reviewers

a3thakra approved these changes 1 year ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 966129adf8.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
a3thakra
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#245
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'jared-fix-term-238'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes