Make padding-bottom consistent for pages with EmailSignup component #247

Merged
j285he merged 8 commits from jared-fix-padding-bottom-101 into main 1 year ago
j285he commented 1 year ago
Collaborator

Closes #101.

Closes #101.
j285he added 1 commit 1 year ago
69d0568832 Make padding consistent
j285he added 1 commit 1 year ago
88bb11bf32 em -> rem
j285he added 1 commit 1 year ago
08d3dff085 em -> rem 2: Electric Boogaloo
Poster
Collaborator

Might it be worth looking into a uniform padding-bottom added to global styles?

edit: or margin-bottom, if that is what is preferred

Might it be worth looking into a uniform padding-bottom added to global styles? edit: or margin-bottom, if that is what is preferred
j285he requested review from a3thakra 1 year ago
Owner

Looks good to me! Just a couple of suggestions/notes:

  • Maybe we can adjust the bottom padding/margin on the Our Supporters page as well? It feels like it has less space down there than all the other pages.
  • I'm not sure whether we should be using padding or margin in this context. Perhaps someone more knowledgeable can shed some light on this?
Looks good to me! Just a couple of suggestions/notes: - Maybe we can adjust the bottom padding/margin on the Our Supporters page as well? It feels like it has less space down there than all the other pages. - I'm not sure whether we should be using padding or margin in this context. Perhaps someone more knowledgeable can shed some light on this?
j285he added 1 commit 1 year ago
441eb67770 Add padding to our-supporters
Poster
Collaborator

My thought process was that padding is a part of an object, whereas margin is used to separate 2 different object. Since to me the space at the bottom felt like an integral part of .page, I used padding. For example, if we were to add a border to .page (it would be very ugly if we did), then I think it makes sense that there is space between the border and content at the bottom.

I could be way off the mark though, let me know what you guys think!

My thought process was that padding is a part of an object, whereas margin is used to separate 2 different object. Since to me the space at the bottom felt like an integral part of `.page`, I used padding. For example, if we were to add a border to `.page` (it would be very ugly if we did), then I think it makes sense that there is space between the border and content at the bottom. I could be way off the mark though, let me know what you guys think!
b38peng approved these changes 1 year ago
Collaborator

looks good to me! Just need to pull from main 👍

looks good to me! Just need to pull from main 👍
j285he added 1 commit 1 year ago
6cb86f0e81 Merge branch 'main' into jared-fix-padding-bottom-101
a258wang closed this pull request 1 year ago
a258wang reopened this pull request 1 year ago
Collaborator

I think arguments can be made on both sides (margin vs padding).

The main technical difference is that margins are collapsible - https://medium.com/@joseph0crick/margin-collapse-in-css-what-why-and-how-328c10e37ca0

I prefer margin over padding for that reason, but I'll leave the decision up to you @j285he

The PR LGTM overall, so feel free to merge.

I think arguments can be made on both sides (margin vs padding). The main technical difference is that margins are collapsible - https://medium.com/@joseph0crick/margin-collapse-in-css-what-why-and-how-328c10e37ca0 I prefer margin over padding for that reason, but I'll leave the decision up to you @j285he The PR LGTM overall, so feel free to merge.
j285he added 2 commits 1 year ago
j285he added 1 commit 1 year ago
8b3154cc2e add margin to about
j285he merged commit 423f97f37b into main 1 year ago
a3thakra reviewed 1 year ago
.page {
margin: calc(50rem / 16) 0;
margin: calc(60rem / 16) 0;
Collaborator

This is changing the margins on the side as well, which make the page super narrow.

This is changing the margins on the side as well, which make the page super narrow.
a258wang reviewed 1 year ago
@media only screen and (max-width: calc(768rem / 16)) {
.page {
margin: calc(30rem / 16);
Owner

Continuing from Adi's comment: this should be margin: calc(30rem / 16) 0 so we don't change the side margins.

Continuing from Adi's comment: this should be `margin: calc(30rem / 16) 0` so we don't change the side margins.
a3thakra deleted branch jared-fix-padding-bottom-101 1 year ago

Reviewers

a3thakra was requested for review 1 year ago
b38peng approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 423f97f37b.
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#247
Loading…
There is no content yet.