Make padding-bottom consistent for pages with EmailSignup component #247

Closes #101.

Might it be worth looking into a uniform padding-bottom added to global styles?

edit: or margin-bottom, if that is what is preferred

Looks good to me! Just a couple of suggestions/notes:

Maybe we can adjust the bottom padding/margin on the Our Supporters page as well? It feels like it has less space down there than all the other pages.
I'm not sure whether we should be using padding or margin in this context. Perhaps someone more knowledgeable can shed some light on this?

My thought process was that padding is a part of an object, whereas margin is used to separate 2 different object. Since to me the space at the bottom felt like an integral part of .page, I used padding. For example, if we were to add a border to .page (it would be very ugly if we did), then I think it makes sense that there is space between the border and content at the bottom.

I could be way off the mark though, let me know what you guys think!

looks good to me! Just need to pull from main 👍

I think arguments can be made on both sides (margin vs padding).

The main technical difference is that margins are collapsible - https://medium.com/@joseph0crick/margin-collapse-in-css-what-why-and-how-328c10e37ca0

I prefer margin over padding for that reason, but I'll leave the decision up to you @j285he

The PR LGTM overall, so feel free to merge.

 .page {
   margin: calc(50rem / 16) 0;
   margin: calc(60rem / 16) 0;

 @media only screen and (max-width: calc(768rem / 16)) {
   .page {
     margin: calc(30rem / 16);

Make padding-bottom consistent for pages with EmailSignup component #247

Reviewers