From 06613ffa4dbd94182b92c85bc992cec07f845a2d Mon Sep 17 00:00:00 2001 From: Amy Date: Thu, 2 Sep 2021 01:05:53 -0400 Subject: [PATCH 1/6] Add focus ring around Button component --- components/Button.module.css | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/components/Button.module.css b/components/Button.module.css index 93ebcab1..db11799d 100644 --- a/components/Button.module.css +++ b/components/Button.module.css @@ -17,6 +17,16 @@ cursor: pointer; } +.button:focus, +.link:focus { + box-shadow: 0 0 0 calc(4rem / 16) var(--secondary-accent); +} + +.small.button:focus, +.small.link:focus { + box-shadow: 0 0 0 calc(3rem / 16) var(--secondary-accent); +} + .link { text-decoration: none; } -- 2.39.2 From 7cc173941a862afaa79f4539c9c5792537672818 Mon Sep 17 00:00:00 2001 From: Amy Date: Thu, 2 Sep 2021 01:16:56 -0400 Subject: [PATCH 2/6] Fix Advice page headers highlighting --- pages/resources/advice/co-op.module.css | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/pages/resources/advice/co-op.module.css b/pages/resources/advice/co-op.module.css index 8ee91ad4..b1a0807d 100644 --- a/pages/resources/advice/co-op.module.css +++ b/pages/resources/advice/co-op.module.css @@ -18,7 +18,7 @@ } .adviceBarContainer > a { - padding-right: calc(48rem / 16); + margin-right: calc(48rem / 16); color: var(--text); } @@ -46,6 +46,16 @@ a.currentAdvice { text-align: center; } + .adviceBarContainer { + flex-direction: column; + justify-content: center; + align-items: center; + } + + .adviceBarContainer > a { + margin: unset; + } + .codey { width: calc(140rem / 16); } -- 2.39.2 From e54fd450048caa300af0b285e6f1f0046b8fe9a2 Mon Sep 17 00:00:00 2001 From: Amy Date: Thu, 2 Sep 2021 01:42:42 -0400 Subject: [PATCH 3/6] Remove extra triangle icon in MiniEventCard on Safari --- components/MiniEventCard.module.css | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/components/MiniEventCard.module.css b/components/MiniEventCard.module.css index 59e1bbec..e398a611 100644 --- a/components/MiniEventCard.module.css +++ b/components/MiniEventCard.module.css @@ -45,6 +45,14 @@ list-style: none; } +.card > summary::marker { + display: none; +} + +.card > summary::-webkit-details-marker { + display: none; +} + .dropDownIcon { fill: var(--primary-accent); } -- 2.39.2 From 8e54e1a5511b84376ed52bb62b51dc0a88600ff3 Mon Sep 17 00:00:00 2001 From: Amy Date: Thu, 2 Sep 2021 01:54:46 -0400 Subject: [PATCH 4/6] Fix home page club title wrapping on desktop Safari --- pages/index.module.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pages/index.module.css b/pages/index.module.css index e62ad859..b5bf56b9 100644 --- a/pages/index.module.css +++ b/pages/index.module.css @@ -47,6 +47,7 @@ font-family: "Futura", "sans-serif"; font-size: calc(33rem / 16); text-align: center; + white-space: nowrap; color: var(--primary-heading); } @@ -151,6 +152,7 @@ .clubTitle { margin: calc(8rem / 16) 0; font-size: calc(20rem / 16); + white-space: unset; } .clubDescription { -- 2.39.2 From 56d76b1a44dcf8c6f5b1a09d35fd85239c92803d Mon Sep 17 00:00:00 2001 From: Amy Date: Thu, 2 Sep 2021 12:57:39 -0400 Subject: [PATCH 5/6] Change mobile events page header to be vertical flex, and add gap to mobile footer --- components/Footer.module.css | 3 ++- pages/events/[year]/[term]/index.module.css | 22 ++++++++++++++++++--- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/components/Footer.module.css b/components/Footer.module.css index 337a419f..e3c72fda 100644 --- a/components/Footer.module.css +++ b/components/Footer.module.css @@ -30,12 +30,13 @@ @media only screen and (max-width: calc(768rem / 16)) { .footer { - height: calc(120rem / 16); + height: calc(124rem / 16); } .container { flex-direction: column-reverse; justify-content: space-around; + gap: calc(4rem / 16); padding: 0 calc(24rem / 16); } } diff --git a/pages/events/[year]/[term]/index.module.css b/pages/events/[year]/[term]/index.module.css index 65cb415a..22a91b07 100644 --- a/pages/events/[year]/[term]/index.module.css +++ b/pages/events/[year]/[term]/index.module.css @@ -1,9 +1,9 @@ .main { - margin-top: calc(60rem / 16); - margin-bottom: calc(60rem / 16); + margin: calc(60rem / 16) 0; } -.main > h1, .main > section > h1 { +.main > h1, +.main > section > h1 { padding-bottom: calc(16rem / 16); border-bottom: calc(1rem / 16) solid var(--primary-heading); } @@ -34,3 +34,19 @@ .main > .miniEventCards { margin-top: 0; } + +@media only screen and (max-width: calc(768rem / 16)) { + .main { + margin: calc(30rem / 16) 0; + } + + .header { + flex-direction: column; + justify-content: center; + align-items: center; + } + + .header a { + margin: unset; + } +} -- 2.39.2 From 2cb5449262d8b509cfb63111296f2b6824f49b45 Mon Sep 17 00:00:00 2001 From: Aditya Thakral Date: Fri, 3 Sep 2021 15:52:19 -0400 Subject: [PATCH 6/6] Increase footer gap --- components/Footer.module.css | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/components/Footer.module.css b/components/Footer.module.css index e3c72fda..b9c378c7 100644 --- a/components/Footer.module.css +++ b/components/Footer.module.css @@ -1,8 +1,7 @@ .footer { box-sizing: border-box; background: var(--primary-heading); - height: calc(66rem / 16); - padding: calc(14rem / 16) 0; + padding: 1rem 0; width: 100%; } @@ -30,13 +29,14 @@ @media only screen and (max-width: calc(768rem / 16)) { .footer { - height: calc(124rem / 16); + padding: 2rem 0; + height: unset; } .container { flex-direction: column-reverse; justify-content: space-around; - gap: calc(4rem / 16); + gap: 1rem; padding: 0 calc(24rem / 16); } } -- 2.39.2