On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.
We set it to true to maintain compatibility with dev mode.
> On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.
We set it to true to maintain compatibility with dev mode.
Why does it need to be it's own weird html page, without the CSC navbar etc? Why not create a stats.tsx file under the pages directory?
If it's not urgent, I would also like to involve design for this page.
- Do you know if people use this page?
- Why does it need to be it's own weird html page, without the CSC navbar etc? Why not create a stats.tsx file under the pages directory?
- If it's not urgent, I would also like to involve design for this page.
This page is pretty much only used by syscom. I just copied it from the old website.
We'd strongly prefer to keep it as raw HTML + CSS, since we will be the ones updating this page in the future, and a raw HTML page is easier to edit.
This page is pretty much only used by syscom. I just copied it from the old website.
We'd strongly prefer to keep it as raw HTML + CSS, since we will be the ones updating this page in the future, and a raw HTML page is easier to edit.
On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.
We set it to true to maintain compatibility with dev mode.
Is there a way we can take this out? I think the trailing slashes look ugly.
(If it's a huge hassle then don't bother.)
> > On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.
>
> We set it to true to maintain compatibility with dev mode.
>
>
Is there a way we can take this out? I think the trailing slashes look ugly.
(If it's a huge hassle then don't bother.)
On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.
We set it to true to maintain compatibility with dev mode.
Is there a way we can take this out? I think the trailing slashes look ugly.
(If it's a huge hassle then don't bother.)
No, it will break most of our links. If we disable it, all pages will be exported with a trailing .html - eg: /about.html, /about/team.html, etc. But while developing the website, the URLs will be /about, /about/team, etc.
You also don't really need the trailing slashes afaik. If you enter the URL without the trailing slash, it still works.
> > > On a side note, why do we set trailingSlash to true? I find it rather ugly to append a slash to all of our page URLs.
> >
> > We set it to true to maintain compatibility with dev mode.
> >
> >
>
> Is there a way we can take this out? I think the trailing slashes look ugly.
> (If it's a huge hassle then don't bother.)
No, it will break most of our links. If we disable it, all pages will be exported with a trailing `.html` - eg: `/about.html`, `/about/team.html`, etc. But while developing the website, the URLs will be `/about`, `/about/team`, etc.
You also don't really need the trailing slashes afaik. If you enter the URL without the trailing slash, it still works.
We should namespace this page (and similar pages in the future) under something like /syscom (ie. make the URL /syscom/stats), just so it's obvious it's for internal use.
This looks good to me.
We should namespace this page (and similar pages in the future) under something like `/syscom` (ie. make the URL `/syscom/stats`), just so it's obvious it's for internal use.
a3thakra
The old website had a
/statspage which showed metrics for several campus network interfaces.This PR adds them back in.
On a side note, why do we set
trailingSlashto true? I find it rather ugly to append a slash to all of our page URLs.We set it to true to maintain compatibility with dev mode.
This page is pretty much only used by syscom. I just copied it from the old website.
We'd strongly prefer to keep it as raw HTML + CSS, since we will be the ones updating this page in the future, and a raw HTML page is easier to edit.
Is there a way we can take this out? I think the trailing slashes look ugly.
(If it's a huge hassle then don't bother.)
No, it will break most of our links. If we disable it, all pages will be exported with a trailing
.html- eg:/about.html,/about/team.html, etc. But while developing the website, the URLs will be/about,/about/team, etc.You also don't really need the trailing slashes afaik. If you enter the URL without the trailing slash, it still works.
Alright, fair enough.
This looks good to me.
We should namespace this page (and similar pages in the future) under something like
/syscom(ie. make the URL/syscom/stats), just so it's obvious it's for internal use.Unless there are any strong objections, I'm going to merge this one in.
b46c8d3d5ainto main 2 years agoReviewers
b46c8d3d5a.