Clean up Shapes Backgrounds on some mobile pages #307

Merged
a258wang merged 3 commits from amy-adjust-mobile-shapes-background into main 1 year ago
Owner

Addresses some of the shapes shenanigans that I noticed here: #236

  • Removed shapes from mobile /events/[year]/[term]/[event] page. (I left the default shapes on the mobile /events/[year]/[term] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!)
  • Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes.
  • Changed shapes on mobile Home page to accommodate the expanded Social Links.
Addresses some of the shapes shenanigans that I noticed here: https://git.csclub.uwaterloo.ca/www/www-new/issues/236#issuecomment-2450 - Removed shapes from mobile /events/\[year\]/\[term\]/\[event\] page. (I left the default shapes on the mobile /events/\[year\]/\[term\] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!) - Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes. - Changed shapes on mobile Home page to accommodate the expanded Social Links.
a258wang added 1 commit 1 year ago
6748c24ee8 Clean up shapes on some mobile pages
a258wang changed title from Clean up Shapes Backgrounds on some mobile pages to WIP: Clean up Shapes Backgrounds on some mobile pages 1 year ago
a258wang added 2 commits 1 year ago
a258wang changed title from WIP: Clean up Shapes Backgrounds on some mobile pages to Clean up Shapes Backgrounds on some mobile pages 1 year ago
Collaborator

Removed shapes from mobile /events/[year]/[term]/[event] page. (I left the default shapes on the mobile /events/[year]/[term] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!)

I agree, no need to remove them if they look fine!

Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes.

Changed shapes on mobile Home page to accommodate the expanded Social Links.

> Removed shapes from mobile /events/[year]/[term]/[event] page. (I left the default shapes on the mobile /events/[year]/[term] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!) ✅ I agree, no need to remove them if they look fine! > Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes. ✅ > Changed shapes on mobile Home page to accommodate the expanded Social Links. ✅
a3thakra approved these changes 1 year ago
a3thakra left a comment
Collaborator

code lgtm

code lgtm
a258wang merged commit 623e1bd52d into main 1 year ago
a3thakra deleted branch amy-adjust-mobile-shapes-background 1 year ago

Reviewers

a3thakra approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 623e1bd52d.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#307
Loading…
There is no content yet.