www
/
www-new
12
2
Fork 3
Code Issues 56 Pull Requests 29 Projects Releases Wiki Activity
Labels Milestones

Clean up Shapes Backgrounds on some mobile pages #307

Merged
a258wang merged 3 commits from amy-adjust-mobile-shapes-background into main 2 years ago
Conversation 1 Commits 3 Files Changed 5
a258wang commented 2 years ago
Owner

Addresses some of the shapes shenanigans that I noticed here: #236

  • Removed shapes from mobile /events/[year]/[term]/[event] page. (I left the default shapes on the mobile /events/[year]/[term] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!)
  • Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes.
  • Changed shapes on mobile Home page to accommodate the expanded Social Links.
Addresses some of the shapes shenanigans that I noticed here: https://git.csclub.uwaterloo.ca/www/www-new/issues/236#issuecomment-2450 - Removed shapes from mobile /events/\[year\]/\[term\]/\[event\] page. (I left the default shapes on the mobile /events/\[year\]/\[term\] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!) - Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes. - Changed shapes on mobile Home page to accommodate the expanded Social Links.
a258wang added 1 commit 2 years ago
continuous-integration/drone/push Build is passing
Details
6748c24ee8 Clean up shapes on some mobile pages
a258wang changed title from Clean up Shapes Backgrounds on some mobile pages to WIP: Clean up Shapes Backgrounds on some mobile pages 2 years ago
a258wang added 2 commits 2 years ago
continuous-integration/drone/push Build is passing
Details
8cc717e91f Adjust shapes on mobile Home page
a258wang changed title from WIP: Clean up Shapes Backgrounds on some mobile pages to Clean up Shapes Backgrounds on some mobile pages 2 years ago
a3thakra commented 2 years ago
Collaborator

Removed shapes from mobile /events/[year]/[term]/[event] page. (I left the default shapes on the mobile /events/[year]/[term] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!)

✅

I agree, no need to remove them if they look fine!

Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes.

✅

Changed shapes on mobile Home page to accommodate the expanded Social Links.

✅

> Removed shapes from mobile /events/[year]/[term]/[event] page. (I left the default shapes on the mobile /events/[year]/[term] page, since with the vertical nav header they now fit, but I'd love to hear others' opinions on this!) ✅ I agree, no need to remove them if they look fine! > Adjusted top margins on mobile Meet the Team, Our Supporters, and Tech Talks/Tech Talk pages to accommodate the shapes. ✅ > Changed shapes on mobile Home page to accommodate the expanded Social Links. ✅
a3thakra approved these changes 2 years ago
a3thakra left a comment
Collaborator

code lgtm

code lgtm
a258wang merged commit 623e1bd52d into main 2 years ago
a3thakra deleted branch amy-adjust-mobile-shapes-background 2 years ago

Reviewers

a3thakra approved these changes 2 years ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 623e1bd52d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
a3thakra
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#307
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'amy-adjust-mobile-shapes-background'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes