www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Fix organized content burger #317

Open
w25tran wants to merge 6 commits from fix-oc-burger into main
pull from: fix-oc-burger
merge into: www:main
Conversation 1 Commits 6 Files Changed 1 +1 -44
w25tran commented 2021-09-13 20:45:53 -04:00
Contributor
Copy Link

Closes #209
Now organized content burger always stays on screen as long as the organized content component is on screen.

Closes #209 Now organized content burger always stays on screen as long as the organized content component is on screen.
w25tran added 4 commits 2021-09-13 20:45:55 -04:00
continuous-integration/drone/push Build is passing Details
0dca9faeba Make organized content burger always visible
continuous-integration/drone/push Build is passing Details
91d841728b Make burger always visible as long as oc is visible
continuous-integration/drone/push Build is passing Details
88bb0aff0e Remove comments
a3thakra changed title from fix-oc-burger to Fix organized content burger 2021-09-15 22:58:38 -04:00
a3thakra requested changes 2021-09-15 23:01:26 -04:00
a3thakra left a comment
Owner
Copy Link

The burger is never visible now. https://csclub.uwaterloo.ca/~a3thakra/csc/fix-oc-burger/about/constitution/

The burger is never visible now. https://csclub.uwaterloo.ca/~a3thakra/csc/fix-oc-burger/about/constitution/
a3thakra added 1 commit 2021-09-16 22:58:00 -04:00
continuous-integration/drone/push Build is passing Details
bb9b00b24e Merge branch 'main' into fix-oc-burger
w25tran added 1 commit 2021-09-17 00:10:51 -04:00
continuous-integration/drone/push Build is passing Details
0f425c741e Trigger CI
w25tran commented 2021-09-17 00:40:46 -04:00
Author
Contributor
Copy Link

Interestingly, the burger is only not visible on the Read All page. I suspect that the 'detect if is on screen' code which uses a useRef, doesn't recognize the read all page since its generated serparately (components/OrganizedContent/Readall.tsx). I'm not sure the best way to go about changing this though.

Obviously if we want to avoid this all together, we can just have the burger show all the time, but that wouldn't play well if we end up having the OrganizedContent component along with other stuff on the same page some time in the future.

Interestingly, the burger is only not visible on the Read All page. I suspect that the 'detect if is on screen' code which uses a `useRef`, doesn't recognize the read all page since its generated serparately (components/OrganizedContent/Readall.tsx). I'm not sure the best way to go about changing this though. Obviously if we want to avoid this all together, we can just have the burger show all the time, but that wouldn't play well if we end up having the OrganizedContent component along with other stuff on the same page some time in the future.
All checks were successful
continuous-integration/drone/push Build is passing
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
a3thakra
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#317
No description provided.
Delete Branch "fix-oc-burger"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?