www
/
www-new
12
2
Fork 3
Code Issues 59 Pull Requests 29 Projects Releases Wiki Activity
Labels Milestones

Fix organized content burger #317

Open
w25tran wants to merge 6 commits from fix-oc-burger into main
Conversation 1 Commits 6 Files Changed 1
w25tran commented 1 year ago

Closes #209
Now organized content burger always stays on screen as long as the organized content component is on screen.

Closes #209 Now organized content burger always stays on screen as long as the organized content component is on screen.
w25tran added 4 commits 1 year ago
continuous-integration/drone/push Build is passing
Details
0dca9faeba Make organized content burger always visible
continuous-integration/drone/push Build is passing
Details
91d841728b Make burger always visible as long as oc is visible
continuous-integration/drone/push Build is passing
Details
88bb0aff0e Remove comments
a3thakra changed title from fix-oc-burger to Fix organized content burger 1 year ago
a3thakra requested changes 1 year ago
a3thakra left a comment
Collaborator

The burger is never visible now. https://csclub.uwaterloo.ca/~a3thakra/csc/fix-oc-burger/about/constitution/

The burger is never visible now. https://csclub.uwaterloo.ca/~a3thakra/csc/fix-oc-burger/about/constitution/
a3thakra added 1 commit 1 year ago
continuous-integration/drone/push Build is passing
Details
bb9b00b24e Merge branch 'main' into fix-oc-burger
w25tran added 1 commit 1 year ago
continuous-integration/drone/push Build is passing
Details
0f425c741e Trigger CI
w25tran commented 1 year ago
Poster

Interestingly, the burger is only not visible on the Read All page. I suspect that the 'detect if is on screen' code which uses a useRef, doesn't recognize the read all page since its generated serparately (components/OrganizedContent/Readall.tsx). I'm not sure the best way to go about changing this though.

Obviously if we want to avoid this all together, we can just have the burger show all the time, but that wouldn't play well if we end up having the OrganizedContent component along with other stuff on the same page some time in the future.

Interestingly, the burger is only not visible on the Read All page. I suspect that the 'detect if is on screen' code which uses a `useRef`, doesn't recognize the read all page since its generated serparately (components/OrganizedContent/Readall.tsx). I'm not sure the best way to go about changing this though. Obviously if we want to avoid this all together, we can just have the burger show all the time, but that wouldn't play well if we end up having the OrganizedContent component along with other stuff on the same page some time in the future.

Reviewers

a3thakra requested changes 1 year ago
All checks were successful
continuous-integration/drone/push Build is passing
Required
Details
This Pull Request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
a3thakra
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#317
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix-oc-burger'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes