Fix syscom roles #347

Merged
r389li merged 1 commits from raymo-fix-syscom-roles into main 1 year ago
r389li commented 1 year ago
Owner
There is no content yet.
r389li added the
Content
label 1 year ago
r389li added 1 commit 1 year ago
25ac395f05 Fix syscom roles
a3thakra reviewed 1 year ago
{
"name": "Raymond Li",
"role": "Member"
"role": ""
Collaborator

Any reason the "Member" role is not acceptable? I think the "" role looks a bit off UI wise, since everyone on other teams have a role.

I'm other to other words as well if you don't like "Member" :)

![](https:

Any reason the "Member" role is not acceptable? I think the "" role looks a bit off UI wise, since everyone on other teams have a role. I'm other to other words as well if you don't like "Member" :) ![](https:
Poster
Owner

It sounds like a regular club member, and we don't really have roles on Syscom (but it's good to have the alumni labelled as such).

It sounds like a regular club member, and we don't really have roles on Syscom (but it's good to have the alumni labelled as such).
Poster
Owner

Hmm or we could change the alumni's profile pics to "Alumni" and get rid of those roles, that way only Max has a role, would that look better?

Hmm or we could change the alumni's profile pics to "Alumni" and get rid of those roles, that way only Max has a role, would that look better?
Collaborator

on second thought, I'm fine with "", i think thats better considering there arent many roles in syscom.

on second thought, I'm fine with "", i think thats better considering there arent many roles in syscom.
Collaborator
There is no content yet.
a3thakra approved these changes 1 year ago
a3thakra left a comment
Collaborator

lgtm

lgtm
Collaborator

I'm good with what it looks like rn, I take my previous statement back haha 🙈

I'm good with what it looks like rn, I take my previous statement back haha 🙈
Poster
Owner

Lol ok I'll merge it then.

Lol ok I'll merge it then.
r389li merged commit 1ce1d6a087 into main 1 year ago
r389li referenced this issue from a commit 1 year ago
a3thakra deleted branch raymo-fix-syscom-roles 1 year ago

Reviewers

a3thakra approved these changes 1 year ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 1ce1d6a087.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#347
Loading…
There is no content yet.