Generate members list #354
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#354
Loading…
Reference in New Issue
No description provided.
Delete Branch "j285he-ldap"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #301
https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-ldap/about/members/
LGTM so far, we should add a link in the navbar too.
[WIP] Generate members listto Generate members list@ -29,3 +29,3 @@
- install-deps
commands:
- npm run build:web
- USE_LDAP=true npm run build:web
this will most likely fail
hmm it didn't, interesting haha
Based on (very preliminary!) research, it seems like unions are more readable, but enums are iterable and are better to use when it is unclear what strings refer to. For example:
then using
Permission.Read
makes sense.With that in mind I went with a union of strings. Let me know if you want that changed.
Also I think that refactoring all code to use exported
Term
type should be done in another pull request.94825d5cec
to39b6be18c0