Generate members list #354

Merged
j285he merged 24 commits from j285he-ldap into main 9 months ago
j285he commented 10 months ago
Collaborator
Closes #301 https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-ldap/about/members/
j285he added 9 commits 10 months ago
597f1961c4 Test ldap libraries
615aa3f95f Return members
a7d3a4e989 Make term parameter easier to use
d7f6935055 Testing file generation
87b4be35ea Change lib @
j285he added 1 commit 10 months ago
j285he added 1 commit 10 months ago
j285he added 1 commit 10 months ago
j285he added 1 commit 10 months ago
2f11260ec7 Another push
j285he added 2 commits 10 months ago
j285he added 1 commit 10 months ago
42f477c6fb Move USE_LDAP to deploy.sh
j285he added 1 commit 10 months ago
5cdf298c14 Update package-lock
j285he added 1 commit 10 months ago
ed3c4e39f4 Restyle members page
j285he added 1 commit 10 months ago
8f2fd0f564 px->rem
Owner

LGTM so far, we should add a link in the navbar too.

LGTM so far, we should add a link in the navbar too.
j285he added 1 commit 10 months ago
29d2fa3094 Add navbar link
j285he added 1 commit 10 months ago
d8c65972de [test] see if members get populated
j285he changed title from [WIP] Generate members list to Generate members list 10 months ago
a3thakra reviewed 10 months ago
.drone.yml Outdated
- install-deps
commands:
- npm run build:web
- USE_LDAP=true npm run build:web
Owner

this will most likely fail

this will most likely fail
Owner

hmm it didn't, interesting haha

hmm it didn't, interesting haha
a3thakra marked this conversation as resolved
j285he added 1 commit 10 months ago
2672e4b558 Delete old library
j285he requested review from a3thakra 9 months ago
j285he requested review from n3parikh 9 months ago
j285he added 2 commits 9 months ago
39b6be18c0 Merge main
6a8be3c753 Add Term type for members.ts
Poster
Collaborator

Based on (very preliminary!) research, it seems like unions are more readable, but enums are iterable and are better to use when it is unclear what strings refer to. For example:

enum Permission {
  Read = 'r',
  Write = 'w',
  Execute = 'x'
}

then using Permission.Read makes sense.

With that in mind I went with a union of strings. Let me know if you want that changed.

Also I think that refactoring all code to use exported Term type should be done in another pull request.

Based on (very preliminary!) research, it seems like unions are more readable, but enums are iterable and are better to use when it is unclear what strings refer to. For example: ``` enum Permission { Read = 'r', Write = 'w', Execute = 'x' } ``` then using `Permission.Read` makes sense. With that in mind I went with a union of strings. Let me know if you want that changed. Also I think that refactoring all code to use exported `Term` type should be done in another pull request.
j285he added 1 commit 9 months ago
94825d5cec Fix type
j285he force-pushed j285he-ldap from 94825d5cec to 39b6be18c0 9 months ago
j285he added 1 commit 9 months ago
7a304789f4 Add margin-bottom to table
n3parikh approved these changes 9 months ago
j285he merged commit e6315cf906 into main 9 months ago
j285he referenced this issue from a commit 9 months ago
j285he deleted branch j285he-ldap 9 months ago

Reviewers

a3thakra was requested for review 9 months ago
n3parikh approved these changes 9 months ago
continuous-integration/drone/push Build is passing
The pull request has been merged as e6315cf906.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.