Generate members list #354

j285he · 2021-10-24T15:43:16-04:00

j285he commented

2021-10-24 15:43:16 -04:00

Closes #301

https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-ldap/about/members/

Closes #301 https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-ldap/about/members/

j285he added 9 commits 2021-10-24 15:43:17 -04:00

continuous-integration/drone/push Build is failing Details

597f1961c4 Test ldap libraries

continuous-integration/drone/push Build is failing Details

615aa3f95f Return members

continuous-integration/drone/push Build is passing Details

a7d3a4e989 Make term parameter easier to use

continuous-integration/drone/push Build is failing Details

d7f6935055 Testing file generation

continuous-integration/drone/push Build is failing Details

87b4be35ea Change lib @

f85cd149db Change to use env variable

e87f924c86 Delete unused files

1e29e4bf37 Add env var to package.json

7076ce389e Add intro paragraph

j285he added 1 commit 2021-10-24 15:45:52 -04:00

d88a1836b5 Merge main

j285he added 1 commit 2021-10-24 15:46:16 -04:00

7e9ff36073 Remove log

j285he added 1 commit 2021-10-24 15:51:08 -04:00

da327f67df npm i

j285he added 1 commit 2021-10-25 21:15:46 -04:00

continuous-integration/drone/push Build is failing Details

2f11260ec7 Another push

j285he added 2 commits 2021-10-25 21:18:17 -04:00

6c0879c4b3 Change USE_LDAP to only detect true

continuous-integration/drone/push Build is failing Details

06cd286956 Change USE_LDAP to only detect true

j285he added 1 commit 2021-10-25 21:32:34 -04:00

continuous-integration/drone/push Build is failing Details

42f477c6fb Move USE_LDAP to deploy.sh

j285he added 1 commit 2021-10-25 21:40:52 -04:00

continuous-integration/drone/push Build is passing Details

5cdf298c14 Update package-lock

j285he added 1 commit 2021-10-25 22:09:12 -04:00

continuous-integration/drone/push Build is passing Details

ed3c4e39f4 Restyle members page

j285he added 1 commit 2021-10-25 22:10:36 -04:00

continuous-integration/drone/push Build is passing Details

8f2fd0f564 px->rem

a3thakra commented

2021-10-28 17:42:14 -04:00

LGTM so far, we should add a link in the navbar too.

j285he added 1 commit 2021-10-30 18:59:00 -04:00

continuous-integration/drone/push Build is passing Details

29d2fa3094 Add navbar link

j285he added 1 commit 2021-10-30 19:00:32 -04:00

continuous-integration/drone/push Build is passing Details

d8c65972de [test] see if members get populated

j285he changed title from ~~[WIP] Generate members list~~ to Generate members list

2021-10-30 19:00:41 -04:00

a3thakra reviewed 2021-10-30 19:07:42 -04:00

.drone.yml Outdated

													
				@ -29,3 +29,3 @@

				  - install-deps

				  commands:

				  - npm run build:web

				  - USE_LDAP=true npm run build:web

a3thakra commented

2021-10-30 19:07:42 -04:00

this will most likely fail

a3thakra commented

2021-10-30 19:08:19 -04:00

hmm it didn't, interesting haha

a3thakra marked this conversation as resolved

j285he added 1 commit 2021-10-30 19:38:54 -04:00

continuous-integration/drone/push Build is passing Details

2672e4b558 Delete old library

j285he requested review from a3thakra 2021-11-06 19:42:45 -04:00

j285he requested review from n3parikh 2021-11-06 19:42:45 -04:00

j285he added 1 commit 2021-11-13 21:01:18 -05:00

continuous-integration/drone/push Build is passing Details

39b6be18c0 Merge main

j285he commented

2021-11-13 21:07:05 -05:00

Based on (very preliminary!) research, it seems like unions are more readable, but enums are iterable and are better to use when it is unclear what strings refer to. For example:

enum Permission {
  Read = 'r',
  Write = 'w',
  Execute = 'x'
}

then using Permission.Read makes sense.

With that in mind I went with a union of strings. Let me know if you want that changed.

Also I think that refactoring all code to use exported Term type should be done in another pull request.

Based on (very preliminary!) research, it seems like unions are more readable, but enums are iterable and are better to use when it is unclear what strings refer to. For example: ``` enum Permission { Read = 'r', Write = 'w', Execute = 'x' } ``` then using `Permission.Read` makes sense. With that in mind I went with a union of strings. Let me know if you want that changed. Also I think that refactoring all code to use exported `Term` type should be done in another pull request.

👍 1

j285he force-pushed j285he-ldap from 94825d5cec to 39b6be18c0

2021-11-20 20:52:26 -05:00

Compare

j285he added 1 commit 2021-11-20 21:04:32 -05:00

continuous-integration/drone/push Build is passing Details

7a304789f4 Add margin-bottom to table

n3parikh approved these changes 2021-11-21 19:56:38 -05:00

j285he merged commit e6315cf906 into main

2021-11-22 12:47:02 -05:00

j285he referenced this issue from a commit

2021-11-22 12:47:03 -05:00