Based on (very preliminary!) research, it seems like unions are more readable, but enums are iterable and are better to use when it is unclear what strings refer to. For example:
With that in mind I went with a union of strings. Let me know if you want that changed.
Also I think that refactoring all code to use exported Term type should be done in another pull request.
Based on (very preliminary!) research, it seems like unions are more readable, but enums are iterable and are better to use when it is unclear what strings refer to. For example:
```
enum Permission {
Read = 'r',
Write = 'w',
Execute = 'x'
}
```
then using `Permission.Read` makes sense.
With that in mind I went with a union of strings. Let me know if you want that changed.
Also I think that refactoring all code to use exported `Term` type should be done in another pull request.
a3thakra
n3parikh
Closes #301
https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-ldap/about/members/
LGTM so far, we should add a link in the navbar too.
[WIP] Generate members listto Generate members list 1 year ago- install-depscommands:- npm run build:web- USE_LDAP=true npm run build:webthis will most likely fail
hmm it didn't, interesting haha
Based on (very preliminary!) research, it seems like unions are more readable, but enums are iterable and are better to use when it is unclear what strings refer to. For example:
then using
Permission.Readmakes sense.With that in mind I went with a union of strings. Let me know if you want that changed.
Also I think that refactoring all code to use exported
Termtype should be done in another pull request.94825d5cecto39b6be18c01 year agoe6315cf906into main 1 year agoReviewers
e6315cf906.