www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Mobile TeamMemberCard fixes #368

Merged
a258wang merged 7 commits from amy-meet-the-team-fixes into main 2022-01-18 20:25:15 -05:00
Conversation 0 Commits 7 Files Changed 2 +58 -54
a258wang commented 2021-11-25 02:26:52 -05:00
Owner
Copy Link

Summary of changes:

  • Refactored TeamMemberCard to get rid of isPopup prop
  • Reorganized TeamMemberCard CSS
  • Fixes #213
  • Fixes #214
  • Fixes #242
  • Fixes #286

Related PR: #241 (Bonnie gave us permission to take over this work)

Staging: https://csclub.uwaterloo.ca/~a3thakra/csc/amy-meet-the-team-fixes/about/team

Summary of changes: - Refactored TeamMemberCard to get rid of `isPopup` prop - Reorganized TeamMemberCard CSS - Fixes #213 - Fixes #214 - Fixes #242 - Fixes #286 Related PR: #241 (Bonnie gave us permission to take over this work) Staging: https://csclub.uwaterloo.ca/~a3thakra/csc/amy-meet-the-team-fixes/about/team
a258wang added 5 commits 2021-11-25 02:26:53 -05:00
continuous-integration/drone/push Build is passing Details
59b61ff5da Change start to flex-start
a258wang requested review from j285he 2021-11-25 02:28:27 -05:00
a258wang requested review from n3parikh 2021-11-25 02:28:33 -05:00
a258wang requested review from a3thakra 2022-01-08 20:11:58 -05:00
j285he approved these changes 2022-01-11 19:28:59 -05:00
j285he left a comment
Member
Copy Link

I don't think I saw anything wrong with the changed code and I was able to reproduce all fixes 👍

I don't think I saw anything wrong with the changed code and I was able to reproduce all fixes 👍
components/TeamMemberCard.module.css
@ -105,2 +115,4 @@
background: none;
border: none;
padding: 0;
font-family: inherit;
j285he commented 2022-01-11 19:23:21 -05:00
Member
Copy Link

Is inheriting the font-family necessary?

Is inheriting the font-family necessary?
a258wang commented 2022-01-11 23:52:47 -05:00
Author
Owner
Copy Link

Hmm I tried commenting it out and nothing seems to have changed visually, so I guess it's probably not needed. 🤷

Hmm I tried commenting it out and nothing seems to have changed visually, so I guess it's probably not needed. 🤷
components/TeamMemberCard.tsx Outdated
@ -78,1 +65,4 @@
);
}
interface Propup extends TeamMemberCardProps {
j285he commented 2022-01-11 19:21:07 -05:00
Member
Copy Link

Is this meant to be Propup or Popup?

Is this meant to be Propup or Popup?
a258wang commented 2022-01-11 23:53:39 -05:00
Author
Owner
Copy Link

I think it's some sort of portmanteau of Props and Popup; I'll change the name to be more clear. 😂

I think it's some sort of portmanteau of `Props` and `Popup`; I'll change the name to be more clear. 😂
a258wang added 2 commits 2022-01-11 23:56:34 -05:00
continuous-integration/drone/push Build is passing Details
816938e830 Rename interface
a3thakra approved these changes 2022-01-18 19:26:43 -05:00
a258wang merged commit ff0594eac7 into main 2022-01-18 20:25:15 -05:00
a258wang deleted branch amy-meet-the-team-fixes 2022-01-18 20:25:23 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
n3parikh
j285he
a3thakra
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#368
No description provided.
Delete Branch "amy-meet-the-team-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?