www
/
www-new
16
3
Fork 7
Code Issues 58 Pull Requests 47 Projects Releases Wiki Activity

Added bootcamp mentor signup to news (Jan2022) (Closes #374) #381

Merged
snedadah merged 1 commits from shahanneda-news-11jan2022 into main 2022-01-11 23:39:31 -05:00
Conversation 4 Commits 1 Files Changed 1 +17
snedadah commented 2022-01-11 23:15:54 -05:00
Owner
Copy Link

Should there not be an "upcoming event" about this bootcamp also?

Should there not be an "upcoming event" about this bootcamp also? - Closes #374
n3parikh was assigned by snedadah 2022-01-11 23:15:54 -05:00
j285he was assigned by snedadah 2022-01-11 23:15:54 -05:00
a258wang was assigned by snedadah 2022-01-11 23:15:55 -05:00
snedadah added 1 commit 2022-01-11 23:15:56 -05:00
continuous-integration/drone/push Build is passing Details
f574511730 Added bootcamp mentor signup to news (Jan2022)
a258wang commented 2022-01-11 23:23:54 -05:00
Owner
Copy Link

We have #375 to add the Bootcamp event to the website.

You can add "Fixes #X" or "Closes #X" to the PR message, and the linked issue will automatically be closed when the PR is merged.

In general, you can link PRs/issues by typing their number with a # in front.

We have #375 to add the Bootcamp event to the website. You can add "Fixes #X" or "Closes #X" to the PR message, and the linked issue will automatically be closed when the PR is merged. In general, you can link PRs/issues by typing their number with a # in front.
a258wang commented 2022-01-11 23:26:17 -05:00
Owner
Copy Link

Everything looks good to me! Once the PR message has been updated with "Closes #X" etc., we'll approve the PR and then we can merge it.

Everything looks good to me! Once the PR message has been updated with "Closes #X" etc., we'll approve the PR and then we can merge it.
snedadah changed title from Added bootcamp mentor signup to news (Jan2022) (Issue #374) to Added bootcamp mentor signup to news (Jan2022) (Closes #374) 2022-01-11 23:26:49 -05:00
snedadah commented 2022-01-11 23:29:39 -05:00
Author
Owner
Copy Link

Everything looks good to me! Once the PR message has been updated with "Closes #X" etc., we'll approve the PR and then we can merge it.

Oh I see, I updated it. Thanks for letting me know how its done, does it automatically close the issue anytime an issue is referenced in a pull request?
(since what if someone just mentiones an issue but doesnt actually solve it)

> Everything looks good to me! Once the PR message has been updated with "Closes #X" etc., we'll approve the PR and then we can merge it. Oh I see, I updated it. Thanks for letting me know how its done, does it automatically close the issue anytime an issue is referenced in a pull request? (since what if someone just mentiones an issue but doesnt actually solve it)
a258wang commented 2022-01-11 23:35:26 -05:00
Owner
Copy Link

Everything looks good to me! Once the PR message has been updated with "Closes #X" etc., we'll approve the PR and then we can merge it.

Oh I see, I updated it. Thanks for letting me know how its done, does it automatically close the issue anytime an issue is referenced in a pull request?
(since what if someone just mentiones an issue but doesnt actually solve it)

No, it will only close the issue if you prefix the issue number with something like "Fixes" or "Closes". So you can safely link to issues without having to worry about closing them. 🙂

BTW we usually put the "Closes #X" in the PR comment/description, right here: #381 (comment)
Here's an example: #368
However, I see an underline under the keyword "Closes" in the PR name, so I think this should work as well!

> > Everything looks good to me! Once the PR message has been updated with "Closes #X" etc., we'll approve the PR and then we can merge it. > > Oh I see, I updated it. Thanks for letting me know how its done, does it automatically close the issue anytime an issue is referenced in a pull request? > (since what if someone just mentiones an issue but doesnt actually solve it) > > No, it will only close the issue if you prefix the issue number with something like "Fixes" or "Closes". So you can safely link to issues without having to worry about closing them. 🙂 BTW we usually put the "Closes #X" in the PR comment/description, right here: https://git.csclub.uwaterloo.ca/www/www-new/pulls/381#issue-448 Here's an example: https://git.csclub.uwaterloo.ca/www/www-new/pulls/368 However, I see an underline under the keyword "Closes" in the PR name, so I think this should work as well!
a258wang approved these changes 2022-01-11 23:36:21 -05:00
a258wang left a comment
Owner
Copy Link

Looks good! Here's the staging website, if you haven't seen it already: https://csclub.uwaterloo.ca/~a3thakra/csc/shahanneda-news-11jan2022/

Looks good! Here's the staging website, if you haven't seen it already: https://csclub.uwaterloo.ca/~a3thakra/csc/shahanneda-news-11jan2022/
snedadah merged commit e4c0d37337 into main 2022-01-11 23:39:31 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
a258wang
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
n3parikh
j285he
a258wang
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#381
No description provided.
Delete Branch "shahanneda-news-11jan2022"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?