Sort Members by name instead of userid (Fixes #371) #384

b72zhou · 2022-01-13T01:58:21-05:00

b72zhou commented

2022-01-13 01:58:21 -05:00

No description provided.

b72zhou added 1 commit 2022-01-13 01:58:23 -05:00

continuous-integration/drone/push Build is passing Details

618be449f8 Sort Members by name instead of userid

b72zhou requested review from j285he 2022-01-13 01:58:44 -05:00

b72zhou changed title from ~~Sort Members by name instead of userid~~ to Sort Members by name instead of userid (Fixes #371)

2022-01-13 02:13:21 -05:00

j285he commented

2022-01-16 02:31:40 -05:00

LGTM, wondering if we should sort by first name or last name. @a258wang @n3parikh thoughts?

a258wang commented

2022-01-16 16:43:03 -05:00

LGTM, wondering if we should sort by first name or last name. @a258wang @n3parikh thoughts?

Let's sort by first name, I believe that's what the old website did. Also since the members are listed with their first names first, it's easy to see at a glance how the list is sorted (whereas it might be a little harder to see that the list is sorted if people are ordered by last name).

> LGTM, wondering if we should sort by first name or last name. @a258wang @n3parikh thoughts? Let's sort by first name, I believe that's what the old website did. Also since the members are listed with their first names first, it's easy to see at a glance how the list is sorted (whereas it might be a little harder to see that the list is sorted if people are ordered by last name).

👍 1

j285he approved these changes 2022-01-16 22:09:06 -05:00

b72zhou merged commit fdb6bb1ccf into main

2022-01-17 00:15:41 -05:00

b72zhou deleted branch members-sort-by-name

2022-01-17 00:15:41 -05:00

b72zhou referenced this issue from a commit

2022-01-17 00:15:41 -05:00

Sort Members by name instead of userid (Fixes #371) (#384)

Sign in to join this conversation.

No reviewers