www
/
www-new
12
2
Fork 3
Code Issues 57 Pull Requests 31 Projects Releases Wiki Activity
Labels Milestones

Sort Members by name instead of userid (Fixes #371) #384

Merged
b72zhou merged 1 commits from members-sort-by-name into main 1 year ago
Conversation 2 Commits 1 Files Changed 1
b72zhou commented 1 year ago
Collaborator
There is no content yet.
b72zhou added 1 commit 1 year ago
continuous-integration/drone/push Build is passing
Details
618be449f8 Sort Members by name instead of userid
b72zhou requested review from j285he 1 year ago
b72zhou changed title from Sort Members by name instead of userid to Sort Members by name instead of userid (Fixes #371) 1 year ago
j285he commented 1 year ago
Collaborator

LGTM, wondering if we should sort by first name or last name. @a258wang @n3parikh thoughts?

LGTM, wondering if we should sort by first name or last name. @a258wang @n3parikh thoughts?
a258wang commented 1 year ago
Owner

LGTM, wondering if we should sort by first name or last name. @a258wang @n3parikh thoughts?

Let's sort by first name, I believe that's what the old website did. Also since the members are listed with their first names first, it's easy to see at a glance how the list is sorted (whereas it might be a little harder to see that the list is sorted if people are ordered by last name).

> LGTM, wondering if we should sort by first name or last name. @a258wang @n3parikh thoughts? Let's sort by first name, I believe that's what the old website did. Also since the members are listed with their first names first, it's easy to see at a glance how the list is sorted (whereas it might be a little harder to see that the list is sorted if people are ordered by last name).
👍 1
j285he approved these changes 1 year ago
b72zhou merged commit fdb6bb1ccf into main 1 year ago
b72zhou deleted branch members-sort-by-name 1 year ago

Reviewers

j285he approved these changes 1 year ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as fdb6bb1ccf.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
j285he
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#384
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'members-sort-by-name'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes