www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Fixed logo centering on home page #386

Merged
snedadah merged 4 commits from fix-logo-centering into main 2022-01-15 21:46:27 -05:00
Conversation 1 Commits 4 Files Changed 1 +2
snedadah commented 2022-01-13 04:52:41 -05:00
Owner
Copy Link

Closes #372

Closes #372
snedadah added 1 commit 2022-01-13 04:52:42 -05:00
continuous-integration/drone/push Build is passing Details
07ba528e5f fixed home page logo centering
snedadah added 1 commit 2022-01-13 04:53:07 -05:00
continuous-integration/drone/push Build is passing Details
64dc1bceb8 Merge branch 'main' into fix-logo-centering
n3parikh was assigned by snedadah 2022-01-13 15:33:58 -05:00
j285he was assigned by snedadah 2022-01-13 15:33:58 -05:00
a258wang was assigned by snedadah 2022-01-13 15:33:58 -05:00
a258wang commented 2022-01-13 23:08:34 -05:00
Owner
Copy Link

The centering looks good! Maybe we can consider adding an 8px (ie. calc(8rem / 16)) margin between the logo/club name and the subtitle?

Also please remember to add us as reviewers rather than assignees next time, thank you. 🙂

The centering looks good! Maybe we can consider adding an `8px` (ie. `calc(8rem / 16)`) margin between the logo/club name and the subtitle? Also please remember to add us as *reviewers* rather than *assignees* next time, thank you. 🙂
nomargin.png
91 KiB
margin.png
91 KiB
nomargin.png margin.png
snedadah added 2 commits 2022-01-15 19:43:44 -05:00
a258wang approved these changes 2022-01-15 21:31:45 -05:00
a258wang left a comment
Owner
Copy Link

Looks good to me!

Looks good to me!
snedadah merged commit d11aa814ce into main 2022-01-15 21:46:27 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
a258wang
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
n3parikh
a258wang
j285he
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#386
No description provided.
Delete Branch "fix-logo-centering"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?