www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Update Meet The Team page for Winter 2022 (Closes #382) #388

Merged
e26chiu merged 13 commits from update-meet-team-page-winter-2022 into main 2022-01-26 11:00:20 -05:00
Conversation 5 Commits 13 Files Changed 63 +246 -118
e26chiu commented 2022-01-21 23:27:30 -05:00
Contributor
Copy Link

Missing pictures:

  • Elaine Han
  • Tommy Jiang
  • Seshan Ravikumar

To ignore:

  • Matthew Wang
  • Amy Wang
  • Ivy Lei
  • Amin Bandali
  • Anthony Brennan
  • Edwin Zhang
  • Elana Hashman
  • Jennifer Zhou
  • Zachary Seguin
Missing pictures: - Elaine Han - Tommy Jiang - Seshan Ravikumar To ignore: - Matthew Wang - Amy Wang - Ivy Lei - Amin Bandali - Anthony Brennan - Edwin Zhang - Elana Hashman - Jennifer Zhou - Zachary Seguin
e26chiu added 1 commit 2022-01-21 23:27:31 -05:00
continuous-integration/drone/push Build is failing Details
47ea59611f update meet the team page for winter 2022
e26chiu changed title from Update Meet The Team page for Winter 2022 to Update Meet The Team page for Winter 2022 (Closes #382) 2022-01-21 23:30:49 -05:00
e26chiu added 1 commit 2022-01-21 23:35:33 -05:00
continuous-integration/drone/push Build is passing Details
178c2448be fix lint issue & update picture
e26chiu added 1 commit 2022-01-21 23:36:22 -05:00
continuous-integration/drone/push Build is passing Details
f2e803330a Merge branch 'main' into update-meet-team-page-winter-2022
e26chiu requested review from n3parikh 2022-01-21 23:42:07 -05:00
e26chiu requested review from a258wang 2022-01-21 23:42:07 -05:00
a258wang reviewed 2022-01-22 14:17:30 -05:00
content/team/execs/05-raymond-li.md Outdated
@ -0,0 +3,4 @@
role: Systems Administrator
---
Hey there! I'm <a href="https://raymond.li" target="_blank">Raymond.Li</a>. I'm in my 2B CS term. As sysadmin, I lead syscom in maintaining all the club infrastructure, including our <a href="https://wiki.csclub.uwaterloo.ca/Machine_List" target="_blank">machines</a>, <a href="https://mirror.csclub.uwaterloo.ca/stats" target="_blank">mirror</a>, <a href="https://wiki.csclub.uwaterloo.ca" target="_blank">wiki</a>, <a href="https://mail.csclub.uwaterloo.ca" target="_blank">email service</a>, <a href="https://git.csclub.uwaterloo.ca" target="_blank">Gitea instance</a>, <a href="https://mattermost.csclub.uwaterloo.ca" target="_blank">Mattermost instance</a>, <a href="https://chat.csclub.uwaterloo.ca" target="_blank">TheLounge instance</a>, and much much more. I like to code, ski, and play chess and violin.<br />#btwiusearch (at least until <a href="https://youtu.be/dQw4w9WgXcQ" target="_blank">Linux expires in 2038</a>)
a258wang commented 2022-01-22 14:17:30 -05:00
Owner
Copy Link

Does the usual way of adding links in Markdown ie. [Raymond Li](https://raymond.li) not work?

Also, whenever we have an anchor tag with target="_blank", it's generally considered a good idea to include rel="noopener noreferrer" as well. However,
a) as of 2021, most major browsers automatically use the rel="noopener" behaviour, and
b) these links are provided by us and not by random users,
so it's not a big deal if we don't explicitly specific rel="noopener noreferrer".

Some links about this:
https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/
https://mathiasbynens.github.io/rel-noopener/

Does the usual way of adding links in Markdown ie. `[Raymond Li](https://raymond.li)` not work? Also, whenever we have an anchor tag with `target="_blank"`, it's generally considered a good idea to include `rel="noopener noreferrer"` as well. However, a) as of 2021, most major browsers automatically use the `rel="noopener"` behaviour, and b) these links are provided by us and not by random users, so it's not a big deal if we don't explicitly specific `rel="noopener noreferrer"`. Some links about this: https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/ https://mathiasbynens.github.io/rel-noopener/
a258wang reviewed 2022-01-22 14:18:48 -05:00
content/team/programme-committee.json Outdated
@ -53,0 +114,4 @@
"role": "Events"
},
{
"name": "Santiago Montemayor",
a258wang commented 2022-01-22 14:18:48 -05:00
Owner
Copy Link

Just a nitpick, but I think Santiago usually goes by Santiago Montemayor Gomez

Just a nitpick, but I think Santiago usually goes by `Santiago Montemayor Gomez`
a258wang reviewed 2022-01-22 14:20:50 -05:00
content/team/programme-committee.json Outdated
@ -84,1 +174,3 @@
"role": "Discord Mod"
"name": "Kshama Patel",
"role": "Marketing",
"image": "/images/team/KshamaPatel.JPG"
a258wang commented 2022-01-22 14:20:50 -05:00
Owner
Copy Link

I'm curious if we need to specify the image path here, since the filename aligns with the person's display name? (Maybe if we change the image extension to .jpg instead of .JPG it'll work automatically?)

I'm curious if we need to specify the image path here, since the filename aligns with the person's display name? (Maybe if we change the image extension to `.jpg` instead of `.JPG` it'll work automatically?)
e26chiu added 1 commit 2022-01-22 18:52:48 -05:00
continuous-integration/drone/push Build is passing Details
d2368de68c fix raymond description & programme-committee
a258wang reviewed 2022-01-22 20:05:52 -05:00
content/team/programme-committee.json Outdated
@ -83,2 +175,2 @@
"name": "Chris Xie",
"role": "Discord Mod"
"name": "Kshama Patel",
"role": "Marketing"
a258wang commented 2022-01-22 20:05:52 -05:00
Owner
Copy Link

Yeah Kshama's image isn't showing up on the staging website: https://csclub.uwaterloo.ca/~a3thakra/csc/update-meet-team-page-winter-2022/about/team/
I think either (a) the image extension needs to be renamed to be lowercase (ie. .jpg and not .JPG), or (b) we can change the code that automatically tries to find each person's image, and make sure it will look for .JPG files as well.

Yeah Kshama's image isn't showing up on the staging website: https://csclub.uwaterloo.ca/~a3thakra/csc/update-meet-team-page-winter-2022/about/team/ I think either (a) the image extension needs to be renamed to be lowercase (ie. `.jpg` and not `.JPG`), or (b) we can change the code that automatically tries to find each person's image, and make sure it will look for `.JPG` files as well.
e26chiu commented 2022-01-22 21:02:55 -05:00
Author
Contributor
Copy Link

I will try to do a). For that I will have to do 2 push (1 without Kshama's picture and the one fixed with the lowercase .jpg) since git doesn't recognize the change when I change from JPG to jpg.
Apparently, it's because the server is running on a Linux distribution, so it's case-sensitive: https://stackoverflow.com/questions/9433945/capitalized-jpg-extension-different-from-lowercase-jpg

I will try to do a). For that I will have to do 2 push (1 without Kshama's picture and the one fixed with the lowercase `.jpg`) since git doesn't recognize the change when I change from JPG to jpg. Apparently, it's because the server is running on a Linux distribution, so it's case-sensitive: https://stackoverflow.com/questions/9433945/capitalized-jpg-extension-different-from-lowercase-jpg
e26chiu added 1 commit 2022-01-22 21:05:20 -05:00
continuous-integration/drone/push Build is passing Details
6b8b6e70c0 remove Kshama picture
e26chiu added 1 commit 2022-01-22 21:06:03 -05:00
continuous-integration/drone/push Build is passing Details
29c23919de add Kshama's picture
e26chiu added 1 commit 2022-01-22 21:10:10 -05:00
continuous-integration/drone/push Build is failing Details
1dac65bb3d remove pictures with .JPG
e26chiu added 1 commit 2022-01-22 21:11:20 -05:00
continuous-integration/drone/push Build is passing Details
9d07a53c12 add pictures with .jpg
a258wang commented 2022-01-22 21:34:30 -05:00
Owner
Copy Link

OOPS I forgot to mention this earlier, but would it be possible to add a link to the termcom section at the top of the mobile page, similar to what we have for the other sections? I'm sorry for not noticing this earlier 😅

image

OOPS I forgot to mention this earlier, but would it be possible to add a link to the termcom section at the top of the mobile page, similar to what we have for the other sections? I'm sorry for not noticing this earlier 😅 ![image](/attachments/a2c99f9e-7748-49a4-8224-a5f138360472)
image.png
129 KiB
e26chiu added 1 commit 2022-01-22 21:36:47 -05:00
continuous-integration/drone/push Build is passing Details
cdecdfb4e5 add link to termcom
a258wang approved these changes 2022-01-22 22:00:37 -05:00
a258wang left a comment
Owner
Copy Link

Looks good to me! We can always make more tweaks to this content in the future if needed (eg. changing names/images).

Thank you Emily for working on this and responding to feedback!

Looks good to me! We can always make more tweaks to this content in the future if needed (eg. changing names/images). Thank you Emily for working on this and responding to feedback!
a258wang commented 2022-01-25 12:32:40 -05:00
Owner
Copy Link

Hey @e26chiu, since this PR hasn't been merged yet - would you mind changing Laura Nguyen's image to use her new square headshot from the Committee Headshots folder, instead of her old rectangular one? It may also be a good idea to double-check that everyone else who uploaded new images is using those, and not their old ones. Thanks! :)

Hey @e26chiu, since this PR hasn't been merged yet - would you mind changing Laura Nguyen's image to use her new square headshot from the Committee Headshots folder, instead of her old rectangular one? It may also be a good idea to double-check that everyone else who uploaded new images is using those, and not their old ones. Thanks! :)
e26chiu added 1 commit 2022-01-25 13:02:51 -05:00
r389li commented 2022-01-25 13:53:53 -05:00
Owner
Copy Link

@e26chiu if you wouldn't mind adding the alumni tag to Anthony Brennan, Edwin Zhang, Elana Hashman, and Jennifer Zhou under syscom that would be great.

@e26chiu if you wouldn't mind adding the `alumni` tag to Anthony Brennan, Edwin Zhang, Elana Hashman, and Jennifer Zhou under syscom that would be great.
e26chiu added 1 commit 2022-01-25 14:03:32 -05:00
continuous-integration/drone/push Build is passing Details
472ea1664d update syscom roles for alumni
a258wang commented 2022-01-25 20:58:20 -05:00
Owner
Copy Link

@e26chiu Apologies for the all the pings! Just a couple of updates:

@e26chiu Apologies for the all the pings! Just a couple of updates: - Please update Andy Wang's headshot to this image: https://drive.google.com/file/d/1YTE5vytXf9JOpb55pfuB6p-fmLBsLRG7/view?usp=sharing - Please update Laura Nguyen's headshot to this image: https://drive.google.com/file/d/13Jx1rbmPZ6AyzAzDjthGCzTBZNb9r-ql/view?usp=sharing (it's the same picture but cropped differently... idk if you've changed it already but looking at staging it still seems to be the old headshot)
e26chiu added 1 commit 2022-01-25 23:18:02 -05:00
continuous-integration/drone/push Build is passing Details
0f177358fa update pictures for meet our team page
e26chiu added 1 commit 2022-01-25 23:37:07 -05:00
continuous-integration/drone/push Build is passing Details
52002eae5d update andy's picture
a258wang approved these changes 2022-01-26 10:49:18 -05:00
a258wang left a comment
Owner
Copy Link

@e26chiu Let's merge this! 🚢

@e26chiu Let's merge this! 🚢
e26chiu merged commit 39cece999c into main 2022-01-26 11:00:20 -05:00
r389li commented 2022-01-26 14:38:04 -05:00
Owner
Copy Link

🎉

🎉
Sign in to join this conversation.
Reviewers
No reviewers
n3parikh
a258wang
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#388
No description provided.
Delete Branch "update-meet-team-page-winter-2022"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?