Update Meet The Team page for Winter 2022 (Closes #382) #388
Merged
e26chiu
merged 13 commits from update-meet-team-page-winter-2022
into main
1 year ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'update-meet-team-page-winter-2022'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Missing pictures:
To ignore:
Update Meet The Team page for Winter 2022to Update Meet The Team page for Winter 2022 (Closes #382) 1 year agorole: Systems Administrator
---
Hey there! I'm <a href="https://raymond.li" target="_blank">Raymond.Li</a>. I'm in my 2B CS term. As sysadmin, I lead syscom in maintaining all the club infrastructure, including our <a href="https://wiki.csclub.uwaterloo.ca/Machine_List" target="_blank">machines</a>, <a href="https://mirror.csclub.uwaterloo.ca/stats" target="_blank">mirror</a>, <a href="https://wiki.csclub.uwaterloo.ca" target="_blank">wiki</a>, <a href="https://mail.csclub.uwaterloo.ca" target="_blank">email service</a>, <a href="https://git.csclub.uwaterloo.ca" target="_blank">Gitea instance</a>, <a href="https://mattermost.csclub.uwaterloo.ca" target="_blank">Mattermost instance</a>, <a href="https://chat.csclub.uwaterloo.ca" target="_blank">TheLounge instance</a>, and much much more. I like to code, ski, and play chess and violin.<br />#btwiusearch (at least until <a href="https://youtu.be/dQw4w9WgXcQ" target="_blank">Linux expires in 2038</a>)
Does the usual way of adding links in Markdown ie.
[Raymond Li](https://raymond.li)
not work?Also, whenever we have an anchor tag with
target="_blank"
, it's generally considered a good idea to includerel="noopener noreferrer"
as well. However,a) as of 2021, most major browsers automatically use the
rel="noopener"
behaviour, andb) these links are provided by us and not by random users,
so it's not a big deal if we don't explicitly specific
rel="noopener noreferrer"
.Some links about this:
https://www.jitbit.com/alexblog/256-targetblank---the-most-underestimated-vulnerability-ever/
https://mathiasbynens.github.io/rel-noopener/
"role": "Events"
},
{
"name": "Santiago Montemayor",
Just a nitpick, but I think Santiago usually goes by
Santiago Montemayor Gomez
"role": "Discord Mod"
"name": "Kshama Patel",
"role": "Marketing",
"image": "/images/team/KshamaPatel.JPG"
I'm curious if we need to specify the image path here, since the filename aligns with the person's display name? (Maybe if we change the image extension to
.jpg
instead of.JPG
it'll work automatically?)"name": "Chris Xie",
"role": "Discord Mod"
"name": "Kshama Patel",
"role": "Marketing"
Yeah Kshama's image isn't showing up on the staging website: https://csclub.uwaterloo.ca/~a3thakra/csc/update-meet-team-page-winter-2022/about/team/
I think either (a) the image extension needs to be renamed to be lowercase (ie.
.jpg
and not.JPG
), or (b) we can change the code that automatically tries to find each person's image, and make sure it will look for.JPG
files as well.I will try to do a). For that I will have to do 2 push (1 without Kshama's picture and the one fixed with the lowercase
.jpg
) since git doesn't recognize the change when I change from JPG to jpg.Apparently, it's because the server is running on a Linux distribution, so it's case-sensitive: https://stackoverflow.com/questions/9433945/capitalized-jpg-extension-different-from-lowercase-jpg
OOPS I forgot to mention this earlier, but would it be possible to add a link to the termcom section at the top of the mobile page, similar to what we have for the other sections? I'm sorry for not noticing this earlier 😅
Looks good to me! We can always make more tweaks to this content in the future if needed (eg. changing names/images).
Thank you Emily for working on this and responding to feedback!
Hey @e26chiu, since this PR hasn't been merged yet - would you mind changing Laura Nguyen's image to use her new square headshot from the Committee Headshots folder, instead of her old rectangular one? It may also be a good idea to double-check that everyone else who uploaded new images is using those, and not their old ones. Thanks! :)
@e26chiu if you wouldn't mind adding the
alumni
tag to Anthony Brennan, Edwin Zhang, Elana Hashman, and Jennifer Zhou under syscom that would be great.@e26chiu Apologies for the all the pings! Just a couple of updates:
@e26chiu Let's merge this! 🚢
39cece999c
into main 1 year ago🎉
Reviewers
39cece999c
.