Link from [term] to [term]/[event] #412

Merged
j285he merged 2 commits from j285he-term-to-term-event into main 6 months ago
Collaborator
Closes #189 https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-term-to-term-event/events/
j285he added 1 commit 7 months ago
e75989f257 Link from term to term/event
j285he requested review from a258wang 7 months ago
j285he requested review from n3parikh 7 months ago
n3parikh approved these changes 6 months ago
n3parikh left a comment
Owner

LGTM with one minor change

LGTM with one minor change
year,
term,
slug,
linkedFromPage,
Owner

Could we use a different name for this prop? I think linkedFromPage doesn't really convey the intent and is a bit confusing. Maybe something like "titleLinked" or "headingLinked"?

Could we use a different name for this prop? I think `linkedFromPage` doesn't really convey the intent and is a bit confusing. Maybe something like "titleLinked" or "headingLinked"?
j285he added 1 commit 6 months ago
9a3e1634f4 Change prop name
j285he merged commit 0f1e8b7e81 into main 6 months ago

Reviewers

a258wang was requested for review 7 months ago
n3parikh approved these changes 6 months ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 0f1e8b7e81.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#412
Loading…
There is no content yet.