www
/
www-new
12
2
Fork 3
Code Issues 56 Pull Requests 29 Projects Releases Wiki Activity
Labels Milestones

Link from [term] to [term]/[event] #412

Merged
j285he merged 2 commits from j285he-term-to-term-event into main 1 year ago
Conversation 0 Commits 2 Files Changed 7
j285he commented 1 year ago
Collaborator

Closes #189

https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-term-to-term-event/events/

Closes #189 https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-term-to-term-event/events/
j285he added 1 commit 1 year ago
continuous-integration/drone/push Build is passing
Details
e75989f257 Link from term to term/event
j285he requested review from a258wang 1 year ago
j285he requested review from n3parikh 1 year ago
n3parikh approved these changes 1 year ago
n3parikh left a comment
Owner

LGTM with one minor change

LGTM with one minor change
components/EventCard.tsx Outdated
year,
term,
slug,
linkedFromPage,
n3parikh commented 1 year ago
Owner

Could we use a different name for this prop? I think linkedFromPage doesn't really convey the intent and is a bit confusing. Maybe something like "titleLinked" or "headingLinked"?

Could we use a different name for this prop? I think `linkedFromPage` doesn't really convey the intent and is a bit confusing. Maybe something like "titleLinked" or "headingLinked"?
j285he added 1 commit 1 year ago
continuous-integration/drone/push Build is passing
Details
9a3e1634f4 Change prop name
j285he merged commit 0f1e8b7e81 into main 1 year ago

Reviewers

a258wang was requested for review 1 year ago
n3parikh approved these changes 1 year ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 0f1e8b7e81.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
a258wang
n3parikh
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#412
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'j285he-term-to-term-event'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes