www
/
www-new
15
3
Fork 8
Code Issues 62 Pull Requests 53 Projects Releases Wiki Activity

Link from [term] to [term]/[event] #412

Merged
j285he merged 2 commits from j285he-term-to-term-event into main 2022-03-23 20:23:23 -04:00
Conversation 0 Commits 2 Files Changed 7 +41 -4
j285he commented 2022-03-16 21:43:00 -04:00
Member
Copy Link

Closes #189

https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-term-to-term-event/events/

Closes #189 https://csclub.uwaterloo.ca/~a3thakra/csc/j285he-term-to-term-event/events/
j285he added 1 commit 2022-03-16 21:43:02 -04:00
continuous-integration/drone/push Build is passing Details
e75989f257 Link from term to term/event
j285he requested review from a258wang 2022-03-16 21:43:14 -04:00
j285he requested review from n3parikh 2022-03-16 21:43:18 -04:00
n3parikh approved these changes 2022-03-23 08:47:12 -04:00
n3parikh left a comment
Owner
Copy Link

LGTM with one minor change

LGTM with one minor change
components/EventCard.tsx Outdated
@ -33,0 +37,4 @@
year,
term,
slug,
linkedFromPage,
n3parikh commented 2022-03-23 08:46:39 -04:00
Owner
Copy Link

Could we use a different name for this prop? I think linkedFromPage doesn't really convey the intent and is a bit confusing. Maybe something like "titleLinked" or "headingLinked"?

Could we use a different name for this prop? I think `linkedFromPage` doesn't really convey the intent and is a bit confusing. Maybe something like "titleLinked" or "headingLinked"?
j285he added 1 commit 2022-03-23 13:28:24 -04:00
continuous-integration/drone/push Build is passing Details
9a3e1634f4 Change prop name
j285he merged commit 0f1e8b7e81 into main 2022-03-23 20:23:23 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
a258wang
n3parikh
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#412
No description provided.
Delete Branch "j285he-term-to-term-event"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?