www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Add past execs page (Close #370) #417

Open
b72zhou wants to merge 21 commits from b72zhou-past-exec into main
pull from: b72zhou-past-exec
merge into: www:main
Conversation 3 Commits 21 Files Changed 25 +367 -12
b72zhou commented 2022-03-23 08:38:22 -04:00
Contributor
Copy Link
No description provided.
b72zhou added 1 commit 2022-03-23 08:38:23 -04:00
continuous-integration/drone/push Build is failing Details
cd2ab15ca6 functions for fetch execs data & collapsing feature prep
b72zhou added 1 commit 2022-03-25 09:17:56 -04:00
continuous-integration/drone/push Build is passing Details
8f5f1cce05 build pages
b72zhou added 1 commit 2022-03-25 09:22:49 -04:00
continuous-integration/drone/push Build is passing Details
e06d7c2044 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 2022-03-27 05:26:07 -04:00
continuous-integration/drone/push Build is passing Details
4040cdc232 page styles
b72zhou added 1 commit 2022-03-27 05:27:03 -04:00
continuous-integration/drone/push Build is passing Details
f0f5a6b865 Merge branch 'main' into b72zhou-past-exec
b72zhou added 2 commits 2022-03-27 08:38:58 -04:00
b72zhou changed title from WIP: Add past execs page (Close #370) to Add past execs page (Close #370) 2022-03-27 08:56:30 -04:00
b72zhou commented 2022-03-27 08:57:23 -04:00
Author
Contributor
Copy Link

This is how it looks like right now:

https://csclub.uwaterloo.ca/~a3thakra/csc/b72zhou-past-exec/about/executives/2021/spring/

Is this what we want? :)

Also, for some execs we don't have their pictures, is there any way we can have their pics?

This is how it looks like right now: https://csclub.uwaterloo.ca/~a3thakra/csc/b72zhou-past-exec/about/executives/2021/spring/ Is this what we want? :) Also, for some execs we don't have their pictures, is there any way we can have their pics?
b72zhou requested review from n3parikh 2022-03-27 23:08:56 -04:00
b72zhou requested review from j285he 2022-03-27 23:08:56 -04:00
b72zhou requested review from a258wang 2022-03-27 23:08:57 -04:00
b72zhou added 1 commit 2022-03-29 12:53:37 -04:00
continuous-integration/drone/push Build is passing Details
7ac7f6f768 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 2022-04-01 03:40:03 -04:00
continuous-integration/drone/push Build is passing Details
85f16bb18a Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 2022-04-03 20:52:09 -04:00
continuous-integration/drone/push Build is passing Details
514defe502 Merge branch 'main' into b72zhou-past-exec
a258wang commented 2022-04-27 15:29:42 -04:00
Owner
Copy Link

Hi @b72zhou, sorry for the delayed review!

Since there are only a few execs for each term, maybe instead of using the Archive page system like events and news, we could just have one page with all the past execs? Then we could use the TeamMember component (instead of TeamMemberCard) in order to save space.
Something like this (one section for each term):
image

For execs who are missing pictures, we should be able to go back in the repo's commit history to retrieve their images. (Maybe it would be worth creating a separate folder inside the images folder for past exec images, instead of keeping them in the team folder?)

Also, is there a reason why this text at the bottom is not left-aligned like most of the other text on the website?
image

Hi @b72zhou, sorry for the delayed review! Since there are only a few execs for each term, maybe instead of using the Archive page system like events and news, we could just have one page with all the past execs? Then we could use the `TeamMember` component (instead of `TeamMemberCard`) in order to save space. Something like this (one section for each term): ![image](/attachments/68057f6d-c997-4a0c-982b-2d8d772d21a9) For execs who are missing pictures, we should be able to go back in the repo's commit history to retrieve their images. (Maybe it would be worth creating a separate folder inside the `images` folder for past exec images, instead of keeping them in the `team` folder?) Also, is there a reason why this text at the bottom is not left-aligned like most of the other text on the website? ![image](/attachments/0410f7f2-29f9-4858-8cec-eb2123cb0723)
image.png
68 KiB
image.png
180 KiB
image.png
180 KiB
image.png
👍 1
b72zhou added 1 commit 2022-05-01 13:27:58 -04:00
continuous-integration/drone/push Build is passing Details
43b2ec7223 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 2022-05-08 21:01:43 -04:00
continuous-integration/drone/push Build is passing Details
d20eade5f6 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 2022-05-18 16:56:20 -04:00
continuous-integration/drone/push Build is passing Details
2f20f9a0ec Merge branch 'main' into b72zhou-past-exec
b72zhou commented 2022-05-18 17:05:12 -04:00
Author
Contributor
Copy Link

Hey @a258wang , I believe all your suggestions make sense and adjust the page accordingly. Do you have any suggestions on the design of the page? I found that the place between header and "Fall 2021" section for now is a bit weird, not quite sure how I can adjust it.

https://csclub.uwaterloo.ca/~a3thakra/csc/b72zhou-past-exec/about/executives/

Hey @a258wang , I believe all your suggestions make sense and adjust the page accordingly. Do you have any suggestions on the design of the page? I found that the place between header and "Fall 2021" section for now is a bit weird, not quite sure how I can adjust it. https://csclub.uwaterloo.ca/~a3thakra/csc/b72zhou-past-exec/about/executives/
b72zhou added 1 commit 2022-05-18 17:06:23 -04:00
continuous-integration/drone/push Build is failing Details
da4f660673 refactor to TeamMember
b72zhou added 1 commit 2022-05-22 19:45:29 -04:00
continuous-integration/drone/push Build is failing Details
7e11317842 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 2022-05-22 19:46:23 -04:00
continuous-integration/drone/push Build is passing Details
90cc61bc7b delete unnecessary lib fns
j285he reviewed 2022-05-31 18:01:46 -04:00
pages/about/executives.tsx Outdated
@ -0,0 +18,4 @@
interface Props {
F21Exec: Metadata[];
S21Exec: Metadata[];
W21Exec: Metadata[];
j285he commented 2022-05-31 18:01:42 -04:00
Member
Copy Link

If we want to add a new term of execs, we will have to manually import and update this page right? Ideally all we need to do is add a json file in content.

If we want to add a new term of execs, we will have to manually import and update this page right? Ideally all we need to do is add a json file in content.
👍 1
b72zhou added 1 commit 2022-06-01 15:50:08 -04:00
continuous-integration/drone/push Build is failing Details
9cc955e802 fix design
b72zhou added 1 commit 2022-06-01 15:55:28 -04:00
continuous-integration/drone/push Build is failing Details
265df6a2b3 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 2022-06-01 20:25:13 -04:00
continuous-integration/drone/push Build is failing Details
e05481dc9c Test images
b72zhou added 1 commit 2022-06-01 22:01:33 -04:00
continuous-integration/drone/push Build is failing Details
5fec0d6bbb Test optimize image
b72zhou added 1 commit 2022-06-02 09:44:32 -04:00
continuous-integration/drone/push Build is failing Details
853b222b50 Merge branch 'main' into b72zhou-past-exec
Some checks failed
continuous-integration/drone/push Build is failing
Required
Details
This pull request has changes conflicting with the target branch.
  • lib/events.ts
Sign in to join this conversation.
Reviewers
No reviewers
n3parikh
j285he
a258wang
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#417
No description provided.
Delete Branch "b72zhou-past-exec"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?