Add past execs page (Close #370) #417

Open
b72zhou wants to merge 21 commits from b72zhou-past-exec into main
Collaborator
There is no content yet.
b72zhou added 1 commit 10 months ago
cd2ab15ca6 functions for fetch execs data & collapsing feature prep
b72zhou added 1 commit 10 months ago
8f5f1cce05 build pages
b72zhou added 1 commit 10 months ago
e06d7c2044 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 10 months ago
4040cdc232 page styles
b72zhou added 1 commit 10 months ago
f0f5a6b865 Merge branch 'main' into b72zhou-past-exec
b72zhou added 2 commits 10 months ago
b72zhou changed title from WIP: Add past execs page (Close #370) to Add past execs page (Close #370) 10 months ago
Poster
Collaborator

This is how it looks like right now:

https://csclub.uwaterloo.ca/~a3thakra/csc/b72zhou-past-exec/about/executives/2021/spring/

Is this what we want? :)

Also, for some execs we don't have their pictures, is there any way we can have their pics?

This is how it looks like right now: https://csclub.uwaterloo.ca/~a3thakra/csc/b72zhou-past-exec/about/executives/2021/spring/ Is this what we want? :) Also, for some execs we don't have their pictures, is there any way we can have their pics?
b72zhou requested review from n3parikh 10 months ago
b72zhou requested review from j285he 10 months ago
b72zhou requested review from a258wang 10 months ago
b72zhou added 1 commit 10 months ago
7ac7f6f768 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 10 months ago
85f16bb18a Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 10 months ago
514defe502 Merge branch 'main' into b72zhou-past-exec
Owner

Hi @b72zhou, sorry for the delayed review!

Since there are only a few execs for each term, maybe instead of using the Archive page system like events and news, we could just have one page with all the past execs? Then we could use the TeamMember component (instead of TeamMemberCard) in order to save space.
Something like this (one section for each term):
image

For execs who are missing pictures, we should be able to go back in the repo's commit history to retrieve their images. (Maybe it would be worth creating a separate folder inside the images folder for past exec images, instead of keeping them in the team folder?)

Also, is there a reason why this text at the bottom is not left-aligned like most of the other text on the website?
image

Hi @b72zhou, sorry for the delayed review! Since there are only a few execs for each term, maybe instead of using the Archive page system like events and news, we could just have one page with all the past execs? Then we could use the `TeamMember` component (instead of `TeamMemberCard`) in order to save space. Something like this (one section for each term): ![image](/attachments/68057f6d-c997-4a0c-982b-2d8d772d21a9) For execs who are missing pictures, we should be able to go back in the repo's commit history to retrieve their images. (Maybe it would be worth creating a separate folder inside the `images` folder for past exec images, instead of keeping them in the `team` folder?) Also, is there a reason why this text at the bottom is not left-aligned like most of the other text on the website? ![image](/attachments/0410f7f2-29f9-4858-8cec-eb2123cb0723)
b72zhou added 1 commit 9 months ago
43b2ec7223 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 9 months ago
d20eade5f6 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 9 months ago
2f20f9a0ec Merge branch 'main' into b72zhou-past-exec
Poster
Collaborator

Hey @a258wang , I believe all your suggestions make sense and adjust the page accordingly. Do you have any suggestions on the design of the page? I found that the place between header and "Fall 2021" section for now is a bit weird, not quite sure how I can adjust it.

https://csclub.uwaterloo.ca/~a3thakra/csc/b72zhou-past-exec/about/executives/

Hey @a258wang , I believe all your suggestions make sense and adjust the page accordingly. Do you have any suggestions on the design of the page? I found that the place between header and "Fall 2021" section for now is a bit weird, not quite sure how I can adjust it. https://csclub.uwaterloo.ca/~a3thakra/csc/b72zhou-past-exec/about/executives/
b72zhou added 1 commit 9 months ago
da4f660673 refactor to TeamMember
b72zhou added 1 commit 8 months ago
7e11317842 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 8 months ago
90cc61bc7b delete unnecessary lib fns
j285he reviewed 8 months ago
interface Props {
F21Exec: Metadata[];
S21Exec: Metadata[];
W21Exec: Metadata[];
Collaborator

If we want to add a new term of execs, we will have to manually import and update this page right? Ideally all we need to do is add a json file in content.

If we want to add a new term of execs, we will have to manually import and update this page right? Ideally all we need to do is add a json file in content.
b72zhou added 1 commit 8 months ago
9cc955e802 fix design
b72zhou added 1 commit 8 months ago
265df6a2b3 Merge branch 'main' into b72zhou-past-exec
b72zhou added 1 commit 8 months ago
e05481dc9c Test images
b72zhou added 1 commit 8 months ago
5fec0d6bbb Test optimize image
b72zhou added 1 commit 8 months ago
853b222b50 Merge branch 'main' into b72zhou-past-exec

Reviewers

n3parikh was requested for review 10 months ago
j285he was requested for review 10 months ago
a258wang was requested for review 10 months ago
Some checks failed
continuous-integration/drone/push Build is failing
Required
Details
This pull request has changes conflicting with the target branch.
components/TeamMemberCard.tsx
lib/events.ts
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#417
Loading…
There is no content yet.