Add endDate to events #446

Merged
snedadah merged 23 commits from events-end-time into main 4 months ago
Collaborator
  • Added an endDate to events.
  • Renamed date to startDate, and updated in all past events.
  • Updated calander generation script.
  • Updated event display system to use endDate to display "upcoming" and "past" events.

Closes #406 and Closes #424

Usage:
Add an (optional) "endDate" property to an event's markdown file in order to add an end date to that event.

Staging:
https://csclub.uwaterloo.ca/~a3thakra/csc/events-end-time/

Older discussion happend in:
#434

Note: I have temporarily reverted the commits that change the older events to allow for code review. A few wierd artifcats are present from that in some of the event .md files, please ignore those, after unreverting before merging those will all be sorted out.

- Added an endDate to events. - Renamed date to startDate, and updated in all past events. - Updated calander generation script. - Updated event display system to use endDate to display "upcoming" and "past" events. Closes #406 and Closes #424 Usage: Add an (optional) "endDate" property to an event's markdown file in order to add an end date to that event. Staging: https://csclub.uwaterloo.ca/~a3thakra/csc/events-end-time/ Older discussion happend in: #434 Note: I have temporarily reverted the commits that change the older events to allow for code review. A few wierd artifcats are present from that in some of the event .md files, please ignore those, after unreverting before merging those will all be sorted out.
snedadah added 14 commits 4 months ago
snedadah added 2 commits 4 months ago
snedadah changed title from Added end time to events. to Add endDate to events 4 months ago
snedadah added 1 commit 4 months ago
snedadah added 1 commit 4 months ago
c196288b70
Revert "Renamed date to startDate in new events" for review purposes
a258wang reviewed 4 months ago
online,
registerLink,
permaLink,
endDate,
Owner

NIT: For readability purposes, it'd be nice to have endDate next to startDate - this would also match the order used in the Props interface and in other files. 🙂

NIT: For readability purposes, it'd be nice to have `endDate` next to `startDate` - this would also match the order used in the Props interface and in other files. 🙂
snedadah marked this conversation as resolved
a258wang reviewed 4 months ago
year,
term,
slug,
endDate,
Owner

NIT: same as above

NIT: same as above
snedadah marked this conversation as resolved
a258wang reviewed 4 months ago
Registration is not required to attend! We’ll just be sending you an email reminder, as well as inviting you to our calendar event.
📅 Event Date: Tuesday, September 14th from 7:00-8:30 pm ET via [Twitch](https://www.twitch.tv/uwcsclub) and [Discord](https://discord.gg/pHfYBCg)
📅 Event startDate: Tuesday, September 14th from 7:00-8:30 pm ET via [Twitch](https://www.twitch.tv/uwcsclub) and [Discord](https://discord.gg/pHfYBCg)
Owner

Just want to confirm that this and other similar occurrences will be fixed once we unrevert?

Just want to confirm that this and other similar occurrences will be fixed once we unrevert?
Poster
Collaborator

Yep it will be fixed after the revert, this commit was to fix the slight oversight on my part... I think I reverted in the wrong order which is why its a bit wierd now.

Yep it will be fixed after the revert, this commit was to fix the slight oversight on my part... I think I reverted in the wrong order which is why its a bit wierd now.
snedadah marked this conversation as resolved
a258wang reviewed 4 months ago
/*
Note:
This script will not work for events by default anymore, since events now have startDate instead of endDate
Owner

Do we think it's worth updating the script to reflect the newly named startDate/endDate fields?

It looks to me like this was a one-time use script, so it shouldn't be a big deal, but it also probably wouldn't be very difficult to update the script so it still works in case we ever need to use it again.

Do we think it's worth updating the script to reflect the newly named `startDate`/`endDate` fields? It looks to me like this was a one-time use script, so it shouldn't be a big deal, but it also probably wouldn't be very difficult to update the script so it still works in case we ever need to use it again.
Poster
Collaborator

The reason I did not fix it is that the news system is still using the old start date, so this script works for that. So whoever ends up using it in the future should fix it if they need to work with events, but not news.

The reason I did not fix it is that the news system is still using the old start date, so this script works for that. So whoever ends up using it in the future should fix it if they need to work with events, but not news.
snedadah marked this conversation as resolved
a258wang approved these changes 4 months ago
a258wang left a comment
Owner

Left a couple of comments, but otherwise LGTM! When unreverting, just double check to make sure that

  • staging works as expected
  • test events have been removed
  • event descriptions say "Event Date" instead of "Event startDate" 😛

and then this should be good to merge! 🚢

Left a couple of comments, but otherwise LGTM! When unreverting, just double check to make sure that - staging works as expected - test events have been removed - event descriptions say "Event Date" instead of "Event startDate" 😛 and then this should be good to merge! 🚢
snedadah added 1 commit 4 months ago
2d0858f22e
Reordered endDate
snedadah added 4 commits 4 months ago
snedadah merged commit f12ffbb925 into main 4 months ago
snedadah referenced this issue from a commit 4 months ago

Reviewers

a258wang approved these changes 4 months ago
continuous-integration/drone/push Build is passing
The pull request has been merged as f12ffbb925.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#446
Loading…
There is no content yet.