www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Redesign and update 'Meet the Team' data #452

Merged
j285he merged 17 commits from j285he-meet-the-team-s22 into main 2022-06-17 19:53:16 -04:00
Conversation 4 Commits 17 Files Changed 63 +2 -6
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 65eaaa12f0 - Show all commits

6
.vscode/settings.json vendored
View File

@ -40,11 +40,7 @@
"files.eol": "\n",
"[markdown]": {
"editor.wordWrap": "on",
"editor.quickSuggestions": {
"comments": "off",
"strings": "off",
"other": "off"
},
"editor.quickSuggestions": false,
"editor.tabSize": 4
}
}

2
pages/about/team.tsx
View File

@ -217,7 +217,7 @@ function sortTeam(team: Metadata[]): Metadata[] {
.sort(memberComparer);
const general = team.filter(({ role }) => !role).sort(memberComparer);
const others = team
j285he marked this conversation as resolved
a258wang commented 2022-06-15 22:09:00 -04:00
Review
Copy Link

Would role == null || role === "" be equivalent to !role here? (and also a couple lines below)

Would `role == null || role === ""` be equivalent to `!role` here? (and also a couple lines below)
.filter(({ role }) => !role && role !== "Team Lead")
.filter(({ role }) => !!role && role !== "Team Lead")
.sort(memberComparer);
return [...leads, ...general, ...others];