www
/
www-new
12
2
Fork 5
Code Issues 58 Pull Requests 40 Projects Releases Wiki Activity

Add some docs about architecture #459

Merged
a3thakra merged 2 commits from adi-architecture-docs into main 2022-06-19 01:45:43 -04:00
Conversation 1 Commits 2 Files Changed 4 +80 -5
a3thakra commented 2022-06-06 03:33:19 -04:00
Owner
Copy Link

#128

#128
a3thakra added 1 commit 2022-06-06 03:33:21 -04:00
continuous-integration/drone/push Build was killed Details
6bf9695dfc Add some docs about architecture
a3thakra commented 2022-06-06 03:33:59 -04:00
Author
Owner
Copy Link

Cancelled CI because we don't need it.

Cancelled CI because we don't need it.
a258wang reviewed 2022-06-06 22:14:36 -04:00
docs/architecture.md Outdated
@ -0,0 +27,4 @@
The two main scripts that we have today are:
- `generate-calendar`: to generate an ical file that consumes events using the `/lib` folder - writing the resulting file to `public/events.ics`
- `optimize-images`: to optimize images present in the `images` folder and write the optimized images in the `public/images` folder for the website to consume
a258wang commented 2022-06-06 22:14:36 -04:00
Owner
Copy Link

It might be nice to mention, either here or below, that the script also resizes images. (eg. "optimize-images: to resize and optimize images present in the images folder...")

It might be nice to mention, either here or below, that the script also resizes images. (eg. "optimize-images: to resize and optimize images present in the `images` folder...")
a258wang commented 2022-06-06 22:21:36 -04:00
Owner
Copy Link

It could also be nice to mention that we have npm run build:calendar and npm run build:images to generate the calendar and optimize the images, respectively. npm run build:images is particularly important, as none of the images will show up if you don't run it at least once.

Though at this rate, I'm thinking I should write some separate docs with more details about image optimization... 🙃

It could also be nice to mention that we have `npm run build:calendar` and `npm run build:images` to generate the calendar and optimize the images, respectively. `npm run build:images` is particularly important, as none of the images will show up if you don't run it at least once. Though at this rate, I'm thinking I should write some separate docs with more details about image optimization... 🙃
👍 1
a3thakra commented 2022-06-08 02:21:32 -04:00
Author
Owner
Copy Link

I'll defer the first one to later when we create a doc for the optimize images script.

I can include the second one in there.

I'll defer the first one to later when we create a doc for the optimize images script. I can include the second one in there.
👍 1
a3thakra marked this conversation as resolved
a3thakra added 1 commit 2022-06-18 04:21:20 -04:00
continuous-integration/drone/push Build was killed Details
eca55f4e2b Address feedback
snedadah reviewed 2022-06-18 16:07:36 -04:00
README.md
@ -23,3 +31,3 @@
# Deploy
## Deploy
- `groups` (make sure you're in the `www` group)
snedadah commented 2022-06-18 16:07:36 -04:00
Owner
Copy Link

I don't really know what groups are, I'm guessing this is groups that we can check on CEO and the solution is to contact syscom if someone is not in the group?

I don't really know what groups are, I'm guessing this is groups that we can check on CEO and the solution is to contact syscom if someone is not in the group?
a3thakra commented 2022-06-19 01:45:13 -04:00
Author
Owner
Copy Link

it's the linux groups command

it's the linux `groups` command
snedadah approved these changes 2022-06-18 16:10:17 -04:00
snedadah left a comment
Owner
Copy Link

This is super helpful, thanks for taking to time to write it out!!

This is super helpful, thanks for taking to time to write it out!!
a3thakra merged commit 767e32511d into main 2022-06-19 01:45:43 -04:00
a3thakra deleted branch adi-architecture-docs 2022-06-19 01:45:44 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
snedadah
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#459
No description provided.
Delete Branch "adi-architecture-docs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?