www
/
www-new
9
2
Fork 1
Code Issues 54 Pull Requests 20 Projects Releases Wiki Activity
Labels Milestones

Image Optimization - Create new ImagePool for each batch #470

Merged
a258wang merged 1 commits from amy-image-optimization-image-pool into main 3 months ago
Conversation 0 Commits 1 Files Changed 1
a258wang commented 3 months ago
Owner

We have been having issues with the image optimization script consuming egregious amounts of memory and failing CI as a result. Previously, we tried processing images in "batches" in order to reduce memory usage, however this fix did not work for long.

This PR changes the script so that we use a new ImagePool to process each batch of images. Preliminary results in my local environment and on CI seem promising, and this is a relatively low risk (and low effort) change, so let's see how it holds up.

We have been having issues with the image optimization script consuming egregious amounts of memory and failing CI as a result. Previously, we tried processing images in "batches" in order to reduce memory usage, however this fix did not work for long. This PR changes the script so that we use a new `ImagePool` to process each batch of images. Preliminary results in my local environment and on CI seem promising, and this is a relatively low risk (and low effort) change, so let's see how it holds up.
a258wang added 1 commit 3 months ago
continuous-integration/drone/push Build is passing
Details
f589ec9bfe Create new ImagePool for each batch
a258wang requested review from snedadah 3 months ago
snedadah approved these changes 3 months ago
a258wang merged commit 14ef810ad9 into main 3 months ago
a258wang deleted branch amy-image-optimization-image-pool 3 months ago

Reviewers

snedadah approved these changes 3 months ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 14ef810ad9.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
snedadah
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#470
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'amy-image-optimization-image-pool'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes