www
/
www-new
9
2
Fork 1
Code Issues 54 Pull Requests 20 Projects Releases Wiki Activity
Labels Milestones

Create members.json api #489

Merged
a3thakra merged 8 commits from adi-member-json-api into main 2 months ago
Conversation 1 Commits 8 Files Changed 23
a3thakra commented 2 months ago
Owner

I changed some other code along the way ... which makes this PR slightly long :') rip.

closes #472

takes a stab at #466

https://csclub.uwaterloo.ca/~a3thakra/csc/adi-member-json-api/api/members.json

I changed some other code along the way ... which makes this PR slightly long :') rip. closes #472 takes a stab at #466 https://csclub.uwaterloo.ca/~a3thakra/csc/adi-member-json-api/api/members.json
a3thakra added 3 commits 2 months ago
continuous-integration/drone/push Build is failing
Details
5b32153613 Create members api
continuous-integration/drone/push Build is passing
Details
e0528681c1 Simplify teams page
a3thakra force-pushed adi-member-json-api from e0528681c1 to 6eb8d4d064 2 months ago
a3thakra added 1 commit 2 months ago
continuous-integration/drone/push Build is passing
Details
9263fdd10a Add build:api to build
a3thakra added 2 commits 2 months ago
continuous-integration/drone/push Build is passing
Details
2cbba93d9d Add json schema
a258wang approved these changes 2 months ago
a258wang left a comment
Owner

Looks good overall, thanks for working on this Adi! Though next time please split unrelated changes into separate PRs. 😆

Looks good overall, thanks for working on this Adi! Though next time please split unrelated changes into separate PRs. 😆
public/api/schema/members.json
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
a258wang commented 2 months ago
Owner

Dropping this here for personal reference: https://json-schema.org/

Dropping this here for personal reference: https://json-schema.org/
a3thakra marked this conversation as resolved
public/api/schema/members.json Outdated
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"title": "Member list",
"description": "List of all members of the Computer Science Club of the University of Waterloo",
a258wang commented 2 months ago
Owner

NIT: List of all current members

NIT: List of all **current** members
a3thakra commented 2 months ago
Poster
Owner

fixed!

fixed!
a3thakra marked this conversation as resolved
scripts/api/members.ts
members,
};
await writeFile("public/api/members.json", JSON.stringify(result));
a258wang commented 2 months ago
Owner

Just wanted to note, I think NextJS has some kind of API Routing thing which maps files in pages/api to /api/* - I wonder how that would interact with us hosting a static file like this at /api/*?

(This probably isn't relevant though, as we are aiming to keep the site static so there's no reason to be using the API Routing shenanigans.)

https://nextjs.org/docs/api-routes/introduction

Just wanted to note, I think NextJS has some kind of API Routing thing which maps files in `pages/api` to `/api/*` - I wonder how that would interact with us hosting a static file like this at `/api/*`? (This probably isn't relevant though, as we are aiming to keep the site static so there's no reason to be using the API Routing shenanigans.) https://nextjs.org/docs/api-routes/introduction
a3thakra commented 2 months ago
Poster
Owner

yep, that one is only for a non-static website.

yep, that one is only for a non-static website.
a3thakra commented 2 months ago
Poster
Owner

I think it's okay for now, even if we add nextjs api later on, it should still work.

I think it's okay for now, even if we add nextjs api later on, it should still work.
a3thakra marked this conversation as resolved
scripts/change-dates.ts Outdated
/*
Note:
This script will not work for events by default anymore, since events now have startDate instead of endDate
a258wang commented 2 months ago
Owner

NIT: is this the best location in the file for this comment? Not sure if it should go right at the top, or right above the main function, or if this is fine. 🤔

NIT: is this the best location in the file for this comment? Not sure if it should go right at the top, or right above the main function, or if this is fine. 🤔
a3thakra commented 2 months ago
Poster
Owner

Since the script doesn't work, i decided to delete it. I don't think we'll be needing this. Even if we do it's fairly easy to rewrite :P

Since the script doesn't work, i decided to delete it. I don't think we'll be needing this. Even if we do it's fairly easy to rewrite :P
👍 1
a3thakra marked this conversation as resolved
utils.ts
skipCurrent?: boolean;
}
export function* getTermYear(
a258wang commented 2 months ago
Owner

This is very cool, did not know it was a thing 👀

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*

This is very cool, did not know it was a thing 👀 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*
👀 1
a3thakra marked this conversation as resolved
a3thakra added 1 commit 2 months ago
continuous-integration/drone/push Build is passing
Details
eacb858faa Fix comments
a3thakra commented 2 months ago
Poster
Owner

whoopsie got a little carried away :'(

whoopsie got a little carried away :'(
a3thakra added 1 commit 2 months ago
a3thakra merged commit be308f6249 into main 2 months ago
a3thakra referenced this issue from a commit 2 months ago
Create members.json api (#489)
a3thakra deleted branch adi-member-json-api 2 months ago

Reviewers

a258wang approved these changes 2 months ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as be308f6249.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
a258wang
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#489
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'adi-member-json-api'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes