www
/
www-new
12
3
Fork 5
Code Issues 58 Pull Requests 42 Projects Releases Wiki Activity

Create members.json api #489

Merged
a3thakra merged 8 commits from adi-member-json-api into main 2022-08-08 04:31:17 -04:00
Conversation 1 Commits 8 Files Changed 23 +452 -430
a3thakra commented 2022-08-07 19:57:27 -04:00
Owner
Copy Link

I changed some other code along the way ... which makes this PR slightly long :') rip.

closes #472

takes a stab at #466

https://csclub.uwaterloo.ca/~a3thakra/csc/adi-member-json-api/api/members.json

I changed some other code along the way ... which makes this PR slightly long :') rip. closes #472 takes a stab at #466 https://csclub.uwaterloo.ca/~a3thakra/csc/adi-member-json-api/api/members.json
a3thakra force-pushed adi-member-json-api from e0528681c1 to 6eb8d4d064 2022-08-07 20:06:37 -04:00 Compare
a3thakra added 1 commit 2022-08-07 20:08:28 -04:00
continuous-integration/drone/push Build is passing Details
9263fdd10a Add build:api to build
a3thakra added 2 commits 2022-08-07 20:37:56 -04:00
continuous-integration/drone/push Build is passing Details
2cbba93d9d Add json schema
a258wang approved these changes 2022-08-08 03:19:36 -04:00
a258wang left a comment
Owner
Copy Link

Looks good overall, thanks for working on this Adi! Though next time please split unrelated changes into separate PRs. 😆

Looks good overall, thanks for working on this Adi! Though next time please split unrelated changes into separate PRs. 😆
public/api/schema/members.json
@ -0,0 +1,25 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
a258wang commented 2022-08-08 03:18:59 -04:00
Owner
Copy Link

Dropping this here for personal reference: https://json-schema.org/

Dropping this here for personal reference: https://json-schema.org/
a3thakra marked this conversation as resolved
public/api/schema/members.json Outdated
@ -0,0 +1,25 @@
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"title": "Member list",
"description": "List of all members of the Computer Science Club of the University of Waterloo",
a258wang commented 2022-08-08 03:05:48 -04:00
Owner
Copy Link

NIT: List of all current members

NIT: List of all **current** members
a3thakra commented 2022-08-08 04:06:37 -04:00
Author
Owner
Copy Link

fixed!

fixed!
a3thakra marked this conversation as resolved
scripts/api/members.ts
@ -0,0 +13,4 @@
members,
};
await writeFile("public/api/members.json", JSON.stringify(result));
a258wang commented 2022-08-08 03:17:46 -04:00
Owner
Copy Link

Just wanted to note, I think NextJS has some kind of API Routing thing which maps files in pages/api to /api/* - I wonder how that would interact with us hosting a static file like this at /api/*?

(This probably isn't relevant though, as we are aiming to keep the site static so there's no reason to be using the API Routing shenanigans.)

https://nextjs.org/docs/api-routes/introduction

Just wanted to note, I think NextJS has some kind of API Routing thing which maps files in `pages/api` to `/api/*` - I wonder how that would interact with us hosting a static file like this at `/api/*`? (This probably isn't relevant though, as we are aiming to keep the site static so there's no reason to be using the API Routing shenanigans.) https://nextjs.org/docs/api-routes/introduction
a3thakra commented 2022-08-08 04:01:50 -04:00
Author
Owner
Copy Link

yep, that one is only for a non-static website.

yep, that one is only for a non-static website.
a3thakra commented 2022-08-08 04:04:27 -04:00
Author
Owner
Copy Link

I think it's okay for now, even if we add nextjs api later on, it should still work.

I think it's okay for now, even if we add nextjs api later on, it should still work.
a3thakra marked this conversation as resolved
scripts/change-dates.ts Outdated
@ -23,0 +18,4 @@
/*
Note:
This script will not work for events by default anymore, since events now have startDate instead of endDate
a258wang commented 2022-08-08 03:03:01 -04:00
Owner
Copy Link

NIT: is this the best location in the file for this comment? Not sure if it should go right at the top, or right above the main function, or if this is fine. 🤔

NIT: is this the best location in the file for this comment? Not sure if it should go right at the top, or right above the main function, or if this is fine. 🤔
a3thakra commented 2022-08-08 04:06:21 -04:00
Author
Owner
Copy Link

Since the script doesn't work, i decided to delete it. I don't think we'll be needing this. Even if we do it's fairly easy to rewrite :P

Since the script doesn't work, i decided to delete it. I don't think we'll be needing this. Even if we do it's fairly easy to rewrite :P
👍 1
a3thakra marked this conversation as resolved
utils.ts
@ -24,0 +32,4 @@
skipCurrent?: boolean;
}
export function* getTermYear(
a258wang commented 2022-08-08 03:01:22 -04:00
Owner
Copy Link

This is very cool, did not know it was a thing 👀

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*

This is very cool, did not know it was a thing 👀 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*
👀 1
a3thakra marked this conversation as resolved
a3thakra added 1 commit 2022-08-08 04:05:31 -04:00
continuous-integration/drone/push Build is passing Details
eacb858faa Fix comments
a3thakra commented 2022-08-08 04:07:05 -04:00
Author
Owner
Copy Link

whoopsie got a little carried away :'(

whoopsie got a little carried away :'(
a3thakra added 1 commit 2022-08-08 04:19:40 -04:00
continuous-integration/drone/push Build is passing Details
ec8b766aba fix scenario when goBackwards is true + start is a number
a3thakra merged commit be308f6249 into main 2022-08-08 04:31:17 -04:00
a3thakra deleted branch adi-member-json-api 2022-08-08 04:31:23 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
a258wang
Labels
Clear labels   
a11y

   
Backlog

   
Blocked

   
Bug

   
Content

   
Dependencies

   
Design

   
Feature Request

   
Good First Issue

   
In Progress

   
Performance

   
Priority - High

   
Priority - Low

   
Priority - Medium

   
Untriaged
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#489
No description provided.
Delete Branch "adi-member-json-api"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?