Fix exec fetching and add events #491
Labels
No Label
a11y
Backlog
Blocked
Bug
Content
Dependencies
Design
Feature Request
Good First Issue
In Progress
Performance
Priority - High
Priority - Low
Priority - Medium
Untriaged
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: www/www-new#491
Loading…
Reference in New Issue
No description provided.
Delete Branch "amy-news-2022-09-01"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem: When building the Meet the Team page using LDAP (in CI), we were only checking CSC members for the "current" term (Fall 2022) to see if any of them were execs. Since our actual current execs (the Spring 2022 execs, since Fall 2022 elections have not occurred yet) have not renewed their memberships for Fall 2022, the script was unable to find individuals for the Prez/VP/AVP/Trez positions, which caused an error.
Solution:
Staging: https://csclub.uwaterloo.ca/~a3thakra/csc/amy-news-2022-09-01
Sorry, aren't the images supposed to be square?
Otherwise looks good
Actually sorry, build is failing. hmm
There only seems to be a rectangular image for this event, and having a non-square image technically doesn't break anything, so I just included it lol.
The build error seems unrelated, but I'll look into it 🤔
(re-running CI didn't fix it)
017c44aaca
to33b5baaff2
Add Bootcamp mentor news and Google eventto Fix exec fetching and add eventsThe build failure was completely unrelated to my changes (our nightly builds actually started failing a couple days ago), but I've included the fix in this PR because
screw the best practice of keeping PRs small and including related changes onlyit's not too big and also I got too lazy to make a separate PR. Sorry. 😛Looks good, can you just confirm that if you have person A as Pres for Spring, and person B as Pres for Fall, person B shows up?
@ -128,0 +134,4 @@
formattedExec = orderedExecPositions
.map((position) => {
const fullName = execMembers[position];
if (fullName == undefined) {
Please use
===
or specify if you wantfullName === undefined | fullName === null
etcI remember Adi once said something about how it's okay to use
==
for checking equality withnull
orundefined
, since in most cases there's no practical difference betweennull
vs.undefined
. (In this case, I think the variable would beundefined
rather thannull
, but we'd still get an error if it wasnull
, so we may as well apply the same logic to handle both cases and keep the conditional check concise instead of writingfullName === undefined || fullName === null
.)With the way ceo (CSC's member management system thing) is set up, we only keep track of the current execs (not "execs for each term"), so yeah we'll display the Fall execs as soon as those are updated in the system (ie. right after Fall elections).