always remove tmpdir in deploy.sh #530

Merged
snedadah merged 1 commits from merenber/always-remove-tmpdir into main 2 months ago
Owner

This change ensures that the temporary directory created by mkdir --directory is always removed when deploy.sh exits, whether or not the script succeeded.

It also modifies the git clone command to use the file:// protocol instead of HTTPS, to speed up the download.

This change ensures that the temporary directory created by `mkdir --directory` is always removed when `deploy.sh` exits, whether or not the script succeeded. It also modifies the `git clone` command to use the `file://` protocol instead of HTTPS, to speed up the download.
merenber added 1 commit 2 months ago
dfd70fd08f always remove tmpdir in deploy.sh
snedadah approved these changes 2 months ago
snedadah left a comment
Owner

thanks for making this change! note that the staging doesn't actually use this script,
so I just manually tested it using the production script and it seemed to work fine.

thanks for making this change! note that the staging doesn't actually use this script, so I just manually tested it using the production script and it seemed to work fine.
snedadah merged commit 7e5466e2bc into main 2 months ago

Reviewers

snedadah approved these changes 2 months ago
continuous-integration/drone/push Build is passing
The pull request has been merged as 7e5466e2bc.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#530
Loading…
There is no content yet.