www
/
www-new
12
2
Fork 3
Code Issues 56 Pull Requests 30 Projects Releases Wiki Activity
Labels Milestones

always remove tmpdir in deploy.sh #530

Merged
snedadah merged 1 commits from merenber/always-remove-tmpdir into main 4 months ago
Conversation 0 Commits 1 Files Changed 1
merenber commented 4 months ago
Owner

This change ensures that the temporary directory created by mkdir --directory is always removed when deploy.sh exits, whether or not the script succeeded.

It also modifies the git clone command to use the file:// protocol instead of HTTPS, to speed up the download.

This change ensures that the temporary directory created by `mkdir --directory` is always removed when `deploy.sh` exits, whether or not the script succeeded. It also modifies the `git clone` command to use the `file://` protocol instead of HTTPS, to speed up the download.
merenber added 1 commit 4 months ago
continuous-integration/drone/push Build is passing
Details
dfd70fd08f always remove tmpdir in deploy.sh
snedadah approved these changes 4 months ago
snedadah left a comment
Owner

thanks for making this change! note that the staging doesn't actually use this script,
so I just manually tested it using the production script and it seemed to work fine.

thanks for making this change! note that the staging doesn't actually use this script, so I just manually tested it using the production script and it seemed to work fine.
snedadah merged commit 7e5466e2bc into main 4 months ago

Reviewers

snedadah approved these changes 4 months ago
continuous-integration/drone/push Build is passing
Details
The pull request has been merged as 7e5466e2bc.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
snedadah
Labels
Apply labels
Clear labels
a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
No Label a11y Backlog Blocked Bug Content Dependencies Design Feature Request Good First Issue In Progress Performance Priority - High Priority - Low Priority - Medium Untriaged
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: www/www-new#530
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'merenber/always-remove-tmpdir'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes