always remove tmpdir in deploy.sh #530

merenber · 2022-11-27T13:41:46-05:00

merenber commented

2022-11-27 13:41:46 -05:00

This change ensures that the temporary directory created by mkdir --directory is always removed when deploy.sh exits, whether or not the script succeeded.

It also modifies the git clone command to use the file:// protocol instead of HTTPS, to speed up the download.

This change ensures that the temporary directory created by `mkdir --directory` is always removed when `deploy.sh` exits, whether or not the script succeeded. It also modifies the `git clone` command to use the `file://` protocol instead of HTTPS, to speed up the download.

merenber added 1 commit 2022-11-27 13:41:48 -05:00

continuous-integration/drone/push Build is passing Details

dfd70fd08f always remove tmpdir in deploy.sh

snedadah approved these changes 2022-11-27 14:59:39 -05:00

snedadah left a comment

thanks for making this change! note that the staging doesn't actually use this script,
so I just manually tested it using the production script and it seemed to work fine.

thanks for making this change! note that the staging doesn't actually use this script, so I just manually tested it using the production script and it seemed to work fine.

snedadah merged commit 7e5466e2bc into main

2022-11-27 15:00:09 -05:00

snedadah referenced this issue from a commit

2022-11-27 15:00:11 -05:00

always remove tmpdir in deploy.sh (#530)

Sign in to join this conversation.

No reviewers